[VM/Service] Write the info files associated with resident compilers started by tests into temp directories

Also re-enables the tests on vm-win-release-x64 because having different
tests try to communicate with the same resident compiler in parallel was
definitely a source of flakiness, and I don't think there's any way of
knowing whether or not it was the only source of flakiness without
re-enabling it on the bots.

Issue: #59909
Change-Id: I831f32779e0946fb35811edaeaaa5ddb38e51d97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404460
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Derek Xu <[email protected]>

Author: derekxu16

pkg/pkg.status

@@ -67,12 +67,7 @@ vm/test/kernel_front_end_test: Slow, Pass
 vm/test/transformations/ffi_test: Slow, Pass # https://github.com/dart-lang/sdk/issues/54950
 vm/test/transformations/type_flow/transformer_test: Slow, Pass
 vm/testcases/*: SkipByDesign # These are not tests but input for tests.
-vm_service/test/breakpoint_resolution_after_reloading_with_resident_compiler_test: Skip # issue 59909
 vm_service/test/cpu_samples_stream_test: Slow, Pass # Requires CPU sample buffer to fill.
-vm_service/test/eval_with_resident_compiler_test: Skip # issue 59909
-vm_service/test/evaluate_in_frame_rpc_with_resident_compiler_test: Skip # issue 59909
-vm_service/test/evaluate_in_frame_with_scope_with_resident_compiler_test: Skip # issue 59909
-vm_service/test/evaluate_with_scope_with_resident_compiler_test: Skip # issue 59999
 vm_service/test/get_cpu_samples_rpc_test: Slow, Pass # Does some computation to ensure CPU samples are collected.
 vm_service/test/get_perfetto_cpu_samples_rpc_test: Slow, Pass # Does some computation to ensure CPU samples are collected.
 vm_service/test/reload_sources_with_resident_compiler_test: Skip # issue 59909
@@ -354,6 +349,13 @@ dartdev/test/commands/info_windows_test: SkipByDesign
 analysis_server/test/integration/edit/sort_members_test: Slow, Pass
 analysis_server/test/socket_server_test: Skip # Pass, Slow
 
+[ $arch != x64 || $mode != release || $runtime != vm || $system != windows ]
+vm_service/test/breakpoint_resolution_after_reloading_with_resident_compiler_test: Skip # issue 59909
+vm_service/test/eval_with_resident_compiler_test: Skip # issue 59909
+vm_service/test/evaluate_in_frame_rpc_with_resident_compiler_test: Skip # issue 59909
+vm_service/test/evaluate_in_frame_with_scope_with_resident_compiler_test: Skip # issue 59909
+vm_service/test/evaluate_with_scope_with_resident_compiler_test: Skip # issue 59999
+
 [ $mode == debug || $runtime != vm || $system == android ]
 vm/test/modular_kernel_plus_aot_test: SkipByDesign # This test should only run if binary is run from build dir
 

pkg/vm_service/test/common/test_helper.dart

@@ -115,7 +115,13 @@ class _ServiceTesteeLauncher {
     bool pauseOnUnhandledExceptions,
     bool testeeControlsServer,
     bool useAuthToken,
-    bool shouldTesteeBeLaunchedWithDartRunResident,
+
+    /// If non-null, any compilation requests sent from the testee VM will be
+    /// sent to the resident frontend compiler associated with
+    /// [residentCompilerInfoFilePath] rather than the testee VM's kernel
+    /// isolate. If null, then those requests will be sent to the testee VM's
+    /// kernel isolate.
+    String? residentCompilerInfoFilePath,
     List<String>? experiments,
     List<String>? extraArgs,
   ) {
@@ -125,7 +131,7 @@ class _ServiceTesteeLauncher {
       pauseOnUnhandledExceptions,
       testeeControlsServer,
       useAuthToken,
-      shouldTesteeBeLaunchedWithDartRunResident,
+      residentCompilerInfoFilePath,
       experiments,
       extraArgs,
     );
@@ -137,7 +143,13 @@ class _ServiceTesteeLauncher {
     bool pauseOnUnhandledExceptions,
     bool testeeControlsServer,
     bool useAuthToken,
-    bool shouldTesteeBeLaunchedWithDartRunResident,
+
+    /// If non-null, any compilation requests sent from the testee VM will be
+    /// sent to the resident frontend compiler associated with
+    /// [residentCompilerInfoFilePath] rather than the testee VM's kernel
+    /// isolate. If null, then those requests will be sent to the testee VM's
+    /// kernel isolate.
+    String? residentCompilerInfoFilePath,
     List<String>? experiments,
     List<String>? extraArgs,
   ) {
@@ -169,8 +181,12 @@ class _ServiceTesteeLauncher {
       fullArgs.add('--enable-vm-service:0');
     }
 
-    if (shouldTesteeBeLaunchedWithDartRunResident) {
-      fullArgs.addAll(['run', '--resident']);
+    if (residentCompilerInfoFilePath != null) {
+      fullArgs.addAll([
+        'run',
+        '--resident',
+        '--resident-compiler-info-file=$residentCompilerInfoFilePath',
+      ]);
     }
     fullArgs.addAll(args);
 
@@ -202,7 +218,13 @@ class _ServiceTesteeLauncher {
     bool pauseOnUnhandledExceptions,
     bool testeeControlsServer,
     bool useAuthToken,
-    bool shouldTesteeBeLaunchedWithDartRunResident,
+
+    /// If non-null, any compilation requests sent from the testee VM will be
+    /// sent to the resident frontend compiler associated with
+    /// [residentCompilerInfoFilePath] rather than the testee VM's kernel
+    /// isolate. If null, then those requests will be sent to the testee VM's
+    /// kernel isolate.
+    String? residentCompilerInfoFilePath,
     List<String>? experiments,
     List<String>? extraArgs,
   ) {
@@ -212,7 +234,7 @@ class _ServiceTesteeLauncher {
       pauseOnUnhandledExceptions,
       testeeControlsServer,
       useAuthToken,
-      shouldTesteeBeLaunchedWithDartRunResident,
+      residentCompilerInfoFilePath,
       experiments,
       extraArgs,
     ).then((p) {
@@ -286,6 +308,16 @@ class _ServiceTesterRunner {
     bool allowForNonZeroExitCode = false,
     VmServiceFactory serviceFactory = VmService.defaultFactory,
   }) async {
+    final tempDir = io.Directory.systemTemp.createTempSync();
+    final String? residentCompilerInfoFilePath;
+    if (shouldTesteeBeLaunchedWithDartRunResident) {
+      residentCompilerInfoFilePath =
+          '${tempDir.path}${io.Platform.pathSeparator}'
+          'resident_compiler_info.txt';
+    } else {
+      residentCompilerInfoFilePath = null;
+    }
+
     final process = _ServiceTesteeLauncher(scriptName);
     late VmService vm;
     late IsolateRef isolate;
@@ -297,7 +329,7 @@ class _ServiceTesterRunner {
         pauseOnUnhandledExceptions,
         testeeControlsServer,
         useAuthToken,
-        shouldTesteeBeLaunchedWithDartRunResident,
+        residentCompilerInfoFilePath,
         experiments,
         extraArgs,
       )
@@ -366,13 +398,19 @@ $st
     final exitCode = await process.exitCode;
     if (shouldTesteeBeLaunchedWithDartRunResident) {
       print(
-        '** Shutting down resident frontend compiler that was used by VM '
+        '** Shutting down resident frontend compiler associated with '
+        '$residentCompilerInfoFilePath that was used by VM '
         'Service tests',
       );
       await io.Process.run(
         io.Platform.executable,
-        ['compilation-server', 'shutdown'],
+        [
+          'compilation-server',
+          'shutdown',
+          '--resident-compiler-info-file=$residentCompilerInfoFilePath',
+        ],
       );
+      tempDir.deleteSync(recursive: true);
     }
     if (exitCode != 0) {
       if (!(process.killedByTester || allowForNonZeroExitCode)) {