[analysis_server] Ensure all snippet tests verify both selection + linked edit ranges

Removes conditions around verifying selection/linked edit ranges to ensure all snippet tests verify both for completeness (to avoid new tests accidentally not verifying something they should).

Change-Id: I9474379a200be12012a71999baa82318b0e904e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433820
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server/test/services/snippets/dart/flutter_stateful_widget_test.dart

@@ -31,20 +31,20 @@ class FlutterStatefulWidgetTest extends FlutterSnippetProducerTest {
     var expectedCode = r'''
 import 'package:flutter/widgets.dart';
 
-class MyWidget extends StatefulWidget {
-  const MyWidget({Key? key}) : super(key: key);
+class /*0*/MyWidget extends StatefulWidget {
+  const /*1*/MyWidget({Key? key}) : super(key: key);
 
   @override
-  State<MyWidget> createState() => _MyWidgetState();
+  State</*2*/MyWidget> createState() => _/*3*/MyWidgetState();
 }
 
-class _MyWidgetState extends State<MyWidget> {
+class _/*4*/MyWidgetState extends State</*5*/MyWidget> {
   @override
   Widget build(BuildContext context) {
-    return const Placeholder();
+    return [!const Placeholder()!];
   }
 }''';
-    await assertSnippetResult(code, expectedCode);
+    await assertFlutterSnippetResult(code, expectedCode, 'MyWidget');
   }
 
   Future<void> test_notValid_notFlutterProject() async {

pkg/analysis_server/test/services/snippets/dart/flutter_stateful_widget_with_animation_controller_test.dart

@@ -32,14 +32,14 @@ class FlutterStatefulWidgetWithAnimationControllerTest
     var expectedCode = r'''
 import 'package:flutter/widgets.dart';
 
-class MyWidget extends StatefulWidget {
-  const MyWidget({Key? key}) : super(key: key);
+class /*0*/MyWidget extends StatefulWidget {
+  const /*1*/MyWidget({Key? key}) : super(key: key);
 
   @override
-  State<MyWidget> createState() => _MyWidgetState();
+  State</*2*/MyWidget> createState() => _/*3*/MyWidgetState();
 }
 
-class _MyWidgetState extends State<MyWidget>
+class _/*4*/MyWidgetState extends State</*5*/MyWidget>
     with SingleTickerProviderStateMixin {
   late AnimationController _controller;
 
@@ -57,10 +57,10 @@ class _MyWidgetState extends State<MyWidget>
 
   @override
   Widget build(BuildContext context) {
-    return const Placeholder();
+    return [!const Placeholder()!];
   }
 }''';
-    await assertSnippetResult(code, expectedCode);
+    await assertFlutterSnippetResult(code, expectedCode, 'MyWidget');
   }
 
   Future<void> test_notValid_notFlutterProject() async {

pkg/analysis_server/test/services/snippets/dart/if_else_statement_test.dart

@@ -32,7 +32,7 @@ void f() {
 ''';
     var expectedCode = r'''
 void f() {
-  if (condition) {
+  if ([!condition!]) {
     ^
   } else {
     /**/
@@ -53,7 +53,7 @@ void f() {
     var expectedCode = r'''
 void f() {
   if (true) {
-    if (condition) {
+    if ([!condition!]) {
       ^
     } else {
       /**/

pkg/analysis_server/test/services/snippets/dart/test_support.dart

@@ -54,31 +54,26 @@ abstract class DartSnippetProducerTest extends AbstractSingleUnitTest {
     expect(codeResult, expectedCode.code);
 
     // Check selection/position.
-    expect(snippet.change.selection!.file, testFile.path);
-    if (expectedCode.positions.length == 1) {
-      expect(snippet.change.selection!.offset, expectedCode.position.offset);
-    }
-
-    // And linked edits if the test is verifying them.
-    if (expectedCode.ranges.isNotEmpty) {
-      var expectedLinkedGroups =
-          expectedCode.ranges
-              .map(
-                (range) => {
-                  'positions': [
-                    {'file': testFile.path, 'offset': range.sourceRange.offset},
-                  ],
-                  'length': range.sourceRange.length,
-                  'suggestions': [],
-                },
-              )
-              .toSet();
-      var actualLinkedGroups =
-          snippet.change.linkedEditGroups
-              .map((group) => group.toJson())
-              .toSet();
-      expect(actualLinkedGroups, equals(expectedLinkedGroups));
-    }
+    var selection = snippet.change.selection!;
+    expect(selection.file, testFile.path);
+    expect(selection.offset, expectedCode.position.offset);
+
+    // Verify all linked edits/placeholders.
+    var expectedLinkedGroups =
+        expectedCode.ranges
+            .map(
+              (range) => {
+                'positions': [
+                  {'file': testFile.path, 'offset': range.sourceRange.offset},
+                ],
+                'length': range.sourceRange.length,
+                'suggestions': [],
+              },
+            )
+            .toSet();
+    var actualLinkedGroups =
+        snippet.change.linkedEditGroups.map((group) => group.toJson()).toSet();
+    expect(actualLinkedGroups, equals(expectedLinkedGroups));
 
     return snippet;
   }
@@ -110,7 +105,7 @@ abstract class DartSnippetProducerTest extends AbstractSingleUnitTest {
 
 abstract class FlutterSnippetProducerTest extends DartSnippetProducerTest {
   /// A version of [assertSnippetResult] that expects all positions in
-  /// [expectedCode] to match a single linked edit group for the text
+  /// [expected] to match a single linked edit group for the text
   /// [linkedGroupText] and the selection to be at the marked range.
   Future<void> assertFlutterSnippetResult(
     String content,