[cq] remove unnecessary ignores

See: #35234

Change-Id: I4563df48df9d71332b3de6fabea9176e199c1ad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404202
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/analysis_server/lib/src/services/correction/fix/data_driven/code_fragment_parser.dart

@@ -11,7 +11,6 @@ import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/src/utilities/extensions/string.dart';
 
 // Several "report" functions intentionally return a `Null`-typed value.
-// ignore_for_file: prefer_void_to_null
 
 /// A parser for the textual representation of a code fragment.
 class CodeFragmentParser {

pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_parser.dart

@@ -27,7 +27,6 @@ import 'package:collection/collection.dart';
 import 'package:yaml/yaml.dart';
 
 // Several "report" functions intentionally return a `Null`-typed value.
-// ignore_for_file: prefer_void_to_null
 
 /// Information used to report errors when translating a node.
 class ErrorContext {

pkg/analysis_server/test/lsp/flutter_outline_test.dart

@@ -30,7 +30,6 @@ class FlutterOutlineNonFlutterProjectTest
     // Wait up to 1sec to ensure no error/log notifications were sent back.
     var didTimeout = false;
     var outlineNotification = waitForFlutterOutline(mainFileUri)
-        // ignore: unnecessary_cast
         .then((outline) => outline as FlutterOutline?)
         .timeout(
           const Duration(seconds: 1),

pkg/analysis_server/test/lsp/server_abstract.dart

@@ -1574,7 +1574,6 @@ mixin LspAnalysisServerTestMixin on LspRequestHelpersMixin, LspEditHelpersMixin
 
   // This is the signature expected for LSP.
   // https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#:~:text=Response%3A-,result%3A%20null,-error%3A%20code%20and
-  // ignore: prefer_void_to_null
   Future<Null> sendShutdown() {
     var request = makeRequest(Method.shutdown, null);
     return expectSuccessfulResponseTo(request, (result) => result as Null);

pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart

@@ -232,7 +232,6 @@ class _ThrowsAsyncErrorVisitor extends SimpleAstVisitor<void> {
   void visitBooleanLiteral(BooleanLiteral node) {
     // Raise an async error that can only be caught by an error zone's `onError`
     // handler.
-    // ignore: unawaited_futures
     Future<void>.error(StateError('A message.'));
   }
 }

pkg/analyzer/lib/src/generated/testing/test_type_provider.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: analyzer_use_new_elements
-
 import 'package:analyzer/source/source.dart';
 import 'package:analyzer/src/dart/analysis/session.dart';
 import 'package:analyzer/src/dart/element/class_hierarchy.dart';

pkg/analyzer/lib/src/summary2/kernel_compilation_service.dart

@@ -138,11 +138,9 @@ class KernelCompilationService {
       if (instance != null) {
         _currentInstance = null;
         // We don't expect any answer, the process will stop.
-        // ignore: unawaited_futures
         instance.requestChannel.sendRequest<void>('exit', {});
         instance.socket.destroy();
         // This socket is bound to a fresh port, we don't need it.
-        // ignore: unawaited_futures
         instance.serverSocket.close();
         instance.process.kill();
       }

pkg/analyzer/lib/src/summary2/macro.dart

@@ -133,7 +133,6 @@ class KernelBundleMacroExecutor extends BundleMacroExecutor {
 
   Uri get _kernelUri {
     return _kernelUriCached ??=
-        // ignore: avoid_dynamic_calls
         (Isolate.current as dynamic).createUriForKernelBlob(kernelBytes) as Uri;
   }
 
@@ -142,7 +141,6 @@ class KernelBundleMacroExecutor extends BundleMacroExecutor {
     support.executor.unregisterExecutorFactory(_executorFactoryToken);
     var kernelUriCached = _kernelUriCached;
     if (kernelUriCached != null) {
-      // ignore: avoid_dynamic_calls
       (Isolate.current as dynamic).unregisterKernelBlobUri(kernelUriCached);
       _kernelUriCached = null;
     }

pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: camel_case_types
-
 import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element2.dart';

pkg/linter/lib/src/analyzer.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: implementation_imports
-
 export 'package:analyzer/dart/element/type_system.dart';
 export 'package:analyzer/source/line_info.dart';
 export 'package:analyzer/src/dart/ast/token.dart';