[vm] Fix range checks in CheckOffsets.

Adjust the checks for runtime API ranges in CheckOffsets to account for
ranges where the first index is not 0-valued when cast to an intptr_t.

TEST=ci

Change-Id: I5478f6bf44b41f0ce7d4689e0ae37cd825838a40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444020
Reviewed-by: Alexander Markov <[email protected]>
Commit-Queue: Tess Strickland <[email protected]>
Commit-Queue: Alexander Markov <[email protected]>
Auto-Submit: Tess Strickland <[email protected]>

Author: sstrickl

runtime/vm/dart.cc

@@ -232,7 +232,7 @@ static void CheckOffsets() {
        i <= static_cast<intptr_t>(Last); i++) {                                \
     if (Filter(static_cast<Type>(i))) {                                        \
       CHECK_OFFSET(Class::Getter(static_cast<Type>(i)),                        \
-                   AOT_##Class##_##Getter[i]);                                 \
+                   AOT_##Class##_##Getter[i - static_cast<intptr_t>(First)]);  \
     }                                                                          \
   }
 #define CHECK_CONSTANT(Class, Name)                                            \
@@ -257,7 +257,8 @@ static void CheckOffsets() {
   for (intptr_t i = static_cast<intptr_t>(First);                              \
        i <= static_cast<intptr_t>(Last); i++) {                                \
     if (Filter(static_cast<Type>(i))) {                                        \
-      CHECK_OFFSET(Class::Getter(static_cast<Type>(i)), Class##_##Getter[i]);  \
+      CHECK_OFFSET(Class::Getter(static_cast<Type>(i)),                        \
+                   Class##_##Getter[i - static_cast<intptr_t>(First)]);        \
     }                                                                          \
   }
 #define CHECK_CONSTANT(Class, Name) CHECK_OFFSET(Class::Name, Class##_##Name);