[CFE] Fix presubmit compile-and-lint when all changed files are filtered away

jensjoha · Commit Queue · commit ca540d8620d0 · 2025-01-22T01:38:42.000-08:00
Change-Id: I1437755c7c2ef137a3fa37b3f0ec694ea8ab76dc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405340 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
diff --git a/pkg/front_end/test/compile_and_lint_impl.dart b/pkg/front_end/test/compile_and_lint_impl.dart
@@ -82,6 +82,14 @@ Future<int> runCompileAndLintTest(
     }
   }
 
+  // If we filtered everything away (e.g. only changed files in an ignored
+  // directory) we shouldn't try to run.
+  // It will fail and also doesn't make sense.
+  if (includedFilesFiltered.isEmpty) {
+    // 0 = no errors found.
+    return 0;
+  }
+
   Stopwatch stopwatch = new Stopwatch()..start();
 
   // TODO(jensj): The target has to be VM or we can't compile the sdk,

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,14 @@ Future<int> runCompileAndLintTest(`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`
	`85`	`+ // If we filtered everything away (e.g. only changed files in an ignored`
	`86`	`+ // directory) we shouldn't try to run.`
	`87`	`+ // It will fail and also doesn't make sense.`
	`88`	`+ if (includedFilesFiltered.isEmpty) {`
	`89`	`+ // 0 = no errors found.`
	`90`	`+ return 0;`
	`91`	`+ }`
	`92`	`+`
`85`	`93`	`Stopwatch stopwatch = new Stopwatch()..start();`
`86`	`94`
`87`	`95`	`// TODO(jensj): The target has to be VM or we can't compile the sdk,`