[analyzer] Fix "yield in non-generator" error reporting.

The analyzer unit tests `YieldEachInNonGeneratorTest.test_async` and
`YieldInNonGeneratorTest.test_async` were marked with a `@FailingTest`
annotation that claimed that the tests were failing because the parser
was trying to parse the yield statement as a binary expression. The
actual reason they were failing was because (a) both the analyzer and
the shared parser were redundantly flagging the error, resulting in
two errors rather than one, and (b) the tests had an incorrect offset
and length for the expected error.

As a result of these tests being marked with a `@FailingTest`
annotation, we had no test coverage of the
`YIELD_EACH_IN_NON_GENERATOR` and `YIELD_IN_NON_GENERATOR` errors.

I've resolved the redundancy by suppressing the error from the parser
and keeping the analyzer's logic to flag the error, since the
analyzer's logic produces a more specific error (it correctly
distinguishes between `YIELD_EACH_IN_NON_GENERATOR` and
`YIELD_IN_NON_GENERATOR`, whereas the shared parser does not). And
I've updated the tests with the correct offset and length for the
expected error. So the tests no longer fail and test coverage is
restored.

Change-Id: Ibbee3329d4699d7e78bec964303e9c9b239f0b8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400140
Auto-Submit: Paul Berry <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: stereotype441

pkg/analyzer/lib/src/fasta/error_converter.dart

@@ -504,11 +504,7 @@ class FastaErrorReporter {
         );
         return;
       case "YIELD_IN_NON_GENERATOR":
-        errorReporter?.atOffset(
-          offset: offset,
-          length: length,
-          errorCode: CompileTimeErrorCode.YIELD_IN_NON_GENERATOR,
-        );
+        // Reported by [YieldStatementResolver._resolve_notGenerator]
         return;
       case "BUILT_IN_IDENTIFIER_IN_DECLARATION":
         // Reported by [ErrorVerifier._checkForBuiltInIdentifierAsName].

pkg/analyzer/test/src/diagnostics/yield_each_in_non_generator_test.dart

@@ -15,16 +15,13 @@ main() {
 
 @reflectiveTest
 class YieldEachInNonGeneratorTest extends PubPackageResolutionTest {
-  @FailingTest(
-      reason: 'We are currently trying to parse the yield statement as a '
-          'binary expression.')
   test_async() async {
     await assertErrorsInCode(r'''
 f() async {
   yield* 0;
 }
 ''', [
-      error(CompileTimeErrorCode.YIELD_EACH_IN_NON_GENERATOR, 0, 0),
+      error(CompileTimeErrorCode.YIELD_EACH_IN_NON_GENERATOR, 14, 9),
     ]);
   }
 

pkg/analyzer/test/src/diagnostics/yield_in_non_generator_test.dart

@@ -15,16 +15,13 @@ main() {
 
 @reflectiveTest
 class YieldInNonGeneratorTest extends PubPackageResolutionTest {
-  @FailingTest(
-      reason: 'We are currently trying to parse the yield statement as a '
-          'binary expression.')
   test_async() async {
     await assertErrorsInCode(r'''
 f() async {
   yield 0;
 }
 ''', [
-      error(CompileTimeErrorCode.YIELD_IN_NON_GENERATOR, 0, 0),
+      error(CompileTimeErrorCode.YIELD_IN_NON_GENERATOR, 14, 8),
     ]);
   }