linter: Use RuleContext over the deprecated alias, LinterContext

Change-Id: I3df38b96a0cb7756a9dbfbffc80d50c4c73337ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432723
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server_plugin/test/src/lint_rules.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
@@ -18,7 +19,7 @@ class NoBoolsRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      RuleVisitorRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, RuleContext context) {
     var visitor = _NoBoolsVisitor(this);
     registry.addBooleanLiteral(this, visitor);
   }
@@ -35,7 +36,7 @@ class NoDoublesRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      RuleVisitorRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, RuleContext context) {
     var visitor = _NoDoublesVisitor(this);
     registry.addDoubleLiteral(this, visitor);
   }
@@ -55,8 +56,7 @@ class NoDoublesWarningRule extends AnalysisRule {
   DiagnosticCode get diagnosticCode => code;
 
   @override
-  void registerNodeProcessors(
-      NodeLintRegistry registry, LinterContext context) {
+  void registerNodeProcessors(NodeLintRegistry registry, RuleContext context) {
     var visitor = _NoDoublesVisitor(this);
     registry.addDoubleLiteral(this, visitor);
   }

pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart

@@ -8,6 +8,7 @@ import 'package:analysis_server_plugin/edit/dart/correction_producer.dart';
 import 'package:analysis_server_plugin/plugin.dart';
 import 'package:analysis_server_plugin/registry.dart';
 import 'package:analysis_server_plugin/src/plugin_server.dart';
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
@@ -270,7 +271,7 @@ class _ThrowsAsyncErrorRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      RuleVisitorRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, RuleContext context) {
     var visitor = _ThrowsAsyncErrorVisitor(this);
     registry.addBooleanLiteral(this, visitor);
   }
@@ -317,7 +318,7 @@ class _ThrowsSyncErrorRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      RuleVisitorRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, RuleContext context) {
     var visitor = _ThrowsSyncErrorVisitor(this);
     registry.addBooleanLiteral(this, visitor);
   }

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -4,6 +4,7 @@
 
 import 'dart:async';
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
 import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
@@ -46947,7 +46948,7 @@ class _AlwaysReportedLint extends LintRule {
   @override
   void registerNodeProcessors(
     RuleVisitorRegistry registry,
-    LinterContext context,
+    RuleContext context,
   ) {
     var visitor = _AlwaysReportedLintVisitor(this);
     registry.addCompilationUnit(this, visitor);

pkg/analyzer/test/src/diagnostics/unignorable_ignore_test.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
@@ -102,7 +103,7 @@ class _AvoidIntRule extends LintRule {
   @override
   void registerNodeProcessors(
     RuleVisitorRegistry registry,
-    LinterContext context,
+    RuleContext context,
   ) {
     var visitor = _AvoidIntVisitor(this);
     registry.addNamedType(this, visitor);

pkg/linter/lib/src/ast.dart

@@ -5,6 +5,7 @@
 /// Common AST helpers.
 library;
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/ast/token.dart';
@@ -16,8 +17,6 @@ import 'package:analyzer/src/lint/constants.dart' // ignore: implementation_impo
 import 'package:analyzer/workspace/workspace.dart';
 import 'package:path/path.dart' as path;
 
-import 'analyzer.dart';
-
 final Set<String> _reservedWords = {
   for (var entry in Keyword.keywords.entries)
     if (entry.value.isReservedWord) entry.key,
@@ -54,7 +53,7 @@ Token? getFieldName(FieldDeclaration decl, String name) {
 /// minus and then an [IntegerLiteral]. If a [context] is provided,
 /// [SimpleIdentifier]s are evaluated as constants. For anything else,
 /// returns `null`.
-int? getIntValue(Expression expression, LinterContext? context) {
+int? getIntValue(Expression expression, RuleContext? context) {
   if (expression is PrefixExpression) {
     var operand = expression.operand;
     if (expression.operator.type != TokenType.MINUS) return null;
@@ -311,7 +310,7 @@ bool _checkForSimpleSetter(MethodDeclaration setter, Expression expression) {
 
 int? _getIntValue(
   Expression expression,
-  LinterContext? context, {
+  RuleContext? context, {
   bool negated = false,
 }) {
   int? value;

pkg/linter/lib/src/rules/always_declare_return_types.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
@@ -23,10 +24,7 @@ class AlwaysDeclareReturnTypes extends MultiAnalysisRule {
   ];
 
   @override
-  void registerNodeProcessors(
-    NodeLintRegistry registry,
-    LinterContext context,
-  ) {
+  void registerNodeProcessors(NodeLintRegistry registry, RuleContext context) {
     var visitor = _Visitor(this, context);
     registry.addFunctionDeclaration(this, visitor);
     registry.addFunctionTypeAlias(this, visitor);
@@ -36,7 +34,7 @@ class AlwaysDeclareReturnTypes extends MultiAnalysisRule {
 
 class _Visitor extends SimpleAstVisitor<void> {
   final MultiAnalysisRule rule;
-  final LinterContext context;
+  final RuleContext context;
 
   _Visitor(this.rule, this.context);
 

pkg/linter/lib/src/rules/always_put_control_body_on_new_line.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
@@ -22,10 +23,7 @@ class AlwaysPutControlBodyOnNewLine extends LintRule {
       LinterLintCode.always_put_control_body_on_new_line;
 
   @override
-  void registerNodeProcessors(
-    NodeLintRegistry registry,
-    LinterContext context,
-  ) {
+  void registerNodeProcessors(NodeLintRegistry registry, RuleContext context) {
     var visitor = _Visitor(this);
     registry.addDoStatement(this, visitor);
     registry.addForStatement(this, visitor);

pkg/linter/lib/src/rules/always_put_required_named_parameters_first.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
@@ -22,10 +23,7 @@ class AlwaysPutRequiredNamedParametersFirst extends LintRule {
       LinterLintCode.always_put_required_named_parameters_first;
 
   @override
-  void registerNodeProcessors(
-    NodeLintRegistry registry,
-    LinterContext context,
-  ) {
+  void registerNodeProcessors(NodeLintRegistry registry, RuleContext context) {
     var visitor = _Visitor(this);
     registry.addFormalParameterList(this, visitor);
   }

pkg/linter/lib/src/rules/always_specify_types.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
@@ -35,10 +36,7 @@ class AlwaysSpecifyTypes extends MultiAnalysisRule {
   ];
 
   @override
-  void registerNodeProcessors(
-    NodeLintRegistry registry,
-    LinterContext context,
-  ) {
+  void registerNodeProcessors(NodeLintRegistry registry, RuleContext context) {
     var visitor = _Visitor(this);
     registry.addDeclaredIdentifier(this, visitor);
     registry.addListLiteral(this, visitor);

pkg/linter/lib/src/rules/always_use_package_imports.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
@@ -24,10 +25,7 @@ class AlwaysUsePackageImports extends LintRule {
   ];
 
   @override
-  void registerNodeProcessors(
-    NodeLintRegistry registry,
-    LinterContext context,
-  ) {
+  void registerNodeProcessors(NodeLintRegistry registry, RuleContext context) {
     // Relative paths from outside of the lib folder are handled by the
     // `avoid_relative_lib_imports` lint rule.
     if (!context.isInLibDir) return;