Skip to content

Commit cb93352

Browse files
aamCommit Queue
authored andcommitted
[vm] Cleanup todo - assert isolate_group is available when compiling.
If there is current thread, assert there is isolate_group too. TEST=ci Change-Id: Id4bce1091084b707b6b671038ec3377ded6791c6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402427 Reviewed-by: Siva Annamalai <[email protected]> Commit-Queue: Alexander Aprelev <[email protected]>
1 parent 673ee1f commit cb93352

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

runtime/vm/kernel_isolate.cc

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -836,15 +836,10 @@ class KernelCompilationRequest : public ValueObject {
836836
dart_embed_sources.type = Dart_CObject_kBool;
837837
dart_embed_sources.value.as_bool = embed_sources;
838838

839-
// TODO(aam): Assert that isolate exists once we move CompileAndReadScript
840-
// compilation logic out of CreateIsolateAndSetupHelper and into
841-
// IsolateSetupHelper in main.cc.
842839
auto thread = Thread::Current();
843840
auto isolate_group = thread != nullptr ? thread->isolate_group() : nullptr;
841+
ASSERT((thread == nullptr) || (isolate_group != nullptr));
844842

845-
if (incremental_compile) {
846-
ASSERT(isolate_group != nullptr);
847-
}
848843
Dart_CObject isolate_id;
849844
isolate_id.type = Dart_CObject_kInt64;
850845
isolate_id.value.as_int64 = isolate_group != nullptr

0 commit comments

Comments
 (0)