[analytics] stop collecting context creation style data

Bug: #60411
Change-Id: I987557393cfc1b92b5d00467f5aedc9674eba07c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417946
Reviewed-by: Brian Wilkerson <[email protected]>

Author: pq

pkg/analysis_server/lib/src/analysis_server.dart

@@ -943,27 +943,9 @@ abstract class AnalysisServer {
 
     var rootPaths = packagesFileMap.keys.toList();
     rootPaths.sort((first, second) => first.length.compareTo(second.length));
-    var styleCounts = [
-      0, // neither
-      0, // only packages
-      0, // only options -- (No longer incremented. Options files do not imply unique contexts.)
-      0, // both -- (No longer incremented. Options files do not imply unique contexts.)
-    ];
-    var packagesFiles = <File>{};
-    for (var rootPath in rootPaths) {
-      var packagesFile = packagesFileMap[rootPath];
-      var hasUniquePackageFile =
-          packagesFile != null && packagesFiles.add(packagesFile);
-      var style = hasUniquePackageFile ? 1 : 0;
-      styleCounts[style]++;
-    }
 
     analyticsManager.analysisComplete(
       numberOfContexts: driverMap.length,
-      contextsWithoutFiles: styleCounts[0],
-      contextsFromPackagesFiles: styleCounts[1],
-      contextsFromOptionsFiles: styleCounts[2],
-      contextsFromBothFiles: styleCounts[3],
       immediateFileCount: immediateFileCount,
       immediateFileLineCount: immediateFileLineCount,
       transitiveFileCount: transitiveFileCount,

pkg/analysis_server/lib/src/analytics/analytics_manager.dart

@@ -102,10 +102,6 @@ class AnalyticsManager {
   /// number of unique transitive files.
   void analysisComplete({
     required int numberOfContexts,
-    required int contextsWithoutFiles,
-    required int contextsFromPackagesFiles,
-    required int contextsFromOptionsFiles,
-    required int contextsFromBothFiles,
     required int immediateFileCount,
     required int immediateFileLineCount,
     required int transitiveFileCount,
@@ -118,10 +114,6 @@ class AnalyticsManager {
     // analysis or keeping all of the data and sending back percentile.
     _contextStructure ??= ContextStructure(
       numberOfContexts: numberOfContexts,
-      contextsWithoutFiles: contextsWithoutFiles,
-      contextsFromPackagesFiles: contextsFromPackagesFiles,
-      contextsFromOptionsFiles: contextsFromOptionsFiles,
-      contextsFromBothFiles: contextsFromBothFiles,
       immediateFileCount: immediateFileCount,
       immediateFileLineCount: immediateFileLineCount,
       transitiveFileCount: transitiveFileCount,
@@ -451,18 +443,6 @@ class AnalyticsManager {
       h3('Analysis data');
       buffer.writeln('<ul>');
       li('numberOfContexts: ${json.encode(analysisData.numberOfContexts)}');
-      li(
-        'contextsWithoutFiles: ${json.encode(analysisData.contextsWithoutFiles)}',
-      );
-      li(
-        'contextsFromPackagesFiles: ${json.encode(analysisData.contextsFromPackagesFiles)}',
-      );
-      li(
-        'contextsFromOptionsFiles: ${json.encode(analysisData.contextsFromOptionsFiles)}',
-      );
-      li(
-        'contextsFromBothFiles: ${json.encode(analysisData.contextsFromBothFiles)}',
-      );
       li('immediateFileCount: ${json.encode(analysisData.immediateFileCount)}');
       li(
         'immediateFileLineCount: ${json.encode(analysisData.immediateFileLineCount)}',
@@ -516,10 +496,11 @@ class AnalyticsManager {
       analytics.send(
         Event.contextStructure(
           numberOfContexts: contextStructure.numberOfContexts,
-          contextsWithoutFiles: contextStructure.contextsWithoutFiles,
-          contextsFromPackagesFiles: contextStructure.contextsFromPackagesFiles,
-          contextsFromOptionsFiles: contextStructure.contextsFromOptionsFiles,
-          contextsFromBothFiles: contextStructure.contextsFromBothFiles,
+          // TODO(pq): remove context creation data if we can safely change report shape (https://github.com/dart-lang/sdk/issues/60411)
+          contextsWithoutFiles: 0,
+          contextsFromPackagesFiles: 0,
+          contextsFromOptionsFiles: 0,
+          contextsFromBothFiles: 0,
           immediateFileCount: contextStructure.immediateFileCount,
           immediateFileLineCount: contextStructure.immediateFileLineCount,
           transitiveFileCount: contextStructure.transitiveFileCount,

pkg/analysis_server/lib/src/analytics/context_structure.dart

@@ -23,22 +23,6 @@ class ContextStructure {
   /// The number of analysis contexts being analyzed.
   final int numberOfContexts;
 
-  /// The number of contexts that were created that have neither a packages nor
-  /// an options file.
-  final int contextsWithoutFiles;
-
-  /// The number of contexts that were created that have a unique packages file
-  /// and either no options file or an inherited options file.
-  final int contextsFromPackagesFiles;
-
-  /// The number of contexts that were created that have a unique options file
-  /// and either no packages file or an inherited packages file.
-  final int contextsFromOptionsFiles;
-
-  /// The number of contexts that were created that have both a unique packages
-  /// file and a unique options file.
-  final int contextsFromBothFiles;
-
   /// The number of immediate files that were analyzed.
   final int immediateFileCount;
 
@@ -64,10 +48,6 @@ class ContextStructure {
   /// Initialize a newly created data holder.
   ContextStructure({
     required this.numberOfContexts,
-    required this.contextsWithoutFiles,
-    required this.contextsFromPackagesFiles,
-    required this.contextsFromOptionsFiles,
-    required this.contextsFromBothFiles,
     required this.immediateFileCount,
     required this.immediateFileLineCount,
     required this.transitiveFileCount,