Elements. Set types of synthetic getter / setter when set type of PropertyInducingElementImpl.

And, for consistency with local variables, set type by default of
FormalParameterElementImpl to InvalidTypeImpl.instance.

Change-Id: I9d1ad603ad29b3d019c47914888136a2530274c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442173
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -3097,7 +3097,7 @@ class FormalParameterElementImpl extends PromotableElementImpl
   final FormalParameterFragmentImpl wrappedElement;
 
   @override
-  late TypeImpl type;
+  TypeImpl type = InvalidTypeImpl.instance;
 
   /// Whether this formal parameter inherits from a covariant formal parameter.
   /// This happens when it overrides a method in a supertype that has a
@@ -8749,32 +8749,35 @@ abstract class PropertyInducingElementImpl extends VariableElementImpl
   @override
   TypeImpl get type {
     _ensureReadResolution();
-    if (_type != null) return _type!;
+    if (_type case var type?) {
+      return type;
+    }
 
     // We must be linking, and the type has not been set yet.
     var type = firstFragment.typeInference?.perform();
     type ??= InvalidTypeImpl.instance;
-    _type = type;
+    this.type = type;
     shouldUseTypeForInitializerInference = false;
 
-    // TODO(scheglov): We repeat this code.
-    var element = this;
-    if (element.getter case var getterElement?) {
-      getterElement.returnType = type;
-    }
-    if (element.setter case var setterElement?) {
-      if (setterElement.isSynthetic) {
-        setterElement.returnType = VoidTypeImpl.instance;
-        setterElement.valueFormalParameter.type = type;
-      }
-    }
-
-    return _type!;
+    return type;
   }
 
   @override
   set type(TypeImpl value) {
     _type = value;
+
+    if (getter case var getter?) {
+      if (getter.isSynthetic) {
+        getter.returnType = type;
+      }
+    }
+
+    if (setter case var setter?) {
+      if (setter.isSynthetic) {
+        setter.returnType = VoidTypeImpl.instance;
+        setter.valueFormalParameter.type = type;
+      }
+    }
   }
 
   List<PropertyInducingFragmentImpl> get _fragments;

pkg/analyzer/lib/src/summary2/extension_type.dart

@@ -155,10 +155,7 @@ class _Node extends graph.Node<_Node> {
 
     var representationFragment = element.firstFragment.representation;
     var representationElement = representationFragment.element;
-
     representationElement.type = type;
-    // TODO(scheglov): we repeat similar code in many places
-    representationElement.getter!.returnType = type;
 
     element.firstFragment.typeErasure = type.extensionTypeErasure;
     element.firstFragment.interfaces =

pkg/analyzer/lib/src/summary2/instance_member_inferrer.dart

@@ -266,8 +266,7 @@ class InstanceMemberInferrer {
       // to be the return type of the combined member signature of said getter
       // in the direct superinterfaces.
       if (overriddenGetters.isNotEmpty && overriddenSetters.isEmpty) {
-        var type = combinedGetterType();
-        _setFieldType(field, type);
+        field.type = combinedGetterType();
         return;
       }
 
@@ -276,8 +275,7 @@ class InstanceMemberInferrer {
       // to be the parameter type of the combined member signature of said
       // setter in the direct superinterfaces.
       if (overriddenGetters.isEmpty && overriddenSetters.isNotEmpty) {
-        var type = combinedSetterType();
-        _setFieldType(field, type);
+        field.type = combinedSetterType();
         return;
       }
 
@@ -286,8 +284,7 @@ class InstanceMemberInferrer {
         // and a getter is inferred to be the return type of the combined
         // member signature of said getter in the direct superinterfaces.
         if (field.isFinal) {
-          var type = combinedGetterType();
-          _setFieldType(field, type);
+          field.type = combinedGetterType();
           return;
         }
 
@@ -302,7 +299,7 @@ class InstanceMemberInferrer {
           var setterType = combinedSetterType();
 
           if (getterType == setterType) {
-            _setFieldType(field, getterType);
+            field.type = getterType;
           }
           return;
         }
@@ -756,15 +753,6 @@ class InstanceMemberInferrer {
     }
     return false;
   }
-
-  static void _setFieldType(FieldElementImpl field, TypeImpl type) {
-    field.type = type;
-    field.getter?.returnType = type;
-    if (field.setter case var setter?) {
-      setter.returnType = VoidTypeImpl.instance;
-      setter.valueFormalParameter.type = type;
-    }
-  }
 }
 
 /// A class of exception that is not used anywhere else.

pkg/analyzer/lib/src/summary2/library_builder.dart

@@ -223,8 +223,6 @@ class LibraryBuilder {
       );
       enum_.valuesTypeNode.type = valuesType;
       enum_.valuesElement.element.type = valuesType;
-      // TODO(scheglov): We repeat this code.
-      enum_.valuesElement.element.getter!.returnType = valuesType;
     }
   }
 

pkg/analyzer/lib/src/summary2/types_builder.dart

@@ -255,15 +255,6 @@ class TypesBuilder {
           var variableFragment = variable.declaredFragment!;
           var variableElement = variableFragment.element;
           variableElement.type = type;
-          if (variableElement is PropertyInducingElementImpl) {
-            if (variableElement.getter case var getterElement?) {
-              getterElement.returnType = type;
-            }
-            if (variableElement.setter case var setterElement?) {
-              setterElement.returnType = VoidTypeImpl.instance;
-              setterElement.valueFormalParameter.type = type;
-            }
-          }
         }
       }
     } else {