[DAS] Fixes Add required parameter quick-fix

Bug: #53707
Change-Id: I461b2a74ae4d8a9b1794b1e47574783f31d29a67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422440
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/correction/dart/add_super_parameter.dart

@@ -74,9 +74,10 @@ class AddSuperParameter extends ResolvedCorrectionProducer {
             i >= superPositionalParameters.length ||
             parameter.name.lexeme != superPositionalParameters[i].name3) {
           arePositionalOrdered = false;
-          break;
         }
         lastPositionalParameter = parameter;
+      } else {
+        break;
       }
     }
 
@@ -102,13 +103,11 @@ class AddSuperParameter extends ResolvedCorrectionProducer {
             needsInitialComma: false,
           );
 
-          if (missingNamedParameters.isNotEmpty) {
-            _writeNamed(
-              builder,
-              missingNamedParameters,
-              needsInitialComma: missingPositionalParameters.isNotEmpty,
-            );
-          }
+          _writeNamed(
+            builder,
+            missingNamedParameters,
+            needsInitialComma: missingPositionalParameters.isNotEmpty,
+          );
         });
       });
     } else {
@@ -171,6 +170,7 @@ class AddSuperParameter extends ResolvedCorrectionProducer {
     FormalParameter? lastNamedParameter,
     required bool needsInitialComma,
   }) {
+    if (parameters.isEmpty) return;
     var firstParameter = true;
     void writeComma() {
       if (firstParameter) {
@@ -214,6 +214,7 @@ class AddSuperParameter extends ResolvedCorrectionProducer {
     List<FormalParameterElement> parameters, {
     required bool needsInitialComma,
   }) {
+    if (parameters.isEmpty) return;
     var firstParameter = true;
     void writeComma() {
       if (firstParameter && !needsInitialComma) {

pkg/analysis_server/test/src/services/correction/fix/add_super_parameter_test.dart

@@ -42,6 +42,29 @@ class B extends A {
 
   Future<void> test_named_first_existingPositional() async {
     await resolveTestCode('''
+class A {
+  A({required int a, required int b});
+}
+class B extends A {
+  B(this.i);
+
+  final int i;
+}
+''');
+    await assertHasFix('''
+class A {
+  A({required int a, required int b});
+}
+class B extends A {
+  B(this.i, {required super.a, required super.b});
+
+  final int i;
+}
+''');
+  }
+
+  Future<void> test_named_first_existingPositional2() async {
+    await resolveTestCode('''
 class A {
   A(int i, {required int a, required int b});
 }