[analyzer_cli] Remove unused CommandLineOptions.

Removes the field `AnalyzerImpl.options`, the `options` parameter of
the method `Driver._runAnalyzer`, and the `commandLineOptions`
parameters of the functions `computeSeverity` and
`determineProcessedSeverity`. None of these were used.

Change-Id: I6a6a6964617cecb81f0d1c6570be1d78fb599af4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/463085
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/analyzer_cli/lib/src/analyzer_impl.dart

@@ -15,14 +15,12 @@ import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer_cli/src/driver.dart';
 import 'package:analyzer_cli/src/error_formatter.dart';
 import 'package:analyzer_cli/src/error_severity.dart';
-import 'package:analyzer_cli/src/options.dart';
 import 'package:path/path.dart' as path;
 
 int get currentTimeMillis => DateTime.now().millisecondsSinceEpoch;
 
 /// Analyzes single library [File].
 class AnalyzerImpl {
-  final CommandLineOptions options;
   final int startTime;
 
   final AnalysisOptions analysisOptions;
@@ -53,7 +51,6 @@ class AnalyzerImpl {
     this.analysisOptions,
     this.analysisDriver,
     this.libraryFile,
-    this.options,
     this.stats,
     this.startTime,
     this.gotErrorsFor,
@@ -126,9 +123,7 @@ class AnalyzerImpl {
         if (_defaultSeverityProcessor(diagnostic) == null) {
           continue;
         }
-        status = status.max(
-          computeSeverity(diagnostic, options, analysisOptions)!,
-        );
+        status = status.max(computeSeverity(diagnostic, analysisOptions)!);
       }
     }
     return status;
@@ -191,7 +186,7 @@ class AnalyzerImpl {
   }
 
   DiagnosticSeverity? _defaultSeverityProcessor(Diagnostic diagnostic) =>
-      determineProcessedSeverity(diagnostic, options, analysisOptions);
+      determineProcessedSeverity(diagnostic, analysisOptions);
 
   /// Returns true if we want to report diagnostics for this library.
   bool _isAnalyzedLibrary(LibraryElement library) {

pkg/analyzer_cli/lib/src/driver.dart

@@ -184,7 +184,6 @@ class Driver implements CommandLineStarter {
       var file = analysisDriver!.resourceProvider.getFile(filePath);
       return determineProcessedSeverity(
         diagnostic,
-        options,
         analysisDriver!.getAnalysisOptionsForFile(file),
       );
     };
@@ -299,11 +298,7 @@ class Driver implements CommandLineStarter {
             ),
           ]);
           for (var error in errors) {
-            var severity = determineProcessedSeverity(
-              error,
-              options,
-              analysisOptions,
-            );
+            var severity = determineProcessedSeverity(error, analysisOptions);
             if (severity != null) {
               allResult = allResult.max(severity);
             }
@@ -331,7 +326,6 @@ class Driver implements CommandLineStarter {
               for (var error in diagnostics) {
                 var severity = determineProcessedSeverity(
                   error,
-                  options,
                   analysisOptions,
                 )!;
                 allResult = allResult.max(severity);
@@ -384,7 +378,6 @@ class Driver implements CommandLineStarter {
             for (var error in errors) {
               var severity = determineProcessedSeverity(
                 error,
-                options,
                 analysisOptions,
               )!;
               allResult = allResult.max(severity);
@@ -398,12 +391,7 @@ class Driver implements CommandLineStarter {
 
           final kind = file.kind;
           if (kind is LibraryFileKind) {
-            var status = await _runAnalyzer(
-              file,
-              options,
-              formatter,
-              gotErrorsFor,
-            );
+            var status = await _runAnalyzer(file, formatter, gotErrorsFor);
             allResult = allResult.max(status);
             analyzedFiles.addAll(kind.files);
           } else if (kind is PartFileKind) {
@@ -472,7 +460,6 @@ class Driver implements CommandLineStarter {
   /// Analyze a single source.
   Future<DiagnosticSeverity> _runAnalyzer(
     FileState file,
-    CommandLineOptions options,
     ErrorFormatter formatter,
     Set<String> gotErrorsFor,
   ) {
@@ -485,7 +472,6 @@ class Driver implements CommandLineStarter {
       analysisOptions,
       analysisDriver,
       file,
-      options,
       stats,
       startTime,
       gotErrorsFor,

pkg/analyzer_cli/lib/src/error_severity.dart

@@ -6,15 +6,13 @@ import 'package:analyzer/diagnostic/diagnostic.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/source/error_processor.dart';
 import 'package:analyzer/src/generated/engine.dart';
-import 'package:analyzer_cli/src/options.dart';
 
 /// Compute the severity of the error; however:
 /// - if `options.enableTypeChecks` is false, then de-escalate checked-mode
 ///   compile time errors to a severity of [DiagnosticSeverity.INFO].
 /// - if `options.lintsAreFatal` is true, escalate lints to errors.
 DiagnosticSeverity? computeSeverity(
   Diagnostic diagnostic,
-  CommandLineOptions commandLineOptions,
   AnalysisOptions analysisOptions,
 ) {
   var processor = ErrorProcessor.getProcessor(analysisOptions, diagnostic);
@@ -30,14 +28,9 @@ DiagnosticSeverity? computeSeverity(
 /// [diagnostic] (or `null` if it's to be suppressed).
 DiagnosticSeverity? determineProcessedSeverity(
   Diagnostic diagnostic,
-  CommandLineOptions commandLineOptions,
   AnalysisOptions analysisOptions,
 ) {
-  var severity = computeSeverity(
-    diagnostic,
-    commandLineOptions,
-    analysisOptions,
-  );
+  var severity = computeSeverity(diagnostic, analysisOptions);
   // Skip TODOs categorically unless escalated to ERROR or HINT (#26215).
   if (diagnostic.diagnosticCode.type == DiagnosticType.TODO &&
       severity == DiagnosticSeverity.INFO) {