Elements. Fix for reference of unnamed constructor of extension type.

Change-Id: Id01fd9bdaad84e31622e220d0ecc9b3b73f48287
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434941
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -110,7 +110,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 472;
+  static const int DATA_VERSION = 475;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/summary2/element_builder.dart

@@ -1913,7 +1913,7 @@ class ElementBuilder extends ThrowingAstVisitor<void> {
       var containerElement = containerBuilder.element;
       var containerRef = containerElement.reference!.getChild('@constructor');
       var elementReference = containerRef.addChild(
-        extensionFragment.name2 ?? 'new',
+        constructorFragment.name2,
       );
 
       ConstructorElementImpl2(

pkg/analyzer/test/src/dart/ast/element_locator_test.dart

@@ -565,7 +565,7 @@ dart:core::@class::num::@method::+
     var node = findNode.singleRepresentationConstructorName;
     var element = ElementLocator.locate2(node);
     _assertElement(element, r'''
-<testLibrary>::@extensionType::A::@constructor::A
+<testLibrary>::@extensionType::A::@constructor::named
 ''');
   }
 

pkg/analyzer/test/src/dart/resolution/instance_creation_test.dart

@@ -1042,7 +1042,7 @@ InstanceCreationExpression
       element2: <testLibrary>::@extensionType::A
       type: A<int>
     element: ConstructorMember
-      baseElement: <testLibrary>::@extensionType::A::@constructor::A
+      baseElement: <testLibrary>::@extensionType::A::@constructor::new
       substitution: {T: int}
   argumentList: ArgumentList
     leftParenthesis: (
@@ -1114,9 +1114,9 @@ InstanceCreationExpression
     period: .
     name: SimpleIdentifier
       token: named
-      element: <testLibrary>::@extensionType::A::@constructor::A
+      element: <testLibrary>::@extensionType::A::@constructor::named
       staticType: null
-    element: <testLibrary>::@extensionType::A::@constructor::A
+    element: <testLibrary>::@extensionType::A::@constructor::named
   argumentList: ArgumentList
     leftParenthesis: (
     arguments
@@ -1146,7 +1146,7 @@ InstanceCreationExpression
       name: A
       element2: <testLibrary>::@extensionType::A
       type: A
-    element: <testLibrary>::@extensionType::A::@constructor::A
+    element: <testLibrary>::@extensionType::A::@constructor::new
   argumentList: ArgumentList
     leftParenthesis: (
     arguments

pkg/analyzer/test/src/dart/resolution/metadata_test.dart

@@ -642,9 +642,9 @@ Annotation
     period: .
     identifier: SimpleIdentifier
       token: named
-      element: <testLibrary>::@extensionType::A::@constructor::A
+      element: <testLibrary>::@extensionType::A::@constructor::named
       staticType: null
-    element: <testLibrary>::@extensionType::A::@constructor::A
+    element: <testLibrary>::@extensionType::A::@constructor::named
     staticType: null
   arguments: ArgumentList
     leftParenthesis: (
@@ -654,7 +654,7 @@ Annotation
         correspondingParameter: <testLibraryFragment>::@extensionType::A::@constructor::named::@parameter::it#element
         staticType: int
     rightParenthesis: )
-  element2: <testLibrary>::@extensionType::A::@constructor::A
+  element2: <testLibrary>::@extensionType::A::@constructor::named
 ''');
 
     _assertAnnotationValueText(node, r'''
@@ -686,7 +686,7 @@ Annotation
         correspondingParameter: <testLibraryFragment>::@extensionType::A::@constructor::new::@parameter::it#element
         staticType: int
     rightParenthesis: )
-  element2: <testLibrary>::@extensionType::A::@constructor::A
+  element2: <testLibrary>::@extensionType::A::@constructor::new
 ''');
 
     _assertAnnotationValueText(node, r'''

pkg/analyzer/test/src/summary/elements/class_test.dart

@@ -11692,7 +11692,7 @@ library
       reference: <testLibrary>::@extensionType::B
       firstFragment: <testLibraryFragment>::@extensionType::B
       representation: <testLibrary>::@extensionType::B::@field::it
-      primaryConstructor: <testLibrary>::@extensionType::B::@constructor::B
+      primaryConstructor: <testLibrary>::@extensionType::B::@constructor::new
       typeErasure: int
       fields
         final it
@@ -13321,7 +13321,7 @@ library
       reference: <testLibrary>::@extensionType::B
       firstFragment: <testLibraryFragment>::@extensionType::B
       representation: <testLibrary>::@extensionType::B::@field::it
-      primaryConstructor: <testLibrary>::@extensionType::B::@constructor::B
+      primaryConstructor: <testLibrary>::@extensionType::B::@constructor::new
       typeErasure: int
       fields
         final it
@@ -16668,7 +16668,7 @@ library
       reference: <testLibrary>::@extensionType::A
       firstFragment: <testLibraryFragment>::@extensionType::A
       representation: <testLibrary>::@extensionType::A::@field::it
-      primaryConstructor: <testLibrary>::@extensionType::A::@constructor::A
+      primaryConstructor: <testLibrary>::@extensionType::A::@constructor::new
       typeErasure: int
       fields
         final it

pkg/analyzer/test/src/summary/elements/duplicate_declaration_test.dart

@@ -920,7 +920,7 @@ library
           constructors
             new
               reference: <testLibraryFragment>::@extensionType::E::@def::0::@constructor::new
-              element: <testLibrary>::@extensionType::E::@def::0::@constructor::E
+              element: <testLibrary>::@extensionType::E::@def::0::@constructor::new
               typeName: E
               typeNameOffset: 15
               formalParameters
@@ -941,7 +941,7 @@ library
           constructors
             new
               reference: <testLibraryFragment>::@extensionType::E::@def::1::@constructor::new
-              element: <testLibrary>::@extensionType::E::@def::1::@constructor::E
+              element: <testLibrary>::@extensionType::E::@def::1::@constructor::new
               typeName: E
               typeNameOffset: 43
               formalParameters
@@ -956,7 +956,7 @@ library
       reference: <testLibrary>::@extensionType::E::@def::0
       firstFragment: <testLibraryFragment>::@extensionType::E::@def::0
       representation: <testLibrary>::@extensionType::E::@def::0::@field::it
-      primaryConstructor: <testLibrary>::@extensionType::E::@def::0::@constructor::E
+      primaryConstructor: <testLibrary>::@extensionType::E::@def::0::@constructor::new
       typeErasure: int
       fields
         final it
@@ -977,7 +977,7 @@ library
       reference: <testLibrary>::@extensionType::E::@def::1
       firstFragment: <testLibraryFragment>::@extensionType::E::@def::1
       representation: <testLibrary>::@extensionType::E::@def::1::@field::it
-      primaryConstructor: <testLibrary>::@extensionType::E::@def::1::@constructor::E
+      primaryConstructor: <testLibrary>::@extensionType::E::@def::1::@constructor::new
       typeErasure: double
       fields
         final it

pkg/analyzer/test/src/summary/elements/enum_test.dart

@@ -2584,7 +2584,7 @@ library
       reference: <testLibrary>::@extensionType::B
       firstFragment: <testLibraryFragment>::@extensionType::B
       representation: <testLibrary>::@extensionType::B::@field::it
-      primaryConstructor: <testLibrary>::@extensionType::B::@constructor::B
+      primaryConstructor: <testLibrary>::@extensionType::B::@constructor::new
       typeErasure: int
       fields
         final it
@@ -3390,7 +3390,7 @@ library
       reference: <testLibrary>::@extensionType::B
       firstFragment: <testLibraryFragment>::@extensionType::B
       representation: <testLibrary>::@extensionType::B::@field::it
-      primaryConstructor: <testLibrary>::@extensionType::B::@constructor::B
+      primaryConstructor: <testLibrary>::@extensionType::B::@constructor::new
       typeErasure: int
       fields
         final it