Elements. Remove FragmentImpl.library

This caused several related changes.

* Inlines `ClassFragmentImpl.isDartCoreEnum`, `ClassFragmentImpl.isDartCoreObject`, and `ClassFragmentImpl.ClassFragmentImpl` at their call sites in `ClassElementImpl`.

* Inlines `ConstructorFragmentImpl.computeConstantDependencies` at its call site in `ConstructorElementImpl`.

* Changes the various implementations of the getter `ElementImpl.library` so that they don't use `FragmentImpl.library`.

* Removes the getters `FragmentImpl.context`.

* Inlines the getter `FragmentImpl.isNonFunctionTypeAliasesEnabled` at its call site in `TypeAliasElementImpl`.

* Inlines `InterfaceFragmentImpl.isDartCoreEnumImpl` at its call site in `InterfaceElementImpl`.

* Removes `InterfaceFragmentImpl.isDartCoreFunctionImpl`.

* Changes the extension `TypeParameterElementImplExtension` to apply to
`TypeParameterElementImpl` rather than `TypeParameterFragmentImpl`.

Change-Id: I43c538df047514412735586d5d85f1bc30eae33e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/441360
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -232,7 +232,7 @@ extension RecordTypeExtension on RecordType {
   }
 }
 
-extension TypeParameterElementImplExtension on TypeParameterFragmentImpl {
+extension TypeParameterElementImplExtension on TypeParameterElementImpl {
   bool get isWildcardVariable {
     return name == '_' && library.hasWildcardVariablesFeatureEnabled;
   }

pkg/analyzer/lib/src/dart/element/extensions.dart

@@ -148,7 +148,8 @@ class GenericInferrer {
       parameterType: SharedTypeView(parameterType),
       parameterName: parameterName,
       genericClassName: genericClass?.name,
-      isGenericClassInDartCore: genericClass?.library.isDartCore ?? false,
+      isGenericClassInDartCore:
+          genericClass?.element.library.isDartCore ?? false,
     );
     inferenceLogWriter?.enterConstraintGeneration(
       ConstraintGenerationSource.argument,

pkg/analyzer/lib/src/dart/element/generic_inferrer.dart

@@ -644,7 +644,7 @@ class _ClassVerifier {
     if (implementsDartCoreEnum) {
       var classElement = this.classElement;
       if (classElement is ClassFragmentImpl &&
-              !classElement.isDartCoreEnumImpl ||
+              !classElement.element.isDartCoreEnumImpl ||
           classElement is EnumFragmentImpl ||
           classElement is MixinFragmentImpl) {
         if (const {'index', 'hashCode', '=='}.contains(name.lexeme)) {

pkg/analyzer/lib/src/error/inheritance_override.dart

@@ -499,7 +499,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
       _enclosingClass = declarationElement.asElement2;
 
       List<ClassMember> members = node.members;
-      if (!declarationElement.isDartCoreFunctionImpl) {
+      if (!declarationElement.element.isDartCoreFunctionImpl) {
         _checkForBuiltInIdentifierAsName(
           node.name,
           CompileTimeErrorCode.BUILT_IN_IDENTIFIER_AS_TYPE_NAME,
@@ -2472,7 +2472,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
     ExtensionTypeFragmentImpl fragment,
   ) {
     for (var typeParameter in fragment.typeParameters) {
-      if (typeParameter.isWildcardVariable) continue;
+      if (typeParameter.element.isWildcardVariable) continue;
 
       var name = typeParameter.name ?? '';
       // name is same as the name of the enclosing class

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -384,6 +384,16 @@ class ElementBuilder {
     );
     instanceElement.addGetter(getterElement);
 
+    // `class Enum {}` in `dart:core` declares `int get index` as abstract.
+    // But the specification says that practically a different class
+    // implementing `Enum` is used as a superclass, so `index` should be
+    // considered to have non-abstract implementation.
+    if (instanceElement is ClassElementImpl &&
+        instanceElement.isDartCoreEnum &&
+        getterFragment.name == 'index') {
+      getterFragment.isAbstract = false;
+    }
+
     // If `getter` is already set, this is a compile-time error.
     // Reset to `null`, so create a new variable.
     if (lastFieldElement != null) {
@@ -1540,7 +1550,6 @@ class FragmentBuilder extends ThrowingAstVisitor<void> {
   @override
   void visitMethodDeclaration(covariant MethodDeclarationImpl node) {
     var nameToken = node.name;
-    var name = nameToken.lexeme;
 
     Reference reference;
     ExecutableFragmentImpl executableFragment;
@@ -1553,14 +1562,6 @@ class FragmentBuilder extends ThrowingAstVisitor<void> {
       fragment.isAugmentation = node.augmentKeyword != null;
       fragment.isStatic = node.isStatic;
 
-      // `class Enum {}` in `dart:core` declares `int get index` as abstract.
-      // But the specification says that practically a different class
-      // implementing `Enum` is used as a superclass, so `index` should be
-      // considered to have non-abstract implementation.
-      if (_enclosingContext.isDartCoreEnum && name == 'index') {
-        fragment.isAbstract = false;
-      }
-
       reference = Reference.root(); // TODO(scheglov): remove this
       var parentFragment = _enclosingContext.fragment;
       fragment.enclosingFragment = parentFragment;
@@ -1583,16 +1584,6 @@ class FragmentBuilder extends ThrowingAstVisitor<void> {
 
       executableFragment = fragment;
     } else {
-      var isUnaryMinus = false;
-      if (nameToken.lexeme == '-') {
-        var parameters = node.parameters;
-        isUnaryMinus = parameters != null && parameters.parameters.isEmpty;
-      }
-
-      if (isUnaryMinus) {
-        name = 'unary-';
-      }
-
       var fragment = MethodFragmentImpl(
         name: _getFragmentName(nameToken),
         firstTokenOffset: null,
@@ -1995,11 +1986,6 @@ class _EnclosingContext {
     this.hasDefaultFormalParameters = false,
   });
 
-  bool get isDartCoreEnum {
-    var fragment = this.fragment;
-    return fragment is ClassFragmentImpl && fragment.isDartCoreEnum;
-  }
-
   void addFunction(String name, TopLevelFunctionFragmentImpl fragment) {}
 
   void addParameter(String? name, FormalParameterFragmentImpl fragment) {

pkg/analyzer/lib/src/summary2/element_builder.dart

@@ -388,7 +388,7 @@ class LibraryBuilder {
     for (var interfaceFragment in element.topLevelElements) {
       switch (interfaceFragment) {
         case ClassFragmentImpl():
-          if (interfaceFragment.isDartCoreObject) continue;
+          if (interfaceFragment.element.isDartCoreObject) continue;
           if (interfaceFragment.supertype == null) {
             shouldResetClassHierarchies = true;
             interfaceFragment.supertype = objectType;

pkg/analyzer/lib/src/summary2/library_builder.dart

@@ -124,7 +124,7 @@ class TypesBuilder {
       if (type is InterfaceTypeImpl && _isInterfaceTypeClass(type)) {
         element.supertype = type;
       }
-    } else if (element.isDartCoreObject) {
+    } else if (element.element.isDartCoreObject) {
       element.setModifier(Modifier.DART_CORE_OBJECT, true);
     }
 
@@ -300,8 +300,9 @@ class TypesBuilder {
 
   void _extensionTypeDeclaration(ExtensionTypeDeclarationImpl node) {
     var fragment = node.declaredFragment!;
+    var element = fragment.element;
 
-    var typeSystem = fragment.library.typeSystem;
+    var typeSystem = element.library.typeSystem;
     var interfaces =
         node.implementsClause?.interfaces
             .map((e) => e.type)
@@ -471,7 +472,7 @@ class _MixinInference {
     this.element,
     this.featureSet, {
     required this.typeSystemOperations,
-  }) : typeSystem = element.library.typeSystem,
+  }) : typeSystem = element.element.library.typeSystem,
        classType = element.element.thisType {
     interfacesMerger = InterfacesMerger(typeSystem);
     interfacesMerger.addWithSupertypes(element.supertype);
@@ -663,20 +664,20 @@ class _MixinsInference {
     var element = declaration.element;
     element.mixinInferenceCallback = _callbackWhenLoop;
 
-    var featureSet = element.library.featureSet;
+    var library = element.element.library;
     var declarationMixins = <InterfaceTypeImpl>[];
 
     try {
       // Casts aren't relevant for mixin inference.
       var typeSystemOperations = TypeSystemOperations(
-        element.library.typeSystem,
+        library.typeSystem,
         strictCasts: false,
       );
 
       if (declaration.withClause case var withClause?) {
         var inference = _MixinInference(
           element,
-          featureSet,
+          library.featureSet,
           typeSystemOperations: typeSystemOperations,
         );
         var inferred = inference.perform(withClause);
@@ -687,7 +688,7 @@ class _MixinsInference {
       for (var augmentation in declaration.augmentations) {
         var inference = _MixinInference(
           element,
-          featureSet,
+          library.featureSet,
           typeSystemOperations: typeSystemOperations,
         );
         inference.addTypes(
@@ -710,8 +711,8 @@ class _MixinsInference {
   /// hierarchies for all classes being linked, indiscriminately.
   void _resetHierarchies() {
     for (var declaration in _declarations.values) {
-      var element = declaration.element;
-      element.library.session.classHierarchy.remove(element.asElement2);
+      var element = declaration.element.element;
+      element.library.session.classHierarchy.remove(element);
     }
   }
 }