Breaking changes for analyzer version 7.0.0

Change-Id: Id6e329c7665d1dca1920d744dd7d0e9722da768c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311461
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: scheglov

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,38 @@
+## 7.0.0 (Not yet released - breaking changes)
+* Remove deprecated `DartType.element2`.
+* Remove deprecated `DartType.isDynamic`.
+* Remove deprecated `DartType.isVoid`.
+* Remove deprecated `DartType.resolveToBound`.
+* Remove deprecated `IfElement.condition`.
+* Remove deprecated `IfStatement.condition`.
+* Remove deprecated `AstNode.getProperty` and `AstNode.setProperty`.
+* Remove `File.createSource()`, it violates levels of abstraction.
+  You can get `Source` instances from `AnalysisResult`s.
+* Remove deprecated `LibraryElement.toLegacyTypeIfOptOut`.
+* Remove deprecated `LibraryElement.toLegacyElementIfOptOut`.
+* Remove deprecated `LibraryElement.isNonNullableByDefault`.
+* Remove deprecated `File.changes` and `Folder.changes`.
+* Remove deprecated `Resource.parent2`.
+* Remove deprecated `OnClause`.
+* Remove deprecated `ContextBuilder`, use `AnalysisContextCollection`.
+* Remove deprecated `ContextLocator`, use `AnalysisContextCollection`.
+* Remove deprecated `ClassOrAugmentationDeclaration.`.
+* Remove deprecated `MixinOrAugmentationDeclaration.`.
+* Remove deprecated members of `AnalysisError`.
+* Remove deprecated `TypeSystem.instantiateToBounds2`.
+* Remove deprecated `buildSdkSummary2()`.
+* Remove deprecated `FileSource.fileReadMode`.
+* Remove deprecated members of `ErrorReporter`.
+* Remove deprecated `Comment.isBlock`, `isDocumentation`, `isEndOfLine`.
+* Remove deprecated `Element.enclosingElement`.
+* Remove deprecated `PropertyAccessor.variable`.
+* Remove experimental `LibraryOrAugmentationElement`.
+* Remove deprecated `LibraryElement` properties.
+* Remove deprecated `enabledPluginNames` and `hint` from `AnalysisOptions`.
+* Remove deprecated `source_io.dart`.
+* Remove deprecated `lint/Spelunker`.
+* Remove deprecated `source_resource.dart`.
+
 ## 6.11.0
 * Un-deprecated `LibraryElement.exportedLibraries`.
 * Un-deprecated `LibraryElement.importedLibraries`.

pkg/analyzer/lib/dart/analysis/analysis_options.dart

@@ -7,7 +7,6 @@ import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/analysis/formatter_options.dart';
 import 'package:analyzer/source/error_processor.dart';
 import 'package:analyzer/src/lint/linter.dart';
-import 'package:pub_semver/src/version_constraint.dart';
 
 /// A set of analysis options used to control the behavior of an analysis
 /// context.
@@ -28,9 +27,6 @@ abstract class AnalysisOptions {
   /// legacy plugin, the legacy plugin should be enabled.
   List<String> get enabledLegacyPluginNames;
 
-  @Deprecated("Use 'enabledLegacyPluginNames' instead")
-  List<String> get enabledPluginNames;
-
   /// Return a list of error processors that are to be used when reporting
   /// errors in some analysis context.
   List<ErrorProcessor> get errorProcessors;
@@ -42,23 +38,13 @@ abstract class AnalysisOptions {
   /// Return the options used to control the formatter.
   FormatterOptions get formatterOptions;
 
-  /// Return `true` if analysis is to generate hint results (e.g. best practices
-  /// and analysis based on certain annotations).
-  @Deprecated("Use 'warning' instead")
-  bool get hint;
-
   /// Whether analysis is to generate lint warnings.
   bool get lint;
 
   /// A list of the lint rules that are to be run in an analysis context if
   /// [lint] is `true`.
   List<LintRule> get lintRules;
 
-  /// The version range for the SDK specified in `pubspec.yaml`, or `null` if
-  /// there is no `pubspec.yaml` or if it does not contain an SDK range.
-  @Deprecated('Use `PubWorkspacePackage.sdkVersionConstraint` instead')
-  VersionConstraint? get sdkVersionConstraint;
-
   /// Whether implicit casts should be reported as potential problems.
   bool get strictCasts;
 

pkg/analyzer/lib/dart/analysis/context_builder.dart

@@ -183,8 +183,6 @@ export 'package:analyzer/src/dart/ast/ast.dart'
         NullLiteral,
         NullShortableExpression,
         ObjectPattern,
-        // ignore:deprecated_member_use_from_same_package
-        OnClause,
         ParenthesizedExpression,
         ParenthesizedPattern,
         PartDirective,
@@ -255,9 +253,3 @@ export 'package:analyzer/src/dart/ast/ast.dart'
         WildcardPattern,
         WithClause,
         YieldStatement;
-
-@Deprecated('This class was removed, use ClassDeclaration instead')
-typedef ClassOrAugmentationDeclaration = ClassDeclaration;
-
-@Deprecated('This class was removed, use MixinDeclaration instead')
-typedef MixinOrAugmentationDeclaration = MixinDeclaration;

pkg/analyzer/lib/dart/analysis/context_locator.dart

@@ -516,8 +516,7 @@ class GeneralizingAstVisitor<R> implements AstVisitor<R> {
 
   @override
   R? visitMixinOnClause(MixinOnClause node) {
-    // ignore:deprecated_member_use_from_same_package
-    return visitOnClause(node);
+    return visitNode(node);
   }
 
   R? visitNamedCompilationUnitMember(NamedCompilationUnitMember node) =>
@@ -563,10 +562,6 @@ class GeneralizingAstVisitor<R> implements AstVisitor<R> {
   @override
   R? visitObjectPattern(ObjectPattern node) => visitDartPattern(node);
 
-  @Deprecated('Use visitMixinOnClause() instead')
-  @override
-  R? visitOnClause(OnClause node) => visitNode(node);
-
   @override
   R? visitParenthesizedExpression(ParenthesizedExpression node) =>
       visitExpression(node);
@@ -1420,8 +1415,8 @@ class RecursiveAstVisitor<R> implements AstVisitor<R> {
 
   @override
   R? visitMixinOnClause(MixinOnClause node) {
-    // ignore:deprecated_member_use_from_same_package
-    return visitOnClause(node);
+    node.visitChildren(this);
+    return null;
   }
 
   @override
@@ -1478,13 +1473,6 @@ class RecursiveAstVisitor<R> implements AstVisitor<R> {
     return null;
   }
 
-  @Deprecated('Use visitMixinOnClause() instead')
-  @override
-  R? visitOnClause(OnClause node) {
-    node.visitChildren(this);
-    return null;
-  }
-
   @override
   R? visitParenthesizedExpression(ParenthesizedExpression node) {
     node.visitChildren(this);
@@ -2170,10 +2158,7 @@ class SimpleAstVisitor<R> implements AstVisitor<R> {
   R? visitMixinDeclaration(MixinDeclaration node) => null;
 
   @override
-  R? visitMixinOnClause(MixinOnClause node) {
-    // ignore:deprecated_member_use_from_same_package
-    return visitOnClause(node);
-  }
+  R? visitMixinOnClause(MixinOnClause node) => null;
 
   @override
   R? visitNamedExpression(NamedExpression node) => null;
@@ -2202,10 +2187,6 @@ class SimpleAstVisitor<R> implements AstVisitor<R> {
   @override
   R? visitObjectPattern(ObjectPattern node) => null;
 
-  @Deprecated('Use visitMixinOnClause() instead')
-  @override
-  R? visitOnClause(OnClause node) => null;
-
   @override
   R? visitParenthesizedExpression(ParenthesizedExpression node) => null;
 
@@ -2725,10 +2706,7 @@ class ThrowingAstVisitor<R> implements AstVisitor<R> {
   R? visitMixinDeclaration(MixinDeclaration node) => _throw(node);
 
   @override
-  R? visitMixinOnClause(MixinOnClause node) {
-    // ignore:deprecated_member_use_from_same_package
-    return visitOnClause(node);
-  }
+  R? visitMixinOnClause(MixinOnClause node) => _throw(node);
 
   @override
   R? visitNamedExpression(NamedExpression node) => _throw(node);
@@ -2757,10 +2735,6 @@ class ThrowingAstVisitor<R> implements AstVisitor<R> {
   @override
   R? visitObjectPattern(ObjectPattern node) => _throw(node);
 
-  @Deprecated('Use visitMixinOnClause() instead')
-  @override
-  R? visitOnClause(OnClause node) => _throw(node);
-
   @override
   R? visitParenthesizedExpression(ParenthesizedExpression node) => _throw(node);
 
@@ -3798,8 +3772,10 @@ class TimedAstVisitor<T> implements AstVisitor<T> {
 
   @override
   T? visitMixinOnClause(MixinOnClause node) {
-    // ignore:deprecated_member_use_from_same_package
-    return visitOnClause(node);
+    stopwatch.start();
+    T? result = _baseVisitor.visitMixinOnClause(node);
+    stopwatch.stop();
+    return result;
   }
 
   @override
@@ -3874,15 +3850,6 @@ class TimedAstVisitor<T> implements AstVisitor<T> {
     return result;
   }
 
-  @Deprecated('Use visitMixinOnClause() instead')
-  @override
-  T? visitOnClause(OnClause node) {
-    stopwatch.start();
-    T? result = _baseVisitor.visitOnClause(node);
-    stopwatch.stop();
-    return result;
-  }
-
   @override
   T? visitParenthesizedExpression(ParenthesizedExpression node) {
     stopwatch.start();
@@ -4708,10 +4675,7 @@ class UnifyingAstVisitor<R> implements AstVisitor<R> {
   R? visitMixinDeclaration(MixinDeclaration node) => visitNode(node);
 
   @override
-  R? visitMixinOnClause(MixinOnClause node) {
-    // ignore:deprecated_member_use_from_same_package
-    return visitOnClause(node);
-  }
+  R? visitMixinOnClause(MixinOnClause node) => visitNode(node);
 
   @override
   R? visitNamedExpression(NamedExpression node) => visitNode(node);
@@ -4745,10 +4709,6 @@ class UnifyingAstVisitor<R> implements AstVisitor<R> {
   @override
   R? visitObjectPattern(ObjectPattern node) => visitNode(node);
 
-  @Deprecated('Use visitMixinOnClause() instead')
-  @override
-  R? visitOnClause(OnClause node) => visitNode(node);
-
   @override
   R? visitParenthesizedExpression(ParenthesizedExpression node) =>
       visitNode(node);