Skip to content

Commit d0afa40

Browse files
pqCommit Queue
authored andcommitted
[element model] migrate recursive_getters
Bug: https://github.com/dart-lang/linter/issues/5099 Change-Id: I1555e7088a67037513a10600443c9d8385a402e8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390120 Commit-Queue: Brian Wilkerson <[email protected]> Auto-Submit: Phil Quitslund <[email protected]> Commit-Queue: Phil Quitslund <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent ffc82e6 commit d0afa40

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/linter/lib/src/rules/recursive_getters.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import 'package:analyzer/dart/ast/ast.dart';
66
import 'package:analyzer/dart/ast/visitor.dart';
7-
import 'package:analyzer/dart/element/element.dart';
7+
import 'package:analyzer/dart/element/element2.dart';
88

99
import '../analyzer.dart';
1010

@@ -31,11 +31,11 @@ class RecursiveGetters extends LintRule {
3131

3232
class _BodyVisitor extends RecursiveAstVisitor<void> {
3333
final LintRule rule;
34-
final ExecutableElement element;
34+
final ExecutableElement2 element;
3535
_BodyVisitor(this.element, this.rule);
3636

3737
bool isSelfReference(SimpleIdentifier node) {
38-
if (node.staticElement != element) return false;
38+
if (node.element != element) return false;
3939
var parent = node.parent;
4040
if (parent is PrefixedIdentifier) return false;
4141
if (parent is PropertyAccess && parent.target is! ThisExpression) {
@@ -76,18 +76,18 @@ class _Visitor extends SimpleAstVisitor<void> {
7676
// getters have null arguments, methods have parameters, could be empty.
7777
if (node.functionExpression.parameters != null) return;
7878

79-
_verifyElement(node.functionExpression, node.declaredElement);
79+
_verifyElement(node.functionExpression, node.declaredFragment?.element);
8080
}
8181

8282
@override
8383
void visitMethodDeclaration(MethodDeclaration node) {
8484
// getters have null arguments, methods have parameters, could be empty.
8585
if (node.parameters != null) return;
8686

87-
_verifyElement(node.body, node.declaredElement);
87+
_verifyElement(node.body, node.declaredFragment?.element);
8888
}
8989

90-
void _verifyElement(AstNode node, ExecutableElement? element) {
90+
void _verifyElement(AstNode node, ExecutableElement2? element) {
9191
if (element == null) return;
9292
node.accept(_BodyVisitor(element, rule));
9393
}

0 commit comments

Comments
 (0)