Fix up comments in reachability test data.

Turning on the sound-flow-analysis language feature caused a lot of
code to be classified as unreachable. This change updates comments in
the reachability tests to reflect the new behavior.

Bug: #60438
Change-Id: Iec3fd10e4a5d7f890bbe14e0eadd845eeb7a3225
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427584
Reviewed-by: Johnni Winther <[email protected]>
Auto-Submit: Paul Berry <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: stereotype441

pkg/_fe_analyzer_shared/test/flow_analysis/reachability/data/equality_operator.dart

@@ -38,7 +38,7 @@ void nullableValue(int? x) {
 
 void nonNullableValue(int x) {
   if (x == null) /*unreachable*/ {
-    // Reachable since the value of x might come from legacy code
+    // Unreachable since Dart 3.9.
     /*stmt: unreachable*/
     1;
   } else {
@@ -72,7 +72,7 @@ void potentiallyNullableTypeVar_nullableBound<T extends Object?>(T x) {
 
 void nonNullableTypeVar<T extends Object>(T x) {
   if (x == null) /*unreachable*/ {
-    // Reachable since the value of x might come from legacy code
+    // Unreachable since Dart 3.9.
     /*stmt: unreachable*/
     1;
   } else {

pkg/_fe_analyzer_shared/test/flow_analysis/reachability/data/if_null.dart

@@ -11,19 +11,19 @@ void variable_if_null_assign_reachable(int? i) {
 }
 
 void variable_if_null_unreachable(int i) {
-  // Reachable since the value of i might come from legacy code
+  // Unreachable since Dart 3.9.
   i ?? /*unreachable*/ 0;
 }
 
 void variable_if_null_assign_unreachable(int i) {
-  // Reachable since the value of i might come from legacy code
+  // Unreachable since Dart 3.9.
   /*cfe.update: unreachable*/
   i ??= /*unreachable*/ 0;
 }
 
 void variable_if_null_assign_unreachable_due_to_promotion(int? i) {
   if (i == null) return;
-  // Reachable since the value of i might come from legacy code
+  // Unreachable since Dart 3.9.
   /*cfe.update: unreachable*/
   i ??= /*unreachable*/ 0;
 }
@@ -45,14 +45,12 @@ void top_level_if_null_assign_reachable() {
 }
 
 void top_level_if_null_unreachable() {
-  // Reachable since the value returned by topLevelNonNullGet might come from
-  // legacy code
+  // Unreachable since Dart 3.9.
   topLevelNonNullGet ?? /*unreachable*/ 0;
 }
 
 void top_level_if_null_assign_unreachable() {
-  // Reachable since the value returned by topLevelNonNullGet might come from
-  // legacy code
+  // Unreachable since Dart 3.9.
   topLevelNonNullGet /*cfe.update: unreachable*/ ??= /*unreachable*/ 0;
 }
 
@@ -71,12 +69,12 @@ void property_if_null_assign_reachable(HasProperty<int?> x) {
 }
 
 void property_if_null_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by prop might come from legacy code
+  // Unreachable since Dart 3.9.
   x.prop ?? /*unreachable*/ 0;
 }
 
 void property_if_null_assign_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by prop might come from legacy code
+  // Unreachable since Dart 3.9.
   x.prop ??= /*unreachable*/ 0;
 }
 
@@ -89,13 +87,12 @@ void null_aware_property_if_null_assign_reachable(HasProperty<int?>? x) {
 }
 
 void null_aware_property_if_null_not_shortened(HasProperty<int>? x) {
-  // Reachable since the value returned by prop might come from legacy code.
-  // Also since `??` doesn't participate in null shortening.
+  // Reachable since `??` doesn't participate in null shortening.
   x?.prop ?? 0;
 }
 
 void null_aware_property_if_null_assign_unreachable(HasProperty<int>? x) {
-  // Reachable since the value returned by prop might come from legacy code.
+  // Reachable since Dart 3.9.
   x?.prop ??= /*unreachable*/ 0;
 }
 
@@ -111,12 +108,12 @@ class SuperIntQuestionProperty extends HasProperty<int?> {
 
 class SuperIntProperty extends HasProperty<int> {
   void if_null_unreachable() {
-    // Reachable since the value returned by prop might come from legacy code.
+    // Unreachable since Dart 3.9.
     super.prop ?? /*unreachable*/ 0;
   }
 
   void if_null_assign_unreachable() {
-    // Reachable since the value returned by prop might come from legacy code.
+    // Unreachable since Dart 3.9.
     super.prop ??= /*unreachable*/ 0;
   }
 }
@@ -138,14 +135,12 @@ void extended_property_if_null_assign_reachable(HasProperty<int?> x) {
 }
 
 void extended_property_if_null_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by extendedProp might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x.extendedProp ?? /*unreachable*/ 0;
 }
 
 void extended_property_if_null_assign_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by extendedProp might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x.extendedProp ??= /*unreachable*/ 0;
 }
 
@@ -160,16 +155,14 @@ void null_aware_extended_property_if_null_assign_reachable(
 }
 
 void null_aware_extended_property_if_null_not_shortened(HasProperty<int>? x) {
-  // Reachable since the value returned by extendedProp might come from legacy
-  // code, and because `??` doesn't participate in null shortening.
+  // Reachable because `??` doesn't participate in null shortening.
   x?.extendedProp ?? 0;
 }
 
 void null_aware_extended_property_if_null_assign_unreachable(
   HasProperty<int>? x,
 ) {
-  // Reachable since the value returned by extendedProp might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x?.extendedProp ??= /*unreachable*/ 0;
 }
 
@@ -182,14 +175,12 @@ void explicit_extended_property_if_null_assign_reachable(HasProperty<int?> x) {
 }
 
 void explicit_extended_property_if_null_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by extendedProp might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   ExtensionProperty(x).extendedProp ?? /*unreachable*/ 0;
 }
 
 void explicit_extended_property_if_null_assign_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by extendedProp might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   ExtensionProperty(x).extendedProp ??= /*unreachable*/ 0;
 }
 
@@ -208,16 +199,14 @@ void null_aware_explicit_extended_property_if_null_assign_reachable(
 void null_aware_explicit_extended_property_if_null_not_shortened(
   HasProperty<int>? x,
 ) {
-  // Reachable since the value returned by extendedProp might come from legacy
-  // code, and because `??` doesn't participate in null shortening.
+  // Reachable because `??` doesn't participate in null shortening.
   ExtensionProperty(x)?.extendedProp ?? 0;
 }
 
 void null_aware_explicit_extended_property_if_null_assign_unreachable(
   HasProperty<int>? x,
 ) {
-  // Reachable since the value returned by extendedProp might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   ExtensionProperty(x)?.extendedProp ??= /*unreachable*/ 0;
 }
 
@@ -232,8 +221,7 @@ void index_if_null_reachable(Indexable<int?> x) {
 }
 
 void index_if_null_unreachable(Indexable<int> x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x[0] ?? /*unreachable*/ 0;
 }
 
@@ -242,8 +230,7 @@ void index_if_null_assign_reachable(Indexable<int?> x) {
 }
 
 void index_if_null_assign_unreachable(Indexable<int> x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x[0] ??= /*unreachable*/ 0;
 }
 
@@ -252,8 +239,7 @@ void null_aware_index_if_null_reachable(Indexable<int?>? x) {
 }
 
 void null_aware_index_if_null_unreachable(Indexable<int>? x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code, and because `??` doesn't participate in null shortening.
+  // Reachable because `??` doesn't participate in null shortening.
   x?[0] ?? 0;
 }
 
@@ -262,8 +248,7 @@ void null_aware_index_if_null_assign_reachable(Indexable<int?>? x) {
 }
 
 void null_aware_index_if_null_assign_unreachable(Indexable<int>? x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x?[0] ??= /*unreachable*/ 0;
 }
 
@@ -279,14 +264,12 @@ class SuperIntQuestionIndex extends Indexable<int?> {
 
 class SuperIntIndex extends Indexable<int> {
   void if_null_unreachable() {
-    // Reachable since the value returned by operator[] might come from legacy
-    // code.
+    // Unreachable since Dart 3.9.
     super[0] ?? /*unreachable*/ 0;
   }
 
   void if_null_assign_unreachable() {
-    // Reachable since the value returned by operator[] might come from legacy
-    // code.
+    // Unreachable since Dart 3.9.
     super[0] ??= /*unreachable*/ 0;
   }
 }
@@ -308,14 +291,12 @@ void extended_index_if_null_assign_reachable(HasProperty<int?> x) {
 }
 
 void extended_index_if_null_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x[0] ?? /*unreachable*/ 0;
 }
 
 void extended_index_if_null_assign_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x[0] ??= /*unreachable*/ 0;
 }
 
@@ -328,14 +309,12 @@ void null_aware_extended_index_if_null_assign_reachable(HasProperty<int?>? x) {
 }
 
 void null_aware_extended_index_if_null_not_shortened(HasProperty<int>? x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code, and because `??` doesn't participate in null shortening.
+  // Reachable because `??` doesn't participate in null shortening.
   x?[0] ?? 0;
 }
 
 void null_aware_extended_index_if_null_assign_unreachable(HasProperty<int>? x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   x?[0] ??= /*unreachable*/ 0;
 }
 
@@ -348,14 +327,12 @@ void explicit_extended_index_if_null_assign_reachable(HasProperty<int?> x) {
 }
 
 void explicit_extended_index_if_null_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   ExtensionIndex(x)[0] ?? /*unreachable*/ 0;
 }
 
 void explicit_extended_index_if_null_assign_unreachable(HasProperty<int> x) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   ExtensionIndex(x)[0] ??= /*unreachable*/ 0;
 }
 
@@ -374,15 +351,13 @@ void null_aware_explicit_extended_index_if_null_assign_reachable(
 void null_aware_explicit_extended_index_if_null_not_shortened(
   HasProperty<int>? x,
 ) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code, and because `??` doesn't participate in null shortening.
+  // Reachable because `??` doesn't participate in null shortening.
   ExtensionIndex(x)?[0] ?? 0;
 }
 
 void null_aware_explicit_extended_index_if_null_assign_unreachable(
   HasProperty<int>? x,
 ) {
-  // Reachable since the value returned by operator[] might come from legacy
-  // code.
+  // Unreachable since Dart 3.9.
   ExtensionIndex(x)?[0] ??= /*unreachable*/ 0;
 }

pkg/_fe_analyzer_shared/test/flow_analysis/reachability/data/null_aware_access.dart

@@ -9,7 +9,7 @@ void index_reachable(List<int>? f()) {
 
 /*member: index_unreachable:doesNotComplete*/
 void index_unreachable(List<int> f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   f()?[throw ''];
   /*stmt: unreachable*/
   0;
@@ -22,7 +22,7 @@ void cascaded_index_reachable(List<int>? f()) {
 
 /*member: cascaded_index_unreachable:doesNotComplete*/
 void cascaded_index_unreachable(List<int> f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   f()?..[throw ''];
   /*stmt: unreachable*/
   0;
@@ -35,7 +35,7 @@ void method_invocation_reachable(int? f()) {
 
 /*member: method_invocation_unreachable:doesNotComplete*/
 void method_invocation_unreachable(int f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   f()?.remainder(throw '');
   /*stmt: unreachable*/
   0;
@@ -48,7 +48,7 @@ void cascaded_method_invocation_reachable(int? f()) {
 
 /*member: cascaded_method_invocation_unreachable:doesNotComplete*/
 void cascaded_method_invocation_unreachable(int f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   f()?..remainder(throw '');
   /*stmt: unreachable*/
   0;
@@ -61,7 +61,7 @@ void property_get_reachable(int? f()) {
 
 /*member: property_get_unreachable:doesNotComplete*/
 void property_get_unreachable(int f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   f()?.hashCode.remainder(throw '');
   /*stmt: unreachable*/
   0;
@@ -74,7 +74,7 @@ void cascaded_property_get_reachable(int? f()) {
 
 /*member: cascaded_property_get_unreachable:doesNotComplete*/
 void cascaded_property_get_unreachable(int f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   f()?..hashCode.remainder(throw '');
   /*stmt: unreachable*/
   0;
@@ -90,7 +90,7 @@ void property_get_invocation_reachable(List<void Function(dynamic)>? f()) {
 
 /*member: property_get_invocation_unreachable:doesNotComplete*/
 void property_get_invocation_unreachable(List<void Function(dynamic)> f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   // We need a special test case for this because it parses like a method
   // invocation but the analyzer rewrites it as a property access followed by a
   // function expression invocation.
@@ -113,7 +113,7 @@ void cascaded_property_get_invocation_reachable(
 void cascaded_property_get_invocation_unreachable(
   List<void Function(dynamic)> f(),
 ) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   // We need a special test case for this because it parses like a method
   // invocation but the analyzer rewrites it as a property access followed by a
   // function expression invocation.
@@ -133,7 +133,7 @@ void property_set_reachable(C? f()) {
 
 /*member: property_set_unreachable:doesNotComplete*/
 void property_set_unreachable(C f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   f()?.field = throw '';
   /*stmt: unreachable*/
   0;
@@ -146,7 +146,7 @@ void cascaded_property_set_reachable(C? f()) {
 
 /*member: cascaded_property_set_unreachable:doesNotComplete*/
 void cascaded_property_set_unreachable(C f()) {
-  // Reachable since the value returned by f() might come from legacy code
+  // Unreachable since Dart 3.9.
   f()?..field = throw '';
   /*stmt: unreachable*/
   0;