Skip to content

Commit d1bffec

Browse files
dcharkesCommit Queue
authored andcommitted
[vm/ffi] Cleanup some legacy multi-tests
Bug: #60212 Change-Id: Icb6272b38b48b5445beaab8be528c4c5698b74fb Cq-Include-Trybots: dart/try:vm-aot-linux-debug-x64-try,vm-aot-mac-release-arm64-try,vm-reload-linux-debug-x64-try,vm-win-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412240 Commit-Queue: Daco Harkes <[email protected]> Reviewed-by: Michael Goderbauer <[email protected]>
1 parent c5af227 commit d1bffec

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

tests/ffi/unaligned_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ final bool isUnalignedFloatingPointAccessSupported = switch (Abi.current()) {
4040

4141
void main() {
4242
print("hello");
43-
testUnalignedInt16(); //# 01: ok
44-
testUnalignedInt32(); //# 02: ok
45-
testUnalignedInt64(); //# 03: ok
43+
testUnalignedInt16();
44+
testUnalignedInt32();
45+
testUnalignedInt64();
4646
if (isUnalignedFloatingPointAccessSupported) {
47-
testUnalignedFloat(); //# 04: ok
48-
testUnalignedDouble(); //# 05: ok
47+
testUnalignedFloat();
48+
testUnalignedDouble();
4949
}
5050
_freeAll();
5151
}

tests/ffi/vmspecific_function_callbacks_exit_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ void main() async {
6060
//
6161
// Since they use signal handlers they only run on Linux.
6262
if (Platform.isLinux && !const bool.fromEnvironment("dart.vm.product")) {
63-
testCallbackWrongThread(); //# 01: ok
64-
testCallbackOutsideIsolate(); //# 02: ok
65-
await testCallbackWrongIsolate(); //# 03: ok
63+
testCallbackWrongThread();
64+
testCallbackOutsideIsolate();
65+
await testCallbackWrongIsolate();
6666
}
6767
}

tests/ffi/vmspecific_highmem_32bit_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ void testOnHighOrLowMemory(Pointer<Uint8> memory, int indexOffset) {
8181
testLoadsAndStores(indexOffset, memory.offsetBy(kIgnoreBytesPositive - 5));
8282
testLoadsAndStores(indexOffset, memory.offsetBy(kIgnoreBytesNegative - 5));
8383
final m2 = Pointer<Uint8>.fromAddress(kIgnoreBytesPositive + memory.address);
84-
Expect.equals(memory, m2); //# 01: ok
85-
Expect.equals(memory.address, m2.address); //# 01: ok
84+
Expect.equals(memory, m2);
85+
Expect.equals(memory.address, m2.address);
8686
testLoadsAndStores(indexOffset, m2);
8787
final m3 = Pointer<Uint8>.fromAddress(kIgnoreBytesNegative + memory.address);
88-
Expect.equals(memory, m3); //# 01: ok
89-
Expect.equals(memory.address, m3.address); //# 01: ok
88+
Expect.equals(memory, m3);
89+
Expect.equals(memory.address, m3.address);
9090
testLoadsAndStores(indexOffset, m3);
9191
}
9292

@@ -99,8 +99,8 @@ withMMapedAddress(
9999
if (result.address == kMapFailed) {
100100
throw 'Could not mmap @0x${fixedAddress.address.toRadixString(16)}!';
101101
}
102-
Expect.equals(fixedAddress, result); //# 01: ok
103-
Expect.equals(fixedAddress.address, result.address); //# 01: ok
102+
Expect.equals(fixedAddress, result);
103+
Expect.equals(fixedAddress.address, result.address);
104104
try {
105105
fun(result);
106106
} finally {

tests/ffi/vmspecific_leaf_call_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@ testCallbackLeaf() {
5353
}
5454

5555
main() {
56-
testLeafCall(); //# 01: ok
56+
testLeafCall();
5757
// These tests terminate the process after successful completion, so we have
5858
// to run them separately.
5959
//
6060
// Since they use signal handlers they only run on Linux.
6161
if (Platform.isLinux && !const bool.fromEnvironment("dart.vm.product")) {
62-
testLeafCallApi(); //# 02: ok
63-
testCallbackLeaf(); //# 03: ok
62+
testLeafCallApi();
63+
testCallbackLeaf();
6464
}
6565
}

0 commit comments

Comments
 (0)