Fine. Remove requirements from the same library.

We analyze the whole library anyway when anything changes in it.

Change-Id: I80913e2383998098aa150f048ad2c39310b915e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425921
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -1440,6 +1440,8 @@ class AnalysisDriver {
         }
 
         if (withFineDependencies && requirements != null) {
+          requirements.removeReqForLibs({library.file.uri});
+
           performance.run('writeResolvedLibrary', (_) {
             var mapSink = BufferedSink();
             mapSink.writeMap(

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -7269,10 +7269,6 @@ void f (B b) {
           methods
             isEven: #M5
             isEven=: <null>
-      package:test/test.dart
-        A
-          constructors
-            new: #M6
 [status] idle
 ''',
       updateFiles: () {
@@ -7296,13 +7292,13 @@ void f (B b) {
     manifest
       A: #M0
         declaredMembers
-          _foo.getter: #M7
+          _foo.getter: #M6
       B: #M2
       f: #M3
   requirements
     topLevels
       dart:core
-        String: #M8
+        String: #M7
 [future] getErrors T2
   ErrorsResult #1
     path: /home/test/lib/test.dart
@@ -7318,7 +7314,7 @@ void f (B b) {
   requirements
     topLevels
       dart:core
-        String: #M8
+        String: #M7
     interfaces
       dart:core
         Object
@@ -7329,10 +7325,6 @@ void f (B b) {
           methods
             isEven: <null>
             isEven=: <null>
-      package:test/test.dart
-        A
-          constructors
-            new: #M6
 [status] idle
 ''',
     );
@@ -8940,10 +8932,6 @@ void f (B b) {
           methods
             isEven: #M5
             isEven=: <null>
-      package:test/test.dart
-        A
-          constructors
-            new: #M6
 [status] idle
 ''',
       updateFiles: () {
@@ -8967,13 +8955,13 @@ void f (B b) {
     manifest
       A: #M0
         declaredMembers
-          _foo.method: #M7
+          _foo.method: #M6
       B: #M2
       f: #M3
   requirements
     topLevels
       dart:core
-        String: #M8
+        String: #M7
 [future] getErrors T2
   ErrorsResult #1
     path: /home/test/lib/test.dart
@@ -8989,7 +8977,7 @@ void f (B b) {
   requirements
     topLevels
       dart:core
-        String: #M8
+        String: #M7
     interfaces
       dart:core
         Object
@@ -9000,10 +8988,6 @@ void f (B b) {
           methods
             isEven: <null>
             isEven=: <null>
-      package:test/test.dart
-        A
-          constructors
-            new: #M6
 [status] idle
 ''',
     );
@@ -9061,11 +9045,6 @@ void f(B b) {
     topLevels
       dart:core
         int: #M4
-    interfaces
-      package:test/test.dart
-        A
-          constructors
-            new: #M5
 [status] idle
 ''',
       updateFiles: () {
@@ -9089,13 +9068,13 @@ void f(B b) {
     manifest
       A: #M0
         declaredMembers
-          _foo.method: #M6
+          _foo.method: #M5
       B: #M2
       f: #M3
   requirements
     topLevels
       dart:core
-        double: #M7
+        double: #M6
 [future] getErrors T2
   ErrorsResult #1
     path: /home/test/lib/test.dart
@@ -9109,12 +9088,7 @@ void f(B b) {
   requirements
     topLevels
       dart:core
-        double: #M7
-    interfaces
-      package:test/test.dart
-        A
-          constructors
-            new: #M5
+        double: #M6
 [status] idle
 ''',
     );
@@ -10213,11 +10187,6 @@ void f (B b) {
     topLevels
       dart:core
         int: #M4
-    interfaces
-      package:test/test.dart
-        A
-          constructors
-            new: #M5
 [status] idle
 ''',
       updateFiles: () {
@@ -10241,13 +10210,13 @@ void f (B b) {
     manifest
       A: #M0
         declaredMembers
-          _foo.setter: #M6
+          _foo.setter: #M5
       B: #M2
       f: #M3
   requirements
     topLevels
       dart:core
-        String: #M7
+        String: #M6
 [future] getErrors T2
   ErrorsResult #1
     path: /home/test/lib/test.dart
@@ -10263,12 +10232,7 @@ void f (B b) {
   requirements
     topLevels
       dart:core
-        String: #M7
-    interfaces
-      package:test/test.dart
-        A
-          constructors
-            new: #M5
+        String: #M6
 [status] idle
 ''',
     );