[dart2js] Track, rather than compute, isCallOnInterceptor

By tracking `isCallOnInterceptor`, we avoid the need for class context
information in the `sourceElement` to compute the value. `sourceElement`
is now purely advisory to the choice of local names in codegen, and
can't be the wrong kind of element as in issue #60793.

Bug: #60793
Change-Id: I8bb68b6bf864a3a6f9f2beb40f68a6254431d49a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432003
Commit-Queue: Stephen Adams <[email protected]>
Reviewed-by: Mayank Patke <[email protected]>

Author: rakudrama

pkg/compiler/lib/src/ssa/codegen.dart

@@ -2480,7 +2480,7 @@ class SsaCodeGenerator implements HVisitor<void>, HBlockInformationVisitor {
     if (superElement is FieldEntity) {
       // TODO(sra): We can lower these in the simplifier.
       js.Name fieldName = _namer.instanceFieldPropertyName(superElement);
-      use(node.getDartReceiver(_closedWorld));
+      use(node.getDartReceiver());
       js.PropertyAccess access =
           js.PropertyAccess(
                 pop(),

pkg/compiler/lib/src/ssa/codegen_helpers.dart

@@ -111,7 +111,7 @@ class SsaInstructionSelection extends HBaseVisitor<HInstruction?>
       // The instructionType of [nullCheck] is not nullable (since it is the
       // (not) null check!) This means that if we do need to check the type, we
       // should test against nullCheck.checkedInput, not the direct input.
-      if (current!.getDartReceiver(_closedWorld) == nullCheck) {
+      if (current!.getDartReceiver() == nullCheck) {
         if (current is HFieldGet) return current;
         if (current is HFieldSet) return current;
         if (current is HGetLength) return current;

pkg/compiler/lib/src/ssa/interceptor_finalizer.dart

@@ -62,8 +62,8 @@ class SsaFinalizeInterceptors extends HBaseVisitor<void>
   }
 
   /// Returns `true` if [element] is an instance method that uses the
-  /// interceptor calling convention but the instance and interceptor arguments
-  /// will always be the same value.
+  /// interceptor calling convention but the interceptor argument will always be
+  /// the instance.
   bool usesSelfInterceptor(MemberEntity element) {
     if (!_interceptorData.isInterceptedMethod(element)) return false;
     ClassEntity cls = element.enclosingClass!;
@@ -101,6 +101,12 @@ class SsaFinalizeInterceptors extends HBaseVisitor<void>
     thisParameter!.instructionType = receiverParameter!.instructionType;
     receiverParameter.block!.rewrite(receiverParameter, thisParameter);
     receiverParameter.sourceElement = const _RenameToUnderscore();
+
+    for (final instruction in thisParameter.usedBy) {
+      if (instruction is HInvoke) {
+        instruction.updateIsCallOnInterceptor();
+      }
+    }
   }
 
   @override
@@ -262,6 +268,7 @@ class SsaFinalizeInterceptors extends HBaseVisitor<void>
   }
 
   void _replaceReceiverArgumentWithDummy(HInvoke node, int receiverIndex) {
+    assert(!node.isCallOnInterceptor, 'node: $node');
     ConstantValue constant = DummyInterceptorConstantValue();
     HConstant dummy = _graph.addConstant(constant, _closedWorld);
     node.replaceInput(receiverIndex, dummy);

pkg/compiler/lib/src/ssa/interceptor_simplifier.dart

@@ -266,7 +266,7 @@ class SsaSimplifyInterceptors extends HBaseVisitor<bool>
     // If there is a call that dominates all other uses, we can use just the
     // selector of that instruction.
     if (dominator is HInvokeDynamic &&
-        dominator.isCallOnInterceptor(_closedWorld) &&
+        dominator.isCallOnInterceptor &&
         node == dominator.receiver &&
         useCount(dominator, node) == 1) {
       interceptedClasses = _interceptorData.getInterceptedClassesOn(
@@ -303,7 +303,7 @@ class SsaSimplifyInterceptors extends HBaseVisitor<bool>
       interceptedClasses = {};
       for (HInstruction user in node.usedBy) {
         if (user is HInvokeDynamic &&
-            user.isCallOnInterceptor(_closedWorld) &&
+            user.isCallOnInterceptor &&
             node == user.receiver &&
             useCount(user, node) == 1) {
           interceptedClasses.addAll(
@@ -313,7 +313,7 @@ class SsaSimplifyInterceptors extends HBaseVisitor<bool>
             ),
           );
         } else if (user is HInvokeSuper &&
-            user.isCallOnInterceptor(_closedWorld) &&
+            user.isCallOnInterceptor &&
             node == user.receiver &&
             useCount(user, node) == 1) {
           interceptedClasses.addAll(
@@ -402,7 +402,7 @@ class SsaSimplifyInterceptors extends HBaseVisitor<bool>
     //     }
 
     void finishInvoke(HInvoke invoke, Selector selector) {
-      HInstruction callReceiver = invoke.getDartReceiver(_closedWorld)!;
+      HInstruction callReceiver = invoke.getDartReceiver()!;
       if (receiver.nonCheck() == callReceiver.nonCheck()) {
         Set<ClassEntity> interceptedClasses = _interceptorData
             .getInterceptedClassesOn(selector.name, _closedWorld);
@@ -412,19 +412,20 @@ class SsaSimplifyInterceptors extends HBaseVisitor<bool>
           interceptedClasses: interceptedClasses,
         )) {
           invoke.changeUse(node, callReceiver);
+          invoke.updateIsCallOnInterceptor();
         }
       }
     }
 
     for (HInstruction user in node.usedBy.toList()) {
       if (user is HInvokeDynamic) {
-        if (user.isCallOnInterceptor(_closedWorld) &&
+        if (user.isCallOnInterceptor &&
             node == user.inputs[0] &&
             useCount(user, node) == 1) {
           finishInvoke(user, user.selector);
         }
       } else if (user is HInvokeSuper) {
-        if (user.isCallOnInterceptor(_closedWorld) &&
+        if (user.isCallOnInterceptor &&
             node == user.inputs[0] &&
             useCount(user, node) == 1) {
           finishInvoke(user, user.selector);

pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart

@@ -361,7 +361,7 @@ class IndexSpecializer extends InvokeDynamicSpecializer {
     JClosedWorld closedWorld,
     OptimizationTestLog? log,
   ) {
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
     var abstractValueDomain = closedWorld.abstractValueDomain;
     if (receiver.isIndexablePrimitive(abstractValueDomain).isPotentiallyFalse) {
       return null;
@@ -419,7 +419,7 @@ class CodeUnitAtSpecializer extends InvokeDynamicSpecializer {
     OptimizationTestLog? log,
   ) {
     final abstractValueDomain = closedWorld.abstractValueDomain;
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
     if (receiver.isStringOrNull(abstractValueDomain).isPotentiallyFalse) {
       return null;
     }
@@ -460,7 +460,7 @@ class RemoveLastSpecializer extends InvokeDynamicSpecializer {
     JClosedWorld closedWorld,
     OptimizationTestLog? log,
   ) {
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
     final abstractValueDomain = closedWorld.abstractValueDomain;
     if (receiver.isGrowableArray(abstractValueDomain).isPotentiallyFalse) {
       return null;
@@ -876,7 +876,7 @@ class ModuloSpecializer extends BinaryArithmeticSpecializer {
     // track -0.0 precisely, we have to syntactically filter inputs that cannot
     // generate -0.0.
 
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
     if (inputsArePositiveIntegers(instruction, closedWorld) &&
         !canBeNegativeZero(receiver)) {
       return HRemainder(
@@ -1840,7 +1840,7 @@ class CompareToSpecializer extends InvokeDynamicSpecializer {
     JClosedWorld closedWorld,
     OptimizationTestLog? log,
   ) {
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
     // `compareTo` has no side-effect (other than throwing) and can be GVN'ed
     // for some known types.
     if (receiver
@@ -1890,7 +1890,7 @@ abstract class IdempotentStringOperationSpecializer
     JClosedWorld closedWorld,
     OptimizationTestLog? log,
   ) {
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
     if (receiver
         .isStringOrNull(closedWorld.abstractValueDomain)
         .isDefinitelyTrue) {
@@ -1937,7 +1937,7 @@ class PatternMatchSpecializer extends InvokeDynamicSpecializer {
     JClosedWorld closedWorld,
     OptimizationTestLog? log,
   ) {
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
     HInstruction pattern = instruction.inputs[2];
     if (receiver
             .isStringOrNull(closedWorld.abstractValueDomain)
@@ -1969,7 +1969,7 @@ class RoundSpecializer extends InvokeDynamicSpecializer {
     JClosedWorld closedWorld,
     OptimizationTestLog? log,
   ) {
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
     if (receiver
         .isNumberOrNull(closedWorld.abstractValueDomain)
         .isDefinitelyTrue) {
@@ -1997,7 +1997,7 @@ class ToIntSpecializer extends InvokeDynamicSpecializer {
     JClosedWorld closedWorld,
     OptimizationTestLog? log,
   ) {
-    HInstruction receiver = instruction.getDartReceiver(closedWorld);
+    HInstruction receiver = instruction.getDartReceiver();
 
     // We would like to reduce `x.toInt()` to `x`. The web platform considers
     // infinities to be `int` values, but it is too hard to tell if an input is