Elements. Fix InstanceElementImpl2.name3, return firstFragment.name2, nullable.

Change-Id: Idd7239c1be692219f1f1ba735f475fe0141c0c6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430821
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -4544,7 +4544,7 @@ abstract class InstanceElementImpl2 extends ElementImpl2
   List<MethodElementImpl2> get methods2 => methods;
 
   @override
-  String? get name3 => firstFragment.name;
+  String? get name3 => firstFragment.name2;
 
   @override
   Element get nonSynthetic2 => isSynthetic ? enclosingElement : this as Element;

pkg/analyzer/lib/src/test_utilities/mock_sdk_elements.dart

@@ -969,6 +969,7 @@ class _MockSdkElementsBuilder {
     required LibraryFragmentImpl unit,
   }) {
     var fragment = ClassFragmentImpl(name, 0);
+    fragment.name2 = name;
     ClassElementImpl2(Reference.root(), fragment);
     fragment.typeParameters =
         typeParameters.map((tp) => tp.firstFragment).toList();

pkg/analyzer/test/generated/elements_types_mixin.dart

@@ -155,6 +155,7 @@ mixin ElementsTypesMixin {
     List<MethodElementImpl2> methods = const [],
   }) {
     var fragment = ClassFragmentImpl(name, 0);
+    fragment.name2 = name;
     fragment.isAbstract = isAbstract;
     fragment.isAugmentation = isAugmentation;
     fragment.isSealed = isSealed;
@@ -479,6 +480,7 @@ mixin ElementsTypesMixin {
     List<InterfaceTypeImpl> interfaces = const [],
   }) {
     var fragment = MixinFragmentImpl(name, 0);
+    fragment.name2 = name;
     fragment.isAugmentation = isAugmentation;
     fragment.enclosingElement3 = testLibrary.definingCompilationUnit;
     fragment.typeParameters = typeParameters.map((e) => e.asElement).toList();
@@ -500,6 +502,7 @@ mixin ElementsTypesMixin {
     List<InterfaceTypeImpl> interfaces = const [],
   }) {
     var fragment = MixinFragmentImpl(name, 0);
+    fragment.name2 = name;
     fragment.isAugmentation = isAugmentation;
     fragment.enclosingElement3 = testLibrary.definingCompilationUnit;
     fragment.typeParameters = typeParameters.map((e) => e.asElement).toList();

pkg/analyzer/test/src/summary/elements/class_test.dart

@@ -13104,7 +13104,7 @@ library
               element: <testLibraryFragment>::@class::0::@constructor::new#element
               typeName: null
   classes
-    class 
+    class <null-name>
       reference: <testLibrary>::@class::0
       firstFragment: <testLibraryFragment>::@class::0
       constructors

pkg/analyzer/test/src/summary/elements/enum_test.dart

@@ -3096,13 +3096,13 @@ library
                   constructorName: ConstructorName
                     type: NamedType
                       name: <empty> @-1 <synthetic>
-                      element2: <testLibrary>::@enum::0
-                      type: 
-                    element: <testLibraryFragment>::@enum::0::@constructor::new#element
+                      element2: <null>
+                      type: InvalidType
+                    element: <null>
                   argumentList: ArgumentList
                     leftParenthesis: ( @0
                     rightParenthesis: ) @0
-                  staticType: 
+                  staticType: InvalidType
               getter2: <testLibraryFragment>::@enum::0::@getter::v
             synthetic values
               reference: <testLibraryFragment>::@enum::0::@field::values
@@ -3114,9 +3114,9 @@ library
                     SimpleIdentifier
                       token: v @-1
                       element: <testLibraryFragment>::@enum::0::@getter::v#element
-                      staticType: 
+                      staticType: InvalidType
                   rightBracket: ] @0
-                  staticType: List<>
+                  staticType: List<<null>>
               getter2: <testLibraryFragment>::@enum::0::@getter::values
           constructors
             synthetic const new
@@ -3131,21 +3131,21 @@ library
               reference: <testLibraryFragment>::@enum::0::@getter::values
               element: <testLibraryFragment>::@enum::0::@getter::values#element
   enums
-    enum 
+    enum <null-name>
       reference: <testLibrary>::@enum::0
       firstFragment: <testLibraryFragment>::@enum::0
       supertype: Enum
       fields
         static const enumConstant hasInitializer v
           firstFragment: <testLibraryFragment>::@enum::0::@field::v
-          type: 
+          type: InvalidType
           constantInitializer
             fragment: <testLibraryFragment>::@enum::0::@field::v
             expression: expression_0
           getter: <testLibraryFragment>::@enum::0::@getter::v#element
         synthetic static const values
           firstFragment: <testLibraryFragment>::@enum::0::@field::values
-          type: List<>
+          type: List<<null>>
           constantInitializer
             fragment: <testLibraryFragment>::@enum::0::@field::values
             expression: expression_1
@@ -3156,10 +3156,10 @@ library
       getters
         synthetic static get v
           firstFragment: <testLibraryFragment>::@enum::0::@getter::v
-          returnType: 
+          returnType: InvalidType
         synthetic static get values
           firstFragment: <testLibraryFragment>::@enum::0::@getter::values
-          returnType: List<>
+          returnType: List<<null>>
 ''');
   }
 

pkg/analyzer/test/src/summary/elements/extension_type_test.dart

@@ -1621,7 +1621,7 @@ library
               reference: <testLibraryFragment>::@extensionType::0::@getter::it
               element: <testLibraryFragment>::@extensionType::0::@getter::it#element
   extensionTypes
-    extension type 
+    extension type <null-name>
       reference: <testLibrary>::@extensionType::0
       firstFragment: <testLibraryFragment>::@extensionType::0
       representation: <testLibraryFragment>::@extensionType::0::@field::it#element

pkg/analyzer/test/src/summary/elements/mixin_test.dart

@@ -1433,7 +1433,7 @@ library
           reference: <testLibraryFragment>::@mixin::0
           element: <testLibrary>::@mixin::0
   mixins
-    mixin 
+    mixin <null-name>
       reference: <testLibrary>::@mixin::0
       firstFragment: <testLibraryFragment>::@mixin::0
       superclassConstraints