Skip to content

Commit d678a7e

Browse files
parloughCommit Queue
authored andcommitted
[analyzer] Stop generating the diagnostics.md file
dart.dev now consumes the source YAML files, so generating the Markdown file is no longer necessary. The contents of the YAML files are still verified as before. Resolves dart-lang/site-www#6387 Change-Id: I8b989b598ec3c7abef66242dceb9d5a481f43e39 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407640 Reviewed-by: Phil Quitslund <[email protected]> Commit-Queue: Johnni Winther <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]> Auto-Submit: Parker Lougheed <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
1 parent 7bb0c4c commit d678a7e

File tree

7 files changed

+4
-30413
lines changed

7 files changed

+4
-30413
lines changed

pkg/analyzer/test/verify_diagnostics_test.dart

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'package:analyzer/error/error.dart';
6-
import 'package:analyzer/file_system/physical_file_system.dart';
76
import 'package:test/test.dart';
87
import 'package:test_reflective_loader/test_reflective_loader.dart';
98

10-
import '../tool/diagnostics/generate.dart';
119
import '../tool/messages/error_code_documentation_info.dart';
1210
import '../tool/messages/error_code_info.dart';
1311
import 'src/dart/resolution/context_collection_resolution.dart';
@@ -421,25 +419,6 @@ class VerifyDiagnosticsTest {
421419
//
422420
DocumentationValidator validator = DocumentationValidator();
423421
await validator.validate();
424-
//
425-
// Validate that the generator has been run.
426-
//
427-
String actualContent = PhysicalResourceProvider.INSTANCE
428-
.getFile(computeOutputPath())
429-
.readAsStringSync();
430-
// Normalize Windows line endings to Unix line endings so that the
431-
// comparison doesn't fail on Windows.
432-
actualContent = actualContent.replaceAll('\r\n', '\n');
433-
434-
StringBuffer sink = StringBuffer();
435-
DocumentationGenerator generator = DocumentationGenerator();
436-
generator.writeDocumentation(sink);
437-
String expectedContent = sink.toString();
438-
439-
if (actualContent != expectedContent) {
440-
fail('The diagnostic documentation needs to be regenerated.\n'
441-
'Please run tool/diagnostics/generate.dart.');
442-
}
443422
}
444423

445424
test_published() {

0 commit comments

Comments
 (0)