linter: Remove unused ast utilities

Change-Id: I4a436a77a69cc4a78ceb1ca27b95a81ab55dc868
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428422
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>

Author: srawlins

pkg/linter/lib/src/ast.dart

@@ -18,14 +18,16 @@ import 'package:analyzer/src/workspace/workspace.dart' // ignore: implementation
 import 'package:path/path.dart' as path;
 
 import 'analyzer.dart';
-import 'utils.dart';
 
-final List<String> reservedWords = _collectReservedWords();
+final Set<String> _reservedWords = {
+  for (var entry in Keyword.keywords.entries)
+    if (entry.value.isReservedWord) entry.key,
+};
 
 /// Returns direct children of [parent].
 List<Element> getChildren(Element parent, [String? name]) {
   var children = <Element>[];
-  visitChildren(parent, (Element element) {
+  _visitChildren(parent, (Element element) {
     if (name == null || element.displayName == name) {
       children.add(element);
     }
@@ -131,27 +133,12 @@ bool hasConstantError(Expression node) =>
 bool isEquals(ClassMember element) =>
     element is MethodDeclaration && element.name.lexeme == '==';
 
-/// Returns `true` if the keyword associated with this token is `final` or
-/// `const`.
-bool isFinalOrConst(Token token) =>
-    isKeyword(token, Keyword.FINAL) || isKeyword(token, Keyword.CONST);
-
 /// Returns `true` if this element is a `hashCode` method or field declaration.
 bool isHashCode(ClassMember element) => _hasFieldOrMethod(element, 'hashCode');
 
 /// Returns `true` if this element is an `index` method or field declaration.
 bool isIndex(ClassMember element) => _hasFieldOrMethod(element, 'index');
 
-/// Return true if this compilation unit [node] is declared within the given
-/// [package]'s `lib/` directory tree.
-bool isInLibDir(CompilationUnit node, WorkspacePackage? package) {
-  if (package == null) return false;
-  var cuPath = node.declaredFragment?.element.firstFragment.source.fullName;
-  if (cuPath == null) return false;
-  var libDir = path.join(package.root, 'lib');
-  return path.isWithin(libDir, cuPath);
-}
-
 /// Return `true` if this compilation unit [node] is declared within a public
 /// directory in the given [package]'s directory tree. Public dirs are the
 /// `lib` and `bin` dirs and the build and link hook file.
@@ -172,25 +159,8 @@ bool isInPublicDir(CompilationUnit node, WorkspacePackage? package) {
       cuPath == linkHookFile;
 }
 
-/// Returns `true` if the given [id] is a Dart keyword.
-bool isKeyWord(String id) => Keyword.keywords.containsKey(id);
-
-/// Returns `true` if the keyword associated with the given [token] matches
-/// [keyword].
-bool isKeyword(Token token, Keyword keyword) =>
-    token is KeywordToken && token.keyword == keyword;
-
-/// Returns `true` if the given [ClassMember] is a method.
-bool isMethod(ClassMember m) => m is MethodDeclaration;
-
-/// Returns `true` if the given [ClassMember] is a public method.
-bool isPublicMethod(ClassMember m) {
-  var declaredElement = m.declaredFragment?.element;
-  return declaredElement != null && isMethod(m) && declaredElement.isPublic;
-}
-
 /// Check if the given word is a Dart reserved word.
-bool isReservedWord(String word) => reservedWords.contains(word);
+bool isReservedWord(String word) => _reservedWords.contains(word);
 
 /// Returns `true` if the given method [declaration] is a "simple getter".
 ///
@@ -263,15 +233,9 @@ bool isSimpleSetter(MethodDeclaration setter) {
   return false;
 }
 
-/// Returns `true` if the given [id] is a valid Dart identifier.
-bool isValidDartIdentifier(String id) => !isKeyWord(id) && isIdentifier(id);
-
 /// Returns `true` if this element is a `values` method or field declaration.
 bool isValues(ClassMember element) => _hasFieldOrMethod(element, 'values');
 
-/// Returns `true` if the keyword associated with this token is `var`.
-bool isVar(Token token) => isKeyword(token, Keyword.VAR);
-
 /// Return the nearest enclosing pubspec file.
 File? locatePubspecFile(CompilationUnit compilationUnit) {
   var declaredFragment = compilationUnit.declaredFragment;
@@ -293,12 +257,6 @@ File? locatePubspecFile(CompilationUnit compilationUnit) {
   return null;
 }
 
-/// Uses [processor] to visit all of the children of [element].
-/// If [processor] returns `true`, then children of a child are visited too.
-void visitChildren(Element element, ElementProcessor processor) {
-  element.visitChildren2(_ElementVisitorAdapter(processor));
-}
-
 bool _checkForSimpleGetter(MethodDeclaration getter, Expression? expression) {
   if (expression is SimpleIdentifier) {
     var staticElement = expression.element;
@@ -352,16 +310,6 @@ bool _checkForSimpleSetter(MethodDeclaration setter, Expression expression) {
   return false;
 }
 
-List<String> _collectReservedWords() {
-  var reserved = <String>[];
-  for (var entry in Keyword.keywords.entries) {
-    if (entry.value.isReservedWord) {
-      reserved.add(entry.key);
-    }
-  }
-  return reserved;
-}
-
 int? _getIntValue(
   Expression expression,
   LinterContext? context, {
@@ -409,6 +357,12 @@ bool _hasFieldOrMethod(ClassMember element, String name) =>
     (element is MethodDeclaration && element.name.lexeme == name) ||
     (element is FieldDeclaration && getFieldName(element, name) != null);
 
+/// Uses [processor] to visit all of the children of [element].
+/// If [processor] returns `true`, then children of a child are visited too.
+void _visitChildren(Element element, ElementProcessor processor) {
+  element.visitChildren2(_ElementVisitorAdapter(processor));
+}
+
 /// An [Element] processor function type.
 /// If `true` is returned, children of [element] will be visited.
 typedef ElementProcessor = bool Function(Element element);

pkg/linter/test/rule_test.dart

@@ -2,41 +2,12 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:linter/src/ast.dart';
 import 'package:test/test.dart';
 
 import 'util/test_utils.dart';
 
 void main() {
   group('rule tests', () {
     setUp(setUpSharedTestEnvironment);
-    defineRuleUnitTests();
-  });
-}
-
-void defineRuleUnitTests() {
-  group('names', () {
-    group('keywords', () {
-      var good = ['class', 'if', 'assert', 'catch', 'import'];
-      testEach(good, isKeyWord, isTrue);
-      var bad = ['_class', 'iff', 'assert_', 'Catch'];
-      testEach(bad, isKeyWord, isFalse);
-    });
-    group('identifiers', () {
-      var good = [
-        'foo',
-        '_if',
-        '_',
-        'f2',
-        'fooBar',
-        'foo_bar',
-        '\$foo',
-        'foo\$Bar',
-        'foo\$',
-      ];
-      testEach(good, isValidDartIdentifier, isTrue);
-      var bad = ['if', '42', '3', '2f'];
-      testEach(bad, isValidDartIdentifier, isFalse);
-    });
   });
 }