Skip to content

Commit d73f7bd

Browse files
fshcheglovCommit Queue
authored andcommitted
Generate GeneralizingAstVisitor, TimedAstVisitor, AnalysisRuleVisitor and AstVisitor.
Fixed an incorrect name `_forRecordLiterals` in `RuleVisitorRegistryImpl`. Refactored existing generators to reduce code duplication, extracted _Node class and made helper extensions. For context I am currently reading Crafting Interpreters by Robert Nystrom and was inspired to use the code generation shown in the book. Change-Id: Ia26aa2f697b98dae89903648758c2ca47d1823ec Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442561 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent 3c53e3e commit d73f7bd

File tree

9 files changed

+4904
-4572
lines changed

9 files changed

+4904
-4572
lines changed

pkg/analyzer/api.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2191,6 +2191,7 @@ package:analyzer/dart/ast/visitor.dart:
21912191
visitCollectionElement (method: R? Function(CollectionElement))
21922192
visitCombinator (method: R? Function(Combinator))
21932193
visitComment (method: R? Function(Comment))
2194+
visitCommentReferableExpression (method: R? Function(CommentReferableExpression))
21942195
visitCommentReference (method: R? Function(CommentReference))
21952196
visitCompilationUnit (method: R? Function(CompilationUnit))
21962197
visitCompilationUnitMember (method: R? Function(CompilationUnitMember))
@@ -2237,6 +2238,7 @@ package:analyzer/dart/ast/visitor.dart:
22372238
visitForEachPartsWithIdentifier (method: R? Function(ForEachPartsWithIdentifier))
22382239
visitForEachPartsWithPattern (method: R? Function(ForEachPartsWithPattern))
22392240
visitForElement (method: R? Function(ForElement))
2241+
visitForLoopParts (method: R? Function(ForLoopParts))
22402242
visitForParts (method: R? Function(ForParts))
22412243
visitForPartsWithDeclarations (method: R? Function(ForPartsWithDeclarations))
22422244
visitForPartsWithExpression (method: R? Function(ForPartsWithExpression))
@@ -2364,6 +2366,7 @@ package:analyzer/dart/ast/visitor.dart:
23642366
visitVariableDeclaration (method: R? Function(VariableDeclaration))
23652367
visitVariableDeclarationList (method: R? Function(VariableDeclarationList))
23662368
visitVariableDeclarationStatement (method: R? Function(VariableDeclarationStatement))
2369+
visitVariablePattern (method: R? Function(VariablePattern))
23672370
visitWhenClause (method: R? Function(WhenClause))
23682371
visitWhileStatement (method: R? Function(WhileStatement))
23692372
visitWildcardPattern (method: R? Function(WildcardPattern))

0 commit comments

Comments
 (0)