Opt multitests out of formatting in web/.

munificent · Commit Queue · commit d7ed15658ab7 · 2024-11-19T00:59:10.000Z
The new formatter supports opting a region of code out from being formatted. I'm applying this marker to all of the multitests since those tests are often very sensitive to formatting and easily broken. This way, anyone touching a multitest (including me when I reformat the tests) doesn't have to remember to not run the formatter on it. Change-Id: I3d6346d31581772dc8e1701594bf9d919f28db7d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396104 Commit-Queue: Bob Nystrom <rnystrom@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> Reviewed-by: Nate Biggs <natebiggs@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com> Auto-Submit: Bob Nystrom <rnystrom@google.com>
diff --git a/tests/web/LayoutTests_fast_mediastream_getusermedia_t01_test.dart b/tests/web/LayoutTests_fast_mediastream_getusermedia_t01_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 /// Test derived from a broken co19 test
 /// (LayoutTests/fast/mediastream/getusermedia_t01.dart). Caused dart2js to
 /// crash.
diff --git a/tests/web/bounds_check_test.dart b/tests/web/bounds_check_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 main() {
   var a = [0, 1];
   a[-1]; //                         //# 01: runtime error
diff --git a/tests/web/checked_setter_test.dart b/tests/web/checked_setter_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 import 'package:expect/expect.dart';
 
 class A {
diff --git a/tests/web/compile_time_constant4_test.dart b/tests/web/compile_time_constant4_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 import "package:expect/expect.dart";
 
 const x = "foo";
diff --git a/tests/web/constant_truncate_test.dart b/tests/web/constant_truncate_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 const a0 = 0 ~/ 0; //# a0: compile-time error
 const a1 = 0.0 ~/ 0; //# a1: compile-time error
 const a2 = -0.0 ~/ 0; //# a2: compile-time error
diff --git a/tests/web/deferred/regress_35311/regress_35311_test.dart b/tests/web/deferred/regress_35311/regress_35311_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 import 'lib.dart' deferred as lib;
 
 main() async {
diff --git a/tests/web/dynamic_invocation_test.dart b/tests/web/dynamic_invocation_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 import "package:expect/expect.dart";
 
 class C1 {
diff --git a/tests/web/eof_line_ending_test.dart b/tests/web/eof_line_ending_test.dart
@@ -1,7 +1,10 @@
 // Copyright (c) 2018, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-
+
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // Regression test derived from language/issue_1578_test.dart with Windows
 // line encoding.
 
diff --git a/tests/web/function_typed_arguments_test.dart b/tests/web/function_typed_arguments_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // dart2jsOptions=--omit-implicit-checks
 
 // Test type tests of function types used a type argument.
diff --git a/tests/web/if_method_call_test.dart b/tests/web/if_method_call_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // Regression test for bug in dart2js type promotion.
 
 import 'package:expect/expect.dart';
diff --git a/tests/web/inline_generic_test.dart b/tests/web/inline_generic_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 /// Test that inlining of constructors with `double` as type argument registers
 /// that double is need for checking passed values.
 
diff --git a/tests/web/int_index_test.dart b/tests/web/int_index_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 main() {
   var a = [0, 1];
   a[1.2]; //                      //# 01: compile-time error
diff --git a/tests/web/internal/deferred_url_test.dart b/tests/web/internal/deferred_url_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 import 'dart:_js_helper';
 import 'dart:_foreign_helper';
 import 'dart:_js_embedded_names';
diff --git a/tests/web/invalid_annotation_test.dart b/tests/web/invalid_annotation_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // Regression test for http://dartbug.com/23893
 //
 // Because annotations are parsed lazily, dart2js used to crash when an
diff --git a/tests/web/jsinterop_test.dart b/tests/web/jsinterop_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // TODO(johnniwinther): Share this test with ddc.
 
 // Test for positive and negative uses of js-interop declarations in a library
diff --git a/tests/web/label_test.dart b/tests/web/label_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // A break label must be declared where it's used.
 undeclaredBreakLabel1() {
   foo: { break bar; break foo; } // //# 01: compile-time error
diff --git a/tests/web/local_function_signatures_strong_test.dart b/tests/web/local_function_signatures_strong_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 import 'package:expect/expect.dart';
 
 class Class1 {
diff --git a/tests/web/many_instantiations_test.dart b/tests/web/many_instantiations_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // Test generic instantiation with many type arguments.
 
 import 'package:expect/expect.dart';
diff --git a/tests/web/native/native_test.dart b/tests/web/native/native_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // Test for positive and negative uses of named declarations. This file is
 // also used in tests/compiler/dart2js/model/native_test.dart.
 
diff --git a/tests/web/non_jsinterop_test.dart b/tests/web/non_jsinterop_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // TODO(johnniwinther): Share this test with ddc.
 
 // Test for positive and negative uses of js-interop declarations in a library
diff --git a/tests/web/regress/issue/23486_test.dart b/tests/web/regress/issue/23486_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // Regression test for http://dartbug.com/23486
 //
 // Dart2js used to crash when using `super` and prefixes inside parenthesized
diff --git a/tests/web/regress/issue/27323_test.dart b/tests/web/regress/issue/27323_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // dart2jsOptions=--strong
 
 import 'package:expect/expect.dart';
diff --git a/tests/web/regress/issue/32997b_test.dart b/tests/web/regress/issue/32997b_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // dart2jsOptions=--strong
 
 import '32997b_lib.dart' deferred as b; //# 01: compile-time error
diff --git a/tests/web/regress/issue/34701_test.dart b/tests/web/regress/issue/34701_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // dart2jsOptions=--omit-implicit-checks
 
 /// Regression test for issue 34701.
diff --git a/tests/web/switch_test.dart b/tests/web/switch_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 import "package:expect/expect.dart";
 
 switcher(val) {
diff --git a/tests/web/throw1_test.dart b/tests/web/throw1_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 void main() {
   throw "foo"; // //# 01: runtime error
 }
diff --git a/tests/web/throw2_test.dart b/tests/web/throw2_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 void throw1() {
   throw "foo";
 }
diff --git a/tests/web/unused_local_const_test.dart b/tests/web/unused_local_const_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 class A {
   const A();
 
diff --git a/tests/web/wasm/issue_56234_test.dart b/tests/web/wasm/issue_56234_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // dart2wasmOptions=--extra-compiler-option=--omit-explicit-checks
 
 class C {
diff --git a/tests/web/wasm/reject_import_export_pragmas_test.dart b/tests/web/wasm/reject_import_export_pragmas_test.dart
@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// Formatting can break multitests, so don't format them.
+// dart format off
+
 // Test that importing `dart:ffi` and using `wasm:import` and export pragmas
 // are not allowed.
 
