Version 3.9.0-233.0.dev

Merge 265a970 into dev

Author: Dart CI

DEPS

@@ -138,7 +138,7 @@ vars = {
   "i18n_rev": "43214dde639f496377b6151115d1415128298c53",
   "leak_tracker_rev": "f5620600a5ce1c44f65ddaa02001e200b096e14c", # rolled manually
   "material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
-  "native_rev": "7f5bfa6973becbb0b4d6ecc34f41f9cdc5701d83", # rolled manually while native assets are experimental
+  "native_rev": "5eadfaf3b732bc512d327ac284b6f294bf05e4c2", # rolled manually while native assets are experimental
   "protobuf_rev": "32d53dad4565fc6ccd69196b8fd213454f3e8ed5",
   "pub_rev": "818f10b4bf9249bd0b2c212dd8709675eeb14cd2", # rolled manually
   "shelf_rev": "082d3ac2d13a98700d8148e8fad8f3e12a6fd0e1",

PRESUBMIT.py

@@ -537,19 +537,6 @@ def _CheckDartApiWinCSync(input_api, output_api):
     return []
 
 
-def _CheckNoRuntimeObservatoryChanges(input_api, output_api):
-    """Ensures that no further changes are made to runtime/observatory."""
-    for f in input_api.AffectedFiles(include_deletes=False):
-        path = f.LocalPath()
-        if path.startswith("runtime/observatory/"):
-            return [
-                output_api.PresubmitError(
-                    'Observatory is being moved to pkg/observatory. Files under '
-                    'runtime/observatory should no longer be modified.')
-            ]
-    return []
-
-
 def _CommonChecks(input_api, output_api):
     results = []
     results.extend(_CheckValidHostsInDEPS(input_api, output_api))
@@ -565,7 +552,6 @@ def _CommonChecks(input_api, output_api):
     results.extend(_CheckAnalyzerFiles(input_api, output_api))
     results.extend(_CheckDevCompilerSync(input_api, output_api))
     results.extend(_CheckDartApiWinCSync(input_api, output_api))
-    results.extend(_CheckNoRuntimeObservatoryChanges(input_api, output_api))
     return results
 
 

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -2640,7 +2640,7 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
             suggestRequired: noRequired,
             suggestVariableName: name.coversOffset(offset),
             suggestCovariant: suggestCovariant,
-            suggestThis : suggestThis,
+            suggestThis: suggestThis,
           );
         }
         _forTypeAnnotation(node);
@@ -3065,6 +3065,7 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
     }
 
     if (offset <= node.name.end) {
+      var constAdded = false;
       var container = grandparent?.parent;
       var keyword = parent.keyword;
       var type = parent.type;
@@ -3074,6 +3075,7 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
           keywordHelper.addKeyword(Keyword.CONST);
           keywordHelper.addKeyword(Keyword.FINAL);
           keywordHelper.addKeyword(Keyword.VAR);
+          constAdded = true;
         }
         if (keyword == null || keyword.keyword != Keyword.VAR) {
           _forTypeAnnotation(node);
@@ -3110,7 +3112,9 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
           // The parser often recovers from incomplete code by assuming that
           // the user is typing a field declaration, but it's quite possible
           // that the user is trying to type a different kind of declaration.
-          keywordHelper.addKeyword(Keyword.CONST);
+          if (!constAdded) {
+            keywordHelper.addKeyword(Keyword.CONST);
+          }
           if (container is ClassDeclaration) {
             keywordHelper.addKeyword(Keyword.FACTORY);
           }

pkg/linter/test/rules/omit_obvious_local_variable_types_test.dart

@@ -58,6 +58,26 @@ class A {
     );
   }
 
+  test_cascade_dotShorthand() async {
+    await assertNoDiagnostics(r'''
+f() {
+  A a = .new()..x..x..x;
+}
+
+class A {
+  final x = 0;
+}
+''');
+  }
+
+  test_dot_shorthand() async {
+    await assertNoDiagnostics(r'''
+f() {
+  int i = .parse('1');
+}
+''');
+  }
+
   test_forEach_inferredList() async {
     await assertDiagnostics(
       r'''
@@ -69,6 +89,16 @@ f() {
     );
   }
 
+  test_forEach_inferredList_dotShorthands() async {
+    await assertNoDiagnostics(r'''
+enum E { a, b, c }
+
+f() {
+  for (E e in [.a, .b, .c]) { }
+}
+''');
+  }
+
   test_forEach_listWithNonObviousElement() async {
     await assertNoDiagnostics(r'''
 f() {
@@ -175,6 +205,16 @@ class A {}
     );
   }
 
+  test_instanceCreation_nonGeneric_dotShorthand() async {
+    await assertNoDiagnostics(r'''
+f() {
+  A a = .new();
+}
+
+class A {}
+''');
+  }
+
   test_list() async {
     await assertDiagnostics(
       r'''
@@ -186,6 +226,16 @@ f() {
     );
   }
 
+  test_list_dotShorthand() async {
+    await assertNoDiagnostics(r'''
+enum E { a, b, c }
+
+f() {
+  List<E> a = [.a, .b, .c];
+}
+''');
+  }
+
   test_list_ok1() async {
     await assertNoDiagnostics(r'''
 f() {

pkg/linter/test/rules/omit_obvious_property_types_test.dart

@@ -91,6 +91,12 @@ class C {
     );
   }
 
+  test_dot_shorthand() async {
+    await assertNoDiagnostics(r'''
+int i = .parse('1');
+''');
+  }
+
   test_genericInvocation_paramIsType_static() async {
     await assertNoDiagnostics(r'''
 T bar<T>(T d) => d;
@@ -197,6 +203,16 @@ class C {}
     );
   }
 
+  test_instanceCreation_nonGeneric_static_dotShorthand() async {
+    await assertNoDiagnostics(r'''
+class A {
+  static C c = .new();
+}
+
+class C {}
+''');
+  }
+
   test_instanceCreation_nonGeneric_topLevel() async {
     await assertDiagnostics(
       r'''
@@ -208,6 +224,14 @@ class C {}
     );
   }
 
+  test_instanceCreation_nonGeneric_topLevel_dotShorthand() async {
+    await assertNoDiagnostics(r'''
+C c = .new();
+
+class C {}
+''');
+  }
+
   test_list_ok1_static() async {
     await assertNoDiagnostics(r'''
 class A {

third_party/pkg/native_toolchain_c.status

@@ -5,6 +5,8 @@
 test/cbuilder/cbuilder_cross_android_test: SkipByDesign # Cross compilation is not tested on the Dart CI.
 test/cbuilder/cbuilder_cross_linux_host_test: SkipByDesign # Cross compilation is not tested on the Dart CI.
 test/cbuilder/cbuilder_cross_windows_host_test: SkipByDesign # Cross compilation is not tested on the Dart CI.
+test/clinker/objects_cross_android_test: SkipByDesign # Cross compilation is not tested on the Dart CI.
+test/clinker/treeshake_cross_android_test: SkipByDesign # Cross compilation is not tested on the Dart CI.
 test/clinker/treeshake_cross_test: SkipByDesign # Cross compilation is not tested on the Dart CI.
 test/native_toolchain/gcc_test: SkipByDesign # Cross compilation is not tested on the Dart CI.
 test/native_toolchain/ndk_test: SkipByDesign # Cross compilation is not tested on the Dart CI.

tools/VERSION

@@ -27,5 +27,5 @@ CHANNEL dev
 MAJOR 3
 MINOR 9
 PATCH 0
-PRERELEASE 232
+PRERELEASE 233
 PRERELEASE_PATCH 0