[front_end] Bump language version to 3.9 and reformat.

This commit was generated by the following steps:

- Manually change the SDK constraint in `pkg/front_end/pubspec.yaml`

- Run `gclient sync`

- Run `find pkg/front_end/benchmarks pkg/front_end/lib
  pkg/front_end/presubmit_helper.dart
  pkg/front_end/presubmit_helper_spawn.dart pkg/front_end/test
  pkg/front_end/tool -iname '*.dart' | xargs
  tools/sdks/dart-sdk/bin/dart format`

- Manually fix remaining long lines and add dead code ignore comments.

- Fix coverage by running `dart --enable-asserts
  pkg/front_end/test/coverage_suite.dart --tasks=5
  --add-and-remove-comments`

- Fix `pkg/front_end/test/coverage_merger/assert_message_auto_ignored`
  by running `dart pkg/front_end/test/unit_test_suites.dart -p
  pkg/front_end/test/coverage_merger/assert_message_auto_ignored
  -DupdateExpectations=true`

The diff is large because the version bump causes the formatter to
switch into "tall mode".

Change-Id: I6a6a696410da8b168060acfe0e4d6e91e294c4f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447628
Auto-Submit: Paul Berry <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: stereotype441

pkg/front_end/benchmarks/patterns/generate_datatypes.dart

@@ -80,8 +80,8 @@ List<Test> tests = [''');
 ''');
 
   String result = new DartFormatter(
-          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
-      .format(sb.toString());
+    languageVersion: DartFormatter.latestShortStyleLanguageVersion,
+  ).format(sb.toString());
   new File.fromUri(fileUri).writeAsStringSync(result);
 }
 
@@ -219,7 +219,7 @@ class CounterVisitor$size implements Visitor$size<void, Counter> {
 ''');
 
   String result = new DartFormatter(
-          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
-      .format(sb.toString());
+    languageVersion: DartFormatter.latestShortStyleLanguageVersion,
+  ).format(sb.toString());
   new File.fromUri(fileUri).writeAsStringSync(result);
 }

pkg/front_end/benchmarks/patterns/generated/datatype.dart

@@ -31,108 +31,108 @@ List<Test> tests = [
     dynamicDispatchStrategy: incByDynamicDispatch1,
     ifThenElseStrategy: incByIfThenElseDispatch1,
     visitorStrategy: incByVisitorDispatch1,
-    patternStrategy: incByPatternDispatch1
+    patternStrategy: incByPatternDispatch1,
   }),
   Test<Base2>(2, createData2, {
     dynamicDispatchStrategy: incByDynamicDispatch2,
     ifThenElseStrategy: incByIfThenElseDispatch2,
     visitorStrategy: incByVisitorDispatch2,
-    patternStrategy: incByPatternDispatch2
+    patternStrategy: incByPatternDispatch2,
   }),
   Test<Base3>(3, createData3, {
     dynamicDispatchStrategy: incByDynamicDispatch3,
     ifThenElseStrategy: incByIfThenElseDispatch3,
     visitorStrategy: incByVisitorDispatch3,
-    patternStrategy: incByPatternDispatch3
+    patternStrategy: incByPatternDispatch3,
   }),
   Test<Base4>(4, createData4, {
     dynamicDispatchStrategy: incByDynamicDispatch4,
     ifThenElseStrategy: incByIfThenElseDispatch4,
     visitorStrategy: incByVisitorDispatch4,
-    patternStrategy: incByPatternDispatch4
+    patternStrategy: incByPatternDispatch4,
   }),
   Test<Base5>(5, createData5, {
     dynamicDispatchStrategy: incByDynamicDispatch5,
     ifThenElseStrategy: incByIfThenElseDispatch5,
     visitorStrategy: incByVisitorDispatch5,
-    patternStrategy: incByPatternDispatch5
+    patternStrategy: incByPatternDispatch5,
   }),
   Test<Base6>(6, createData6, {
     dynamicDispatchStrategy: incByDynamicDispatch6,
     ifThenElseStrategy: incByIfThenElseDispatch6,
     visitorStrategy: incByVisitorDispatch6,
-    patternStrategy: incByPatternDispatch6
+    patternStrategy: incByPatternDispatch6,
   }),
   Test<Base7>(7, createData7, {
     dynamicDispatchStrategy: incByDynamicDispatch7,
     ifThenElseStrategy: incByIfThenElseDispatch7,
     visitorStrategy: incByVisitorDispatch7,
-    patternStrategy: incByPatternDispatch7
+    patternStrategy: incByPatternDispatch7,
   }),
   Test<Base8>(8, createData8, {
     dynamicDispatchStrategy: incByDynamicDispatch8,
     ifThenElseStrategy: incByIfThenElseDispatch8,
     visitorStrategy: incByVisitorDispatch8,
-    patternStrategy: incByPatternDispatch8
+    patternStrategy: incByPatternDispatch8,
   }),
   Test<Base12>(12, createData12, {
     dynamicDispatchStrategy: incByDynamicDispatch12,
     ifThenElseStrategy: incByIfThenElseDispatch12,
     visitorStrategy: incByVisitorDispatch12,
-    patternStrategy: incByPatternDispatch12
+    patternStrategy: incByPatternDispatch12,
   }),
   Test<Base16>(16, createData16, {
     dynamicDispatchStrategy: incByDynamicDispatch16,
     ifThenElseStrategy: incByIfThenElseDispatch16,
     visitorStrategy: incByVisitorDispatch16,
-    patternStrategy: incByPatternDispatch16
+    patternStrategy: incByPatternDispatch16,
   }),
   Test<Base24>(24, createData24, {
     dynamicDispatchStrategy: incByDynamicDispatch24,
     ifThenElseStrategy: incByIfThenElseDispatch24,
     visitorStrategy: incByVisitorDispatch24,
-    patternStrategy: incByPatternDispatch24
+    patternStrategy: incByPatternDispatch24,
   }),
   Test<Base32>(32, createData32, {
     dynamicDispatchStrategy: incByDynamicDispatch32,
     ifThenElseStrategy: incByIfThenElseDispatch32,
     visitorStrategy: incByVisitorDispatch32,
-    patternStrategy: incByPatternDispatch32
+    patternStrategy: incByPatternDispatch32,
   }),
   Test<Base48>(48, createData48, {
     dynamicDispatchStrategy: incByDynamicDispatch48,
     ifThenElseStrategy: incByIfThenElseDispatch48,
     visitorStrategy: incByVisitorDispatch48,
-    patternStrategy: incByPatternDispatch48
+    patternStrategy: incByPatternDispatch48,
   }),
   Test<Base64>(64, createData64, {
     dynamicDispatchStrategy: incByDynamicDispatch64,
     ifThenElseStrategy: incByIfThenElseDispatch64,
     visitorStrategy: incByVisitorDispatch64,
-    patternStrategy: incByPatternDispatch64
+    patternStrategy: incByPatternDispatch64,
   }),
   Test<Base96>(96, createData96, {
     dynamicDispatchStrategy: incByDynamicDispatch96,
     ifThenElseStrategy: incByIfThenElseDispatch96,
     visitorStrategy: incByVisitorDispatch96,
-    patternStrategy: incByPatternDispatch96
+    patternStrategy: incByPatternDispatch96,
   }),
   Test<Base128>(128, createData128, {
     dynamicDispatchStrategy: incByDynamicDispatch128,
     ifThenElseStrategy: incByIfThenElseDispatch128,
     visitorStrategy: incByVisitorDispatch128,
-    patternStrategy: incByPatternDispatch128
+    patternStrategy: incByPatternDispatch128,
   }),
   Test<Base192>(192, createData192, {
     dynamicDispatchStrategy: incByDynamicDispatch192,
     ifThenElseStrategy: incByIfThenElseDispatch192,
     visitorStrategy: incByVisitorDispatch192,
-    patternStrategy: incByPatternDispatch192
+    patternStrategy: incByPatternDispatch192,
   }),
   Test<Base256>(256, createData256, {
     dynamicDispatchStrategy: incByDynamicDispatch256,
     ifThenElseStrategy: incByIfThenElseDispatch256,
     visitorStrategy: incByVisitorDispatch256,
-    patternStrategy: incByPatternDispatch256
+    patternStrategy: incByPatternDispatch256,
   }),
 ];

pkg/front_end/benchmarks/patterns/generated/datatype1.dart

@@ -39,9 +39,7 @@ class Sub0 extends Base1 {
 }
 
 List<Base1> createData1() {
-  return [
-    Sub0(),
-  ];
+  return [Sub0()];
 }
 
 void incByDynamicDispatch1(Base1 base, Counter counter) {

pkg/front_end/benchmarks/patterns/generated/datatype2.dart

@@ -63,10 +63,7 @@ class Sub1 extends Base2 {
 }
 
 List<Base2> createData2() {
-  return [
-    Sub0(),
-    Sub1(),
-  ];
+  return [Sub0(), Sub1()];
 }
 
 void incByDynamicDispatch2(Base2 base, Counter counter) {

pkg/front_end/benchmarks/patterns/generated/datatype3.dart

@@ -87,11 +87,7 @@ class Sub2 extends Base3 {
 }
 
 List<Base3> createData3() {
-  return [
-    Sub0(),
-    Sub1(),
-    Sub2(),
-  ];
+  return [Sub0(), Sub1(), Sub2()];
 }
 
 void incByDynamicDispatch3(Base3 base, Counter counter) {

pkg/front_end/benchmarks/patterns/generated/datatype4.dart

@@ -111,12 +111,7 @@ class Sub3 extends Base4 {
 }
 
 List<Base4> createData4() {
-  return [
-    Sub0(),
-    Sub1(),
-    Sub2(),
-    Sub3(),
-  ];
+  return [Sub0(), Sub1(), Sub2(), Sub3()];
 }
 
 void incByDynamicDispatch4(Base4 base, Counter counter) {

pkg/front_end/benchmarks/patterns/generated/datatype5.dart

@@ -135,13 +135,7 @@ class Sub4 extends Base5 {
 }
 
 List<Base5> createData5() {
-  return [
-    Sub0(),
-    Sub1(),
-    Sub2(),
-    Sub3(),
-    Sub4(),
-  ];
+  return [Sub0(), Sub1(), Sub2(), Sub3(), Sub4()];
 }
 
 void incByDynamicDispatch5(Base5 base, Counter counter) {

pkg/front_end/benchmarks/patterns/generated/datatype6.dart

@@ -159,14 +159,7 @@ class Sub5 extends Base6 {
 }
 
 List<Base6> createData6() {
-  return [
-    Sub0(),
-    Sub1(),
-    Sub2(),
-    Sub3(),
-    Sub4(),
-    Sub5(),
-  ];
+  return [Sub0(), Sub1(), Sub2(), Sub3(), Sub4(), Sub5()];
 }
 
 void incByDynamicDispatch6(Base6 base, Counter counter) {

pkg/front_end/benchmarks/patterns/generated/datatype7.dart

@@ -183,15 +183,7 @@ class Sub6 extends Base7 {
 }
 
 List<Base7> createData7() {
-  return [
-    Sub0(),
-    Sub1(),
-    Sub2(),
-    Sub3(),
-    Sub4(),
-    Sub5(),
-    Sub6(),
-  ];
+  return [Sub0(), Sub1(), Sub2(), Sub3(), Sub4(), Sub5(), Sub6()];
 }
 
 void incByDynamicDispatch7(Base7 base, Counter counter) {

pkg/front_end/benchmarks/patterns/generated/datatype8.dart

@@ -207,16 +207,7 @@ class Sub7 extends Base8 {
 }
 
 List<Base8> createData8() {
-  return [
-    Sub0(),
-    Sub1(),
-    Sub2(),
-    Sub3(),
-    Sub4(),
-    Sub5(),
-    Sub6(),
-    Sub7(),
-  ];
+  return [Sub0(), Sub1(), Sub2(), Sub3(), Sub4(), Sub5(), Sub6(), Sub7()];
 }
 
 void incByDynamicDispatch8(Base8 base, Counter counter) {