[ffi/tests] Cleanup lints

Change-Id: Ieac458f7d39557a49b0d0f17e1ce327cffab255c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421185
Commit-Queue: Daco Harkes <[email protected]>
Reviewed-by: Moritz Sümmermann <[email protected]>

Author: dcharkes

tests/ffi/array_compound_elements_test.dart

@@ -9,7 +9,6 @@
 // VMOptions=--use-slow-path --stacktrace-every=100
 
 import 'dart:ffi';
-import 'dart:typed_data';
 
 import 'package:expect/expect.dart';
 import 'package:ffi/ffi.dart';

tests/ffi/dylib_isolates_test.dart

@@ -6,6 +6,7 @@
 //
 // SharedObjects=ffi_test_functions
 
+import 'dart:async';
 import 'dart:ffi';
 import 'dart:io';
 import 'dart:isolate';
@@ -29,7 +30,7 @@ void main() async {
   Expect.equals(123, getGlobalVar());
 
   final receivePort = ReceivePort();
-  Isolate.spawn(secondIsolateMain, receivePort.sendPort);
+  unawaited(Isolate.spawn(secondIsolateMain, receivePort.sendPort));
   await receivePort.first;
   if (!Platform.isIOS /* Static linking causes different behavior. */ ) {
     Expect.equals(42, getGlobalVar());

tests/ffi/generator/array_primitive_elements_test_generator.dart

@@ -6,7 +6,6 @@ import 'dart:io';
 
 import 'c_types.dart';
 import 'utils.dart';
-import 'structs_by_value_tests_generator.dart';
 
 void main() async {
   final StringBuffer buffer = StringBuffer();
@@ -355,5 +354,4 @@ String typedDataListName(FundamentalType type) => switch (type) {
   float => 'Float32List',
   double_ => 'Float64List',
   FundamentalType() => '${type.dartCType}List',
-  _ => throw UnimplementedError(),
 };

tests/ffi/regress_flutter79441_test.dart

@@ -12,23 +12,13 @@ typedef _c_memset = Void Function(Pointer<Uint8>, Int32, IntPtr);
 
 _dart_memset? fbMemset;
 
-void _fallbackMemset(Pointer<Uint8> ptr, int byte, int size) {
-  final bytes = ptr.cast<Uint8>();
-  for (var i = 0; i < size; i++) {
-    bytes[i] = byte;
-  }
-}
-
 void main() {
   try {
     fbMemset = DynamicLibrary.process().lookupFunction<_c_memset, _dart_memset>(
       'memset',
     );
   } catch (_) {
-    // This works:
-    // fbMemset = _fallbackMemset;
-
-    // This doesn't: /aot/precompiler.cc: 2761: error: unreachable code
+    // /aot/precompiler.cc: 2761: error: unreachable code
     fbMemset = (Pointer<Uint8> ptr, int byte, int size) {
       final bytes = ptr.cast<Uint8>();
       for (var i = 0; i < size; i++) {

tests/ffi/regress_jump_to_frame_test.dart

@@ -38,7 +38,7 @@ typedef Dart_PropagateError_NativeType = Void Function(Handle);
 typedef Dart_PropagateError_DartType = void Function(Object);
 
 final Dart_PropagateError_DartType propagateError = () {
-  final Pointer<_DartApi> dlapi = NativeApi.initializeApiDLData.cast();
+  final dlapi = NativeApi.initializeApiDLData.cast<_DartApi>();
   for (int i = 0; dlapi.ref.functions[i].name != nullptr; i++) {
     final name = dlapi.ref.functions[i].name.cast<Utf8>().toDartString();
     if (name == 'Dart_PropagateError') {

tests/ffi/vmspecific_callback_unwind_error_through_handle_test.dart

@@ -22,18 +22,19 @@ typedef CalloutCType = Handle Function(Pointer);
 typedef CalloutDartType = Object Function(Pointer);
 
 void child(_) {
-  var callout = ffiTestFunctions.lookupFunction<CalloutCType, CalloutDartType>(
-    "TestUnwindErrorThroughHandle",
-    isLeaf: false,
-  );
-  var callback = Pointer.fromFunction<CallbackType>(unwindErrorThroughHandle);
-  var result = callout(callback);
+  final callout = ffiTestFunctions
+      .lookupFunction<CalloutCType, CalloutDartType>(
+        "TestUnwindErrorThroughHandle",
+        isLeaf: false,
+      );
+  final callback = Pointer.fromFunction<CallbackType>(unwindErrorThroughHandle);
+  callout(callback);
   throw "Should not be reached";
 }
 
 void main() {
-  var onExit = new RawReceivePort();
-  var onError = new RawReceivePort();
+  final onExit = new RawReceivePort();
+  final onError = new RawReceivePort();
   onExit.handler = ((msg) {
     print("Child exited");
     onExit.close();

tests/ffi/vmspecific_object_gc_test.dart

@@ -18,7 +18,7 @@ final triggerGc = ffiTestFunctions
     .lookupFunction<Void Function(), void Function()>("TriggerGC");
 
 void main() async {
-  testGC();
+  await testGC();
 }
 
 dynamic bar;