analyzer: Convert getPubspecVisitor to a getter named pubspecVisitor

Work towards #50986

Change-Id: I1bcdc6b32efef0f7e70bbb49c3cce046f95351fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428225
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/lint/linter.dart

@@ -63,6 +63,11 @@ sealed class AbstractAnalysisRule {
   /// The lint codes associated with this lint rule.
   List<LintCode> get lintCodes;
 
+  /// Returns a visitor that visits a [Pubspec] to perform analysis.
+  ///
+  /// Diagnostics are reported via this [LintRule]'s error [reporter].
+  PubspecVisitor? get pubspecVisitor => null;
+
   @protected
   // Protected so that lint rule visitors do not access this directly.
   // TODO(srawlins): With the new availability of an ErrorReporter on
@@ -74,12 +79,6 @@ sealed class AbstractAnalysisRule {
 
   set reporter(ErrorReporter value) => _reporter = value;
 
-  /// Returns a visitor to be passed to pubspecs to perform lint
-  /// analysis.
-  ///
-  /// Lint errors are reported via this [LintRule]'s error [reporter].
-  PubspecVisitor? getPubspecVisitor() => null;
-
   /// Registers node processors in the given [registry].
   ///
   /// The node processors may use the provided [context] to access information

pkg/analyzer/lib/src/pubspec/pubspec_validator.dart

@@ -59,7 +59,7 @@ List<Diagnostic> validatePubspec({
   if (analysisOptions != null && analysisOptions.lint) {
     var visitors = <AbstractAnalysisRule, PubspecVisitor>{};
     for (var linter in analysisOptions.lintRules) {
-      var visitor = linter.getPubspecVisitor();
+      var visitor = linter.pubspecVisitor;
       if (visitor != null) {
         visitors[linter] = visitor;
       }

pkg/linter/lib/src/rules/pub/package_names.dart

@@ -14,7 +14,7 @@ class PackageNames extends LintRule {
   LintCode get lintCode => LinterLintCode.package_names;
 
   @override
-  PubspecVisitor<void> getPubspecVisitor() => Visitor(this);
+  PubspecVisitor<void> get pubspecVisitor => Visitor(this);
 }
 
 class Visitor extends PubspecVisitor<void> {

pkg/linter/lib/src/rules/pub/secure_pubspec_urls.dart

@@ -16,7 +16,7 @@ class SecurePubspecUrls extends LintRule {
   LintCode get lintCode => LinterLintCode.secure_pubspec_urls;
 
   @override
-  PubspecVisitor<void> getPubspecVisitor() => Visitor(this);
+  PubspecVisitor<void> get pubspecVisitor => Visitor(this);
 }
 
 class Visitor extends PubspecVisitor<void> {

pkg/linter/lib/src/rules/pub/sort_pub_dependencies.dart

@@ -17,7 +17,7 @@ class SortPubDependencies extends LintRule {
   LintCode get lintCode => LinterLintCode.sort_pub_dependencies;
 
   @override
-  PubspecVisitor<void> getPubspecVisitor() => Visitor(this);
+  PubspecVisitor<void> get pubspecVisitor => Visitor(this);
 }
 
 class Visitor extends PubspecVisitor<void> {

pkg/linter/lib/src/test_utilities/test_linter.dart

@@ -58,7 +58,7 @@ class TestLinter implements AnalysisErrorListener {
     var spec = Pubspec.parse(contents, sourceUrl: sourceUrl);
 
     for (var rule in options.enabledRules) {
-      var visitor = rule.getPubspecVisitor();
+      var visitor = rule.pubspecVisitor;
       if (visitor != null) {
         // Analyzer sets reporters; if this file is not being analyzed,
         // we need to set one ourselves.  (Needless to say, when pubspec

pkg/linter/test/rule_test_support.dart

@@ -560,10 +560,9 @@ class PubPackageResolutionTest with MockPackagesMixin, ResourceProviderMixin {
   Future<List<Diagnostic>> _resolvePubspecFile(String content) async {
     var path = convertPath(testPackagePubspecPath);
     var pubspecRules = <AbstractAnalysisRule, PubspecVisitor<Object?>>{};
-    for (var rule in Registry.ruleRegistry.where(
-      (rule) => _lintRules.contains(rule.name),
-    )) {
-      var visitor = rule.getPubspecVisitor();
+    var rules = Registry.ruleRegistry.where((r) => _lintRules.contains(r.name));
+    for (var rule in rules) {
+      var visitor = rule.pubspecVisitor;
       if (visitor != null) {
         pubspecRules[rule] = visitor;
       }