[cfe] Remove ClassDeclarationBuilder

ClassDeclarationBuilder is replaced by SourceDeclarationBuilder
which is moved to its own library.

Change-Id: I9b9e641e6f8538d0611db1b994b7e0574f189af2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438121
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/kernel/kernel_target.dart

@@ -58,10 +58,10 @@ import '../builder/property_builder.dart';
 import '../builder/type_builder.dart';
 import '../dill/dill_target.dart' show DillTarget;
 import '../fragment/constructor/declaration.dart';
-import '../source/class_declaration.dart';
 import '../source/name_scheme.dart';
 import '../source/source_class_builder.dart' show SourceClassBuilder;
 import '../source/source_constructor_builder.dart';
+import '../source/source_declaration_builder.dart';
 import '../source/source_extension_type_declaration_builder.dart';
 import '../source/source_library_builder.dart' show SourceLibraryBuilder;
 import '../source/source_loader.dart'
@@ -1360,7 +1360,7 @@ class KernelTarget {
     _finishConstructors(extensionTypeDeclaration);
   }
 
-  void _finishConstructors(ClassDeclarationBuilder classDeclaration) {
+  void _finishConstructors(SourceDeclarationBuilder classDeclaration) {
     SourceLibraryBuilder libraryBuilder = classDeclaration.libraryBuilder;
 
     /// Quotes below are from [Dart Programming Language Specification, 4th

pkg/front_end/lib/src/source/class_declaration.dart

@@ -17,17 +17,12 @@ import '../builder/factory_builder.dart';
 import '../builder/library_builder.dart';
 import '../builder/type_builder.dart';
 import '../kernel/type_algorithms.dart';
+import 'source_declaration_builder.dart';
 import 'source_library_builder.dart';
 import 'source_loader.dart';
 import 'source_member_builder.dart';
 import 'source_type_parameter_builder.dart';
 
-abstract class SourceDeclarationBuilder implements IDeclarationBuilder {
-  void buildScopes(LibraryBuilder coreLibrary);
-
-  int computeDefaultTypes(ComputeDefaultTypeContext context);
-}
-
 mixin SourceDeclarationBuilderMixin
     implements DeclarationBuilderMixin, SourceDeclarationBuilder {
   @override

pkg/front_end/lib/src/source/source_builder_mixins.dart

@@ -48,12 +48,11 @@ import '../kernel/kernel_helper.dart';
 import '../kernel/type_algorithms.dart';
 import '../kernel/utils.dart' show compareProcedures;
 import 'builder_factory.dart';
-import 'class_declaration.dart';
 import 'name_scheme.dart';
 import 'name_space_builder.dart';
 import 'nominal_parameter_name_space.dart';
-import 'source_builder_mixins.dart';
 import 'source_constructor_builder.dart';
+import 'source_declaration_builder.dart';
 import 'source_factory_builder.dart';
 import 'source_library_builder.dart';
 import 'source_loader.dart';
@@ -94,10 +93,7 @@ Class initializeClass(
 }
 
 class SourceClassBuilder extends ClassBuilderImpl
-    implements
-        Comparable<SourceClassBuilder>,
-        ClassDeclarationBuilder,
-        SourceDeclarationBuilder {
+    implements Comparable<SourceClassBuilder>, SourceDeclarationBuilder {
   @override
   final SourceLibraryBuilder libraryBuilder;
 

pkg/front_end/lib/src/source/source_class_builder.dart

@@ -39,7 +39,7 @@ import 'name_space_builder.dart';
 import 'native_method_registry.dart';
 import 'offset_map.dart';
 import 'outline_builder.dart';
-import 'source_builder_mixins.dart';
+import 'source_declaration_builder.dart';
 import 'source_library_builder.dart';
 import 'source_loader.dart' show SourceLoader;
 import 'source_member_builder.dart';

pkg/front_end/lib/src/source/source_compilation_unit.dart

@@ -0,0 +1,19 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import '../builder/declaration_builders.dart';
+import '../builder/library_builder.dart';
+import '../kernel/type_algorithms.dart';
+import 'source_library_builder.dart';
+
+abstract class SourceDeclarationBuilder implements IDeclarationBuilder {
+  void buildScopes(LibraryBuilder coreLibrary);
+
+  int computeDefaultTypes(ComputeDefaultTypeContext context);
+
+  int resolveConstructors(SourceLibraryBuilder library);
+
+  @override
+  SourceLibraryBuilder get libraryBuilder;
+}

pkg/front_end/lib/src/source/source_declaration_builder.dart

@@ -289,4 +289,9 @@ class SourceExtensionBuilder extends ExtensionBuilderImpl
         isInternalImplementation: isInternalImplementation,
         kind: kind));
   }
+
+  @override
+  int resolveConstructors(SourceLibraryBuilder library) {
+    return 0;
+  }
 }

pkg/front_end/lib/src/source/source_extension_builder.dart

@@ -29,7 +29,6 @@ import '../kernel/body_builder_context.dart';
 import '../kernel/hierarchy/hierarchy_builder.dart';
 import '../kernel/kernel_helper.dart';
 import '../type_inference/type_inference_engine.dart';
-import 'class_declaration.dart';
 import 'name_scheme.dart';
 import 'name_space_builder.dart';
 import 'source_builder_mixins.dart';
@@ -43,9 +42,7 @@ import 'source_type_parameter_builder.dart';
 class SourceExtensionTypeDeclarationBuilder
     extends ExtensionTypeDeclarationBuilderImpl
     with SourceDeclarationBuilderMixin
-    implements
-        Comparable<SourceExtensionTypeDeclarationBuilder>,
-        ClassDeclarationBuilder {
+    implements Comparable<SourceExtensionTypeDeclarationBuilder> {
   @override
   final SourceLibraryBuilder parent;
 

pkg/front_end/lib/src/source/source_extension_type_declaration_builder.dart

@@ -50,11 +50,10 @@ import '../kernel/utils.dart'
         exportDynamicSentinel,
         exportNeverSentinel,
         unserializableExportName;
-import 'class_declaration.dart';
 import 'name_scheme.dart';
 import 'name_space_builder.dart';
-import 'source_builder_mixins.dart';
 import 'source_class_builder.dart' show SourceClassBuilder;
+import 'source_declaration_builder.dart';
 import 'source_extension_builder.dart';
 import 'source_extension_type_declaration_builder.dart';
 import 'source_factory_builder.dart';
@@ -708,10 +707,10 @@ class SourceLibraryBuilder extends LibraryBuilderImpl {
   /// return the number of constructors resolved.
   int resolveConstructors() {
     int count = 0;
-    Iterator<ClassDeclarationBuilder> iterator =
+    Iterator<SourceDeclarationBuilder> iterator =
         filteredMembersIterator(includeDuplicates: true);
     while (iterator.moveNext()) {
-      ClassDeclarationBuilder builder = iterator.current;
+      SourceDeclarationBuilder builder = iterator.current;
       count += builder.resolveConstructors(this);
     }
     return count;

pkg/front_end/lib/src/source/source_library_builder.dart

@@ -995,7 +995,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/source/source_extension_builder.dart": (
-    hitCount: 152,
+    hitCount: 153,
     missCount: 0,
   ),
   // 100.0%.