Skip to content

Commit dbc16b3

Browse files
jensjohaCommit Queue
authored andcommitted
[analysis_server] Fix collect report returning 500 because of a crash on json convert
After 816b974 the download report on "Analysis Server Diagnostics" did not work. Change-Id: I14f2525730772f7cf72a7a9c622ae3094602766a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434680 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Jens Johansen <[email protected]>
1 parent 2b24d38 commit dbc16b3

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/analysis_server/lib/src/status/pages/collect_report_page.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,10 @@ class CollectReportPage extends DiagnosticPage {
166166
for (var cycle in cycles) {
167167
cycleData[cycle.size] = (cycleData[cycle.size] ?? 0) + 1;
168168
}
169-
var sortedCycleData = <int, int>{};
169+
// Json maps need string keys.
170+
var sortedCycleData = <String, int>{};
170171
for (var size in cycleData.keys.toList()..sort()) {
171-
sortedCycleData[size] = cycleData[size]!;
172+
sortedCycleData['$size'] = cycleData[size]!;
172173
}
173174
contextData['libraryCycleData'] = sortedCycleData;
174175
}

0 commit comments

Comments
 (0)