[front_end] Add withArguments to Template class.

The CFE `Template` class now exposes a `withArguments` method, which
behaves the same as `withArgumetsOld` method, but accepts named
arguments rather than positional arguments.

In follow-up CLs, I will adjust the names of these positional
parameters to be more descriptive, and update call sites to use
`withArguments` rather than `withArgumentsOld`. This should make the
call sites clearer and easier to understand.

Change-Id: I6a6a6964638e0312003aa622c5e0fef782b8d979
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447963
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/_fe_analyzer_shared/lib/src/messages/codes.dart

@@ -107,20 +107,23 @@ class MessageCode extends Code implements Message {
   }
 }
 
-class Template<T> extends Code {
+class Template<TOld extends Function, T extends Function> extends Code {
   String get messageCode => name;
 
   final String problemMessageTemplate;
 
   final String? correctionMessageTemplate;
 
-  final T withArgumentsOld;
+  final TOld withArgumentsOld;
+
+  final T withArguments;
 
   const Template(
     super.name, {
     this.correctionMessageTemplate,
     required this.problemMessageTemplate,
     required this.withArgumentsOld,
+    required this.withArguments,
     super.index = -1,
     super.analyzerCodes,
     super.severity = CfeSeverity.error,

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -10,7 +10,7 @@ class BlockKind {
 
   final codes.Message? message;
 
-  final codes.Template<codes.Message Function(Token token)>? template;
+  final codes.Template<codes.Message Function(Token token), Function>? template;
 
   const BlockKind._(this.name, {this.template, this.message});
 

pkg/_fe_analyzer_shared/lib/src/parser/block_kind.dart

@@ -289,7 +289,7 @@ abstract class IdentifierContext {
   /// expressions are required.
   final bool allowedInConstantExpression;
 
-  final Template<_MessageWithArgument<Token>> recoveryTemplate;
+  final Template<_MessageWithArgument<Token>, Function> recoveryTemplate;
 
   const IdentifierContext(
     this._name, {

pkg/_fe_analyzer_shared/lib/src/parser/identifier_context.dart

@@ -4609,7 +4609,7 @@ class Parser {
   Token ensureBlock(Token token, BlockKind? missingBlockKind) {
     Token next = token.next!;
     if (next.isA(TokenType.OPEN_CURLY_BRACKET)) return next;
-    codes.Template<codes.Message Function(Token token)>? template =
+    codes.Template<codes.Message Function(Token token), Function>? template =
         missingBlockKind?.template;
     if (template == null) {
       codes.Message? message = missingBlockKind?.message;
@@ -10795,7 +10795,7 @@ class Parser {
 
   void reportRecoverableErrorWithToken(
     Token token,
-    codes.Template<_MessageWithArgument<Token>> template,
+    codes.Template<_MessageWithArgument<Token>, Function> template,
   ) {
     // Find a non-synthetic token on which to report the error.
     token = findNonZeroLengthToken(token);

pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart

@@ -303,9 +303,8 @@ abstract class NamedTypeBuilderImpl extends NamedTypeBuilder {
     if (member is TypeDeclarationBuilder) {
       bind(problemReporting, member);
     } else {
-      Template<Message Function(String name)> template = member == null
-          ? codeTypeNotFound
-          : codeNotAType;
+      Template<Message Function(String name), Function> template =
+          member == null ? codeTypeNotFound : codeNotAType;
       String nameText = typeName.fullName;
       int nameOffset = typeName.fullNameOffset;
       int nameLength = typeName.fullNameLength;
@@ -459,7 +458,7 @@ abstract class NamedTypeBuilderImpl extends NamedTypeBuilder {
   }
 
   Supertype? _handleInvalidSupertype(LibraryBuilder library) {
-    Template<Message Function(String name)> template =
+    Template<Message Function(String name), Function> template =
         declaration.isTypeParameter
         ? codeSupertypeIsTypeParameter
         : codeSupertypeIsIllegal;