[model] Report error on void arguments of dynamic types in Analyzer

Closes flutter/flutter#161479

Change-Id: I6657e93dc609566fb5c11d85918e37e2da8744d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448861
Reviewed-by: Paul Berry <[email protected]>

Author: chloestefantsova

pkg/analyzer/lib/src/generated/error_detection_helpers.dart

@@ -69,14 +69,34 @@ mixin ErrorDetectionHelpers {
     bool promoteParameterToNullable = false,
     Map<SharedTypeView, NonPromotionReason> Function()? whyNotPromoted,
   }) {
-    _checkForArgumentTypeNotAssignableForArgument(
-      argument: argument is NamedExpressionImpl
-          ? argument.expression
-          : argument,
-      parameter: argument.correspondingParameter,
-      promoteParameterToNullable: promoteParameterToNullable,
-      whyNotPromoted: whyNotPromoted,
-    );
+    var parameter = argument.correspondingParameter;
+    TypeImpl? correspondingParameterType;
+    if (parameter != null) {
+      correspondingParameterType = parameter.type;
+    } else if (argument.parent
+        case ArgumentListImpl(
+          parent: FunctionExpressionInvocationImpl(
+            function: Expression(:var staticType),
+          ),
+        )
+        when identical(staticType, DynamicTypeImpl.instance) ||
+            identical(staticType, NeverTypeImpl.instance) ||
+            staticType is InterfaceTypeImpl && staticType.isDartCoreFunction) {
+      // Treat dynamic invocations as having function types where all formal
+      // parameter types are 'dynamic'.
+      correspondingParameterType = DynamicTypeImpl.instance;
+    }
+
+    if (correspondingParameterType != null) {
+      _checkForArgumentTypeNotAssignableForArgument(
+        argument: argument is NamedExpressionImpl
+            ? argument.expression
+            : argument,
+        staticParameterType: correspondingParameterType,
+        promoteParameterToNullable: promoteParameterToNullable,
+        whyNotPromoted: whyNotPromoted,
+      );
+    }
   }
 
   void checkForAssignableExpressionAtType(
@@ -297,7 +317,7 @@ mixin ErrorDetectionHelpers {
       if (parameters.isNotEmpty) {
         _checkForArgumentTypeNotAssignableForArgument(
           argument: index,
-          parameter: parameters[0],
+          staticParameterType: parameters[0].type,
           promoteParameterToNullable: false,
           whyNotPromoted: whyNotPromoted,
         );
@@ -309,7 +329,7 @@ mixin ErrorDetectionHelpers {
       if (parameters.isNotEmpty) {
         _checkForArgumentTypeNotAssignableForArgument(
           argument: index,
-          parameter: parameters[0],
+          staticParameterType: parameters[0].type,
           promoteParameterToNullable: false,
           whyNotPromoted: whyNotPromoted,
         );
@@ -389,22 +409,19 @@ mixin ErrorDetectionHelpers {
 
   void _checkForArgumentTypeNotAssignableForArgument({
     required Expression argument,
-    required InternalFormalParameterElement? parameter,
+    required TypeImpl staticParameterType,
     required bool promoteParameterToNullable,
     Map<SharedTypeView, NonPromotionReason> Function()? whyNotPromoted,
   }) {
-    var staticParameterType = parameter?.type;
-    if (staticParameterType != null) {
-      if (promoteParameterToNullable) {
-        staticParameterType = typeSystem.makeNullable(staticParameterType);
-      }
-      checkForArgumentTypeNotAssignable(
-        argument,
-        staticParameterType,
-        argument.typeOrThrow,
-        CompileTimeErrorCode.argumentTypeNotAssignable,
-        whyNotPromoted: whyNotPromoted,
-      );
+    if (promoteParameterToNullable) {
+      staticParameterType = typeSystem.makeNullable(staticParameterType);
     }
+    checkForArgumentTypeNotAssignable(
+      argument,
+      staticParameterType,
+      argument.typeOrThrow,
+      CompileTimeErrorCode.argumentTypeNotAssignable,
+      whyNotPromoted: whyNotPromoted,
+    );
   }
 }

tests/language/void/issue_flutter_161479_test.dart

@@ -0,0 +1,33 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+abstract class A {
+  Function get fooFunction;
+  dynamic get fooDynamic;
+  void fooRegular(Object? arg);
+  Never get fooNever;
+
+  void bar() {}
+
+  test() {
+    fooFunction(bar());
+    //          ^^^
+    // [analyzer] COMPILE_TIME_ERROR.USE_OF_VOID_RESULT
+    // [cfe] This expression has type 'void' and can't be used.
+    fooDynamic(bar());
+    //         ^^^
+    // [analyzer] COMPILE_TIME_ERROR.USE_OF_VOID_RESULT
+    // [cfe] This expression has type 'void' and can't be used.
+    fooRegular(bar());
+    //         ^^^
+    // [analyzer] COMPILE_TIME_ERROR.USE_OF_VOID_RESULT
+    // [cfe] This expression has type 'void' and can't be used.
+    fooNever(bar());
+    //       ^^^
+    // [analyzer] COMPILE_TIME_ERROR.USE_OF_VOID_RESULT
+    // [cfe] This expression has type 'void' and can't be used.
+  }
+}
+
+void main() {}