lib: drop unnecessary new and const

CoreLibraryReviewExempt: no API changes
TEST=no behavior changes
Change-Id: Ibef80bbfb000026042e562014b672258a5f1860d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419761
Reviewed-by: Lasse Nielsen <[email protected]>
Reviewed-by: Liam Appelbe <[email protected]>
Commit-Queue: Kevin Moore <[email protected]>

Author: kevmoo

sdk/lib/_internal/vm/bin/builtin.dart

@@ -189,7 +189,7 @@ void _requestPackagesMap(Uri? packageConfig) {
     assert(msg.length >= 2);
     assert(msg[1] == null);
     _packageConfig = Uri.parse(msg[0]);
-    final pmap = new Map<String, Uri>();
+    final pmap = Map<String, Uri>();
     _packageMap = pmap;
     for (var i = 2; i < msg.length; i += 2) {
       // TODO(iposva): Complain about duplicate entries.
@@ -335,7 +335,7 @@ _findPackagesConfiguration(bool traceLoading, Uri base) {
     // of
     //   - .packages (preferred)
     //   - .dart_tool/package_config.json
-    var currentDir = new File.fromUri(base).parent;
+    var currentDir = File.fromUri(base).parent;
     while (true) {
       final dirUri = currentDir.uri;
 
@@ -497,7 +497,7 @@ void _Init(
   _setupHooks();
 
   // _workingDirectory must be set first.
-  _workingDirectory = new Uri.directory(workingDirectory);
+  _workingDirectory = Uri.directory(workingDirectory);
 
   // setup _rootScript.
   if (rootScript != null) {
@@ -521,7 +521,7 @@ void _setWorkingDirectory(String cwd) {
   if (_traceLoading) {
     _log('Setting working directory: $cwd');
   }
-  _workingDirectory = new Uri.directory(cwd);
+  _workingDirectory = Uri.directory(cwd);
   if (_traceLoading) {
     _log('Working directory URI: $_workingDirectory');
   }

sdk/lib/_internal/vm/bin/directory_patch.dart

@@ -53,15 +53,15 @@ class _Directory {
 class _AsyncDirectoryListerOps {
   @patch
   factory _AsyncDirectoryListerOps(int pointer) =>
-      new _AsyncDirectoryListerOpsImpl(pointer);
+      _AsyncDirectoryListerOpsImpl(pointer);
 }
 
 base class _AsyncDirectoryListerOpsImpl extends NativeFieldWrapperClass1
     implements _AsyncDirectoryListerOps {
   _AsyncDirectoryListerOpsImpl._();
 
   factory _AsyncDirectoryListerOpsImpl(int pointer) =>
-      new _AsyncDirectoryListerOpsImpl._().._setPointer(pointer);
+      _AsyncDirectoryListerOpsImpl._().._setPointer(pointer);
 
   @pragma("vm:external-name", "Directory_SetAsyncDirectoryListerPointer")
   external void _setPointer(int pointer);
@@ -79,13 +79,13 @@ Uri _uriBaseClosure() {
   }
   var result = _Directory._current(_Namespace._namespace);
   if (result is OSError) {
-    throw new FileSystemException._fromOSError(
+    throw FileSystemException._fromOSError(
       result,
       "Getting current working directory failed",
       "",
     );
   }
-  return new Uri.directory(result as String);
+  return Uri.directory(result as String);
 }
 
 @pragma("vm:entry-point", "call")

sdk/lib/_internal/vm/bin/file_patch.dart

@@ -91,7 +91,7 @@ class _File {
 class _RandomAccessFileOps {
   @patch
   factory _RandomAccessFileOps(int pointer) =>
-      new _RandomAccessFileOpsImpl(pointer);
+      _RandomAccessFileOpsImpl(pointer);
 }
 
 @pragma("vm:entry-point")
@@ -100,7 +100,7 @@ base class _RandomAccessFileOpsImpl extends NativeFieldWrapperClass1
   _RandomAccessFileOpsImpl._();
 
   factory _RandomAccessFileOpsImpl(int pointer) =>
-      new _RandomAccessFileOpsImpl._().._setPointer(pointer);
+      _RandomAccessFileOpsImpl._().._setPointer(pointer);
 
   @pragma("vm:external-name", "File_SetPointer")
   external void _setPointer(int pointer);
@@ -156,7 +156,7 @@ abstract class _FileSystemWatcher {
   _WatcherPath? _watcherPath;
 
   final StreamController<FileSystemEvent> _broadcastController =
-      new StreamController<FileSystemEvent>.broadcast();
+      StreamController<FileSystemEvent>.broadcast();
 
   /// Subscription on the stream returned by [_watchPath].
   ///
@@ -171,26 +171,22 @@ abstract class _FileSystemWatcher {
     bool recursive,
   ) {
     if (Platform.isLinux || Platform.isAndroid) {
-      return new _InotifyFileSystemWatcher(path, events, recursive)._stream;
+      return _InotifyFileSystemWatcher(path, events, recursive)._stream;
     }
     if (Platform.isWindows) {
-      return new _Win32FileSystemWatcher(path, events, recursive)._stream;
+      return _Win32FileSystemWatcher(path, events, recursive)._stream;
     }
     if (Platform.isMacOS) {
-      return new _FSEventStreamFileSystemWatcher(
-        path,
-        events,
-        recursive,
-      )._stream;
+      return _FSEventStreamFileSystemWatcher(path, events, recursive)._stream;
     }
-    throw new FileSystemException(
+    throw FileSystemException(
       "File system watching is not supported on this platform",
     );
   }
 
   _FileSystemWatcher._(this._path, this._events, this._recursive) {
     if (!isSupported) {
-      throw new FileSystemException(
+      throw FileSystemException(
         "File system watching is not supported on this platform",
         _path,
       );
@@ -236,7 +232,7 @@ abstract class _FileSystemWatcher {
       return;
     }
     if (!_idMap.containsKey(pathId)) {
-      _idMap[pathId] = new _WatcherPath(pathId, _path, _events);
+      _idMap[pathId] = _WatcherPath(pathId, _path, _events);
     }
     _watcherPath = _idMap[pathId];
     _watcherPath!.count++;
@@ -324,9 +320,9 @@ abstract class _FileSystemWatcher {
 
         void rewriteMove(event, isDir) {
           if (event[3]) {
-            add(event[4], new FileSystemCreateEvent(getPath(event), isDir));
+            add(event[4], FileSystemCreateEvent(getPath(event), isDir));
           } else {
-            add(event[4], new FileSystemDeleteEvent(getPath(event), false));
+            add(event[4], FileSystemDeleteEvent(getPath(event), false));
           }
         }
 
@@ -344,13 +340,13 @@ abstract class _FileSystemWatcher {
             bool isDir = getIsDir(event);
             var path = getPath(event);
             if ((event[0] & FileSystemEvent.create) != 0) {
-              add(event[4], new FileSystemCreateEvent(path, isDir));
+              add(event[4], FileSystemCreateEvent(path, isDir));
             }
             if ((event[0] & FileSystemEvent.modify) != 0) {
-              add(event[4], new FileSystemModifyEvent(path, isDir, true));
+              add(event[4], FileSystemModifyEvent(path, isDir, true));
             }
             if ((event[0] & FileSystemEvent._modifyAttributes) != 0) {
-              add(event[4], new FileSystemModifyEvent(path, isDir, false));
+              add(event[4], FileSystemModifyEvent(path, isDir, false));
             }
             if ((event[0] & FileSystemEvent.move) != 0) {
               int link = event[1];
@@ -359,7 +355,7 @@ abstract class _FileSystemWatcher {
                 if (pair[pathId].containsKey(link)) {
                   add(
                     event[4],
-                    new FileSystemMoveEvent(
+                    FileSystemMoveEvent(
                       getPath(pair[pathId][link]),
                       isDir,
                       path,
@@ -374,10 +370,10 @@ abstract class _FileSystemWatcher {
               }
             }
             if ((event[0] & FileSystemEvent.delete) != 0) {
-              add(event[4], new FileSystemDeleteEvent(path, false));
+              add(event[4], FileSystemDeleteEvent(path, false));
             }
             if ((event[0] & FileSystemEvent._deleteSelf) != 0) {
-              add(event[4], new FileSystemDeleteEvent(path, false));
+              add(event[4], FileSystemDeleteEvent(path, false));
               // Signal done event.
               stops.add([event[4], null]);
             }
@@ -479,7 +475,7 @@ class _InotifyFileSystemWatcher extends _FileSystemWatcher {
   Stream<FileSystemEvent> _pathWatched() {
     var pathId = _watcherPath!.pathId;
     if (!_idMap.containsKey(pathId)) {
-      _idMap[pathId] = new StreamController<FileSystemEvent>.broadcast();
+      _idMap[pathId] = StreamController<FileSystemEvent>.broadcast();
     }
     return _idMap[pathId]!.stream;
   }
@@ -501,7 +497,7 @@ class _Win32FileSystemWatcher extends _FileSystemWatcher {
 
   Stream<FileSystemEvent> _pathWatched() {
     var pathId = _watcherPath!.pathId;
-    _controller = new StreamController<FileSystemEvent>();
+    _controller = StreamController<FileSystemEvent>();
     _subscription = _FileSystemWatcher._listenOnSocket(
       pathId,
       0,
@@ -533,7 +529,7 @@ class _FSEventStreamFileSystemWatcher extends _FileSystemWatcher {
   Stream<FileSystemEvent> _pathWatched() {
     var pathId = _watcherPath!.pathId;
     var socketId = _FileSystemWatcher._getSocketId(0, pathId);
-    _controller = new StreamController<FileSystemEvent>();
+    _controller = StreamController<FileSystemEvent>();
     _subscription = _FileSystemWatcher._listenOnSocket(
       socketId,
       0,
@@ -556,5 +552,5 @@ class _FSEventStreamFileSystemWatcher extends _FileSystemWatcher {
 
 @pragma("vm:entry-point", "call")
 Uint8List _makeUint8ListView(Uint8List source, int offsetInBytes, int length) {
-  return new Uint8List.view(source.buffer, offsetInBytes, length);
+  return Uint8List.view(source.buffer, offsetInBytes, length);
 }

sdk/lib/_internal/vm/bin/filter_patch.dart

@@ -66,7 +66,7 @@ class RawZLibFilter {
     int strategy,
     List<int>? dictionary,
     bool raw,
-  ) => new _ZLibDeflateFilter(
+  ) => _ZLibDeflateFilter(
     gzip,
     level,
     windowBits,
@@ -81,5 +81,5 @@ class RawZLibFilter {
     int windowBits,
     List<int>? dictionary,
     bool raw,
-  ) => new _ZLibInflateFilter(gzip, windowBits, dictionary, raw);
+  ) => _ZLibInflateFilter(gzip, windowBits, dictionary, raw);
 }

sdk/lib/_internal/vm/bin/io_service_patch.dart

@@ -17,7 +17,7 @@ class _IOService {
     assert(data.length == 2);
     _forwardResponse(data[0] as int, data[1]);
   }, 'IO Service');
-  static HashMap<int, Completer> _messageMap = new HashMap<int, Completer>();
+  static HashMap<int, Completer> _messageMap = HashMap<int, Completer>();
   static int _id = 0;
 
   @patch
@@ -26,7 +26,7 @@ class _IOService {
     do {
       id = _getNextId();
     } while (_messageMap.containsKey(id));
-    final Completer completer = new Completer();
+    final Completer completer = Completer();
     try {
       if (_messageMap.isEmpty) {
         // This is the first outgoing request after being in an idle state,

sdk/lib/_internal/vm/bin/namespace_patch.dart

@@ -20,14 +20,14 @@ base class _NamespaceImpl extends NativeFieldWrapperClass1
   // embedder with the platform-specific namespace information.
   static _NamespaceImpl? _cachedNamespace = null;
   static void _setupNamespace(var namespace) {
-    _cachedNamespace = _create(new _NamespaceImpl._(), namespace);
+    _cachedNamespace = _create(_NamespaceImpl._(), namespace);
   }
 
   static _NamespaceImpl get _namespace {
     if (_cachedNamespace == null) {
       // The embedder has not supplied a namespace before one is needed, so
       // instead use a safe-ish default value.
-      _cachedNamespace = _create(new _NamespaceImpl._(), _getDefault());
+      _cachedNamespace = _create(_NamespaceImpl._(), _getDefault());
     }
     return _cachedNamespace!;
   }

sdk/lib/_internal/vm/bin/platform_patch.dart

@@ -60,7 +60,7 @@ class _Platform {
           path.startsWith('file:')) {
         return Uri.parse(path);
       } else {
-        return Uri.base.resolveUri(new Uri.file(path));
+        return Uri.base.resolveUri(Uri.file(path));
       }
     });
   }