[vm,dyn_modules] Avoid allocating large arrays in NewSpace

TEST=ci (co19/LibTest/collection/ListBase/ListBase_class_A01_t04)

Change-Id: I763897e7e850e9e3f683bd88410311bb2d075a4e
Cq-Include-Trybots: luci.dart.try:vm-aot-dyn-linux-debug-x64-try,vm-aot-dyn-linux-product-x64-try,vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447760
Reviewed-by: Ryan Macnak <[email protected]>
Reviewed-by: Tess Strickland <[email protected]>
Commit-Queue: Alexander Markov <[email protected]>

Author: alexmarkov

runtime/vm/interpreter.cc

@@ -260,6 +260,7 @@ DART_FORCE_INLINE static bool TryAllocate(Thread* thread,
                                           ObjectPtr* result) {
   ASSERT(instance_size > 0);
   ASSERT(Utils::IsAligned(instance_size, kObjectAlignment));
+  ASSERT(IsAllocatableInNewSpace(instance_size));
 
   const uword top = thread->top();
   const intptr_t remaining = thread->end() - top;
@@ -1532,7 +1533,9 @@ bool Interpreter::AllocateArray(Thread* thread,
                                 ObjectPtr* SP) {
   if (LIKELY(!length_object->IsHeapObject())) {
     const intptr_t length = Smi::Value(Smi::RawCast(length_object));
-    if (LIKELY(Array::IsValidLength(length))) {
+    if (LIKELY(static_cast<uintptr_t>(length) <=
+               static_cast<uintptr_t>(Array::kMaxNewSpaceElements))) {
+      ASSERT(Array::IsValidLength(length));
       ArrayPtr result;
       if (TryAllocate(thread, kArrayCid, Array::InstanceSize(length),
                       reinterpret_cast<ObjectPtr*>(&result))) {