[analyzer] Dot shorthands: Report error for using enum constructor.

Added an additional error check for `CompileTimeErrorCode.INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR`. Refactored the helper slightly to allow dot shorthand constructor invocations to be able to use it.

Added a unit test.

Bug: #59835
Change-Id: I4eee2a3464913cdba0e213aa47a29faad2141937
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428222
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: kallentu

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -628,7 +628,10 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
   @override
   void visitConstructorReference(covariant ConstructorReferenceImpl node) {
     _typeArgumentsVerifier.checkConstructorReference(node);
-    _checkForInvalidGenerativeConstructorReference(node.constructorName);
+    _checkForInvalidGenerativeConstructorReference(
+      node.constructorName,
+      node.constructorName.element,
+    );
   }
 
   @override
@@ -650,11 +653,14 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
   void visitDotShorthandConstructorInvocation(
     DotShorthandConstructorInvocation node,
   ) {
-    if (node.isConst) {
-      _checkForConstWithNonConst(
-        node,
-        node.constructorName.element as ConstructorElement?,
-        node.constKeyword,
+    var constructorElement = node.constructorName.element;
+    if (constructorElement is ConstructorElement?) {
+      if (node.isConst) {
+        _checkForConstWithNonConst(node, constructorElement, node.constKeyword);
+      }
+      _checkForInvalidGenerativeConstructorReference(
+        node.constructorName,
+        constructorElement,
       );
     }
     _requiredParametersVerifier.visitDotShorthandConstructorInvocation(node);
@@ -1096,7 +1102,10 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
     DartType type = namedType.typeOrThrow;
     if (type is InterfaceType) {
       _checkForConstOrNewWithAbstractClass(node, namedType, type);
-      _checkForInvalidGenerativeConstructorReference(constructorName);
+      _checkForInvalidGenerativeConstructorReference(
+        constructorName,
+        constructorName.element,
+      );
       _checkForConstOrNewWithMixin(node, namedType, type);
       _requiredParametersVerifier.visitInstanceCreationExpression(node);
       _constArgumentsVerifier.visitInstanceCreationExpression(node);
@@ -3823,8 +3832,12 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
     }
   }
 
-  void _checkForInvalidGenerativeConstructorReference(ConstructorName node) {
-    var constructorElement = node.element;
+  /// Verify that we're not using an enum constructor anywhere other than to
+  /// create an enum constant or as a target of constructor redirection.
+  void _checkForInvalidGenerativeConstructorReference(
+    AstNode node,
+    ConstructorElement? constructorElement,
+  ) {
     if (constructorElement != null &&
         constructorElement.isGenerative &&
         constructorElement.enclosingElement is EnumElement) {
@@ -3834,7 +3847,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
           CompileTimeErrorCode.INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR,
         );
       } else {
-        errorReporter.atNode(node.type, CompileTimeErrorCode.INSTANTIATE_ENUM);
+        errorReporter.atNode(node, CompileTimeErrorCode.INSTANTIATE_ENUM);
       }
     }
   }
@@ -5029,7 +5042,10 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
         arguments: [constructorStrName, redirectedClass.name3!],
       );
     }
-    _checkForInvalidGenerativeConstructorReference(redirectedConstructor);
+    _checkForInvalidGenerativeConstructorReference(
+      redirectedConstructor,
+      redirectedElement,
+    );
   }
 
   /// Check whether the redirecting constructor, [element], is const, and

pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart

@@ -342,6 +342,30 @@ DotShorthandConstructorInvocation
 ''');
   }
 
+  test_enum_constructor() async {
+    await assertErrorsInCode(
+      r'''
+enum E {
+  v.named();
+
+  const E.named();
+}
+
+void f() {
+  E e = .named();
+  print(e);
+}
+''',
+      [
+        error(
+          CompileTimeErrorCode.INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR,
+          65,
+          5,
+        ),
+      ],
+    );
+  }
+
   test_equality() async {
     await assertNoErrorsInCode(r'''
 class C {