Skip to content

Commit dfb20b1

Browse files
scheglovCommit Queue
scheglov
authored and
Commit Queue
committed
Augment. Disable most element model, resolution, diagnoatics tests.
Because we don't have short term plans to implement it, but do have strong need to finish element model migration, I decided to comment these out, as many as possible in one CL. So that they don't get in the way of migrating off of V1 element model. Change-Id: I8b56de999a41716a9140d0a12a2c36ad342d313a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413522 Reviewed-by: Paul Berry <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent 4967abb commit dfb20b1

File tree

62 files changed

+242
-30
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+242
-30
lines changed

‎pkg/analyzer/test/src/dart/resolution/assignment_test.dart‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1841,6 +1841,7 @@ AssignmentExpression
18411841
''');
18421842
}
18431843

1844+
@SkippedTest() // TODO(scheglov): implement augmentation
18441845
test_prefixedIdentifier_ofClass_getterAugmentationDeclares() async {
18451846
newFile('$testPackageLibPath/a.dart', r'''
18461847
part of 'test.dart'
@@ -1897,6 +1898,7 @@ AssignmentExpression
18971898
''');
18981899
}
18991900

1901+
@SkippedTest() // TODO(scheglov): implement augmentation
19001902
test_prefixedIdentifier_ofClass_setterAugmentationAugments() async {
19011903
newFile('$testPackageLibPath/a.dart', r'''
19021904
part of 'test.dart'
@@ -1953,6 +1955,7 @@ AssignmentExpression
19531955
''');
19541956
}
19551957

1958+
@SkippedTest() // TODO(scheglov): implement augmentation
19561959
test_prefixedIdentifier_ofClass_setterAugmentationDeclares() async {
19571960
newFile('$testPackageLibPath/a.dart', r'''
19581961
part of 'test.dart'
@@ -2006,6 +2009,7 @@ AssignmentExpression
20062009
''');
20072010
}
20082011

2012+
@SkippedTest() // TODO(scheglov): implement augmentation
20092013
test_prefixedIdentifier_ofClassName_getterAugmentationDeclares() async {
20102014
newFile('$testPackageLibPath/a.dart', r'''
20112015
part of 'test.dart'
@@ -2062,6 +2066,7 @@ AssignmentExpression
20622066
''');
20632067
}
20642068

2069+
@SkippedTest() // TODO(scheglov): implement augmentation
20652070
test_prefixedIdentifier_ofClassName_setterAugmentationAugments() async {
20662071
newFile('$testPackageLibPath/a.dart', r'''
20672072
part of 'test.dart'
@@ -2118,6 +2123,7 @@ AssignmentExpression
21182123
''');
21192124
}
21202125

2126+
@SkippedTest() // TODO(scheglov): implement augmentation
21212127
test_prefixedIdentifier_ofClassName_setterAugmentationDeclares() async {
21222128
newFile('$testPackageLibPath/a.dart', r'''
21232129
part of 'test.dart'
@@ -2171,6 +2177,7 @@ AssignmentExpression
21712177
''');
21722178
}
21732179

2180+
@SkippedTest() // TODO(scheglov): implement augmentation
21742181
test_prefixedIdentifier_ofExtensionName_augmentationAugments() async {
21752182
await assertNoErrorsInCode(r'''
21762183
extension A on int {
@@ -2222,6 +2229,7 @@ AssignmentExpression
22222229
''');
22232230
}
22242231

2232+
@SkippedTest() // TODO(scheglov): implement augmentation
22252233
test_prefixedIdentifier_ofExtensionName_augmentationDeclares() async {
22262234
await assertNoErrorsInCode(r'''
22272235
extension A on int {}
@@ -2865,6 +2873,7 @@ AssignmentExpression
28652873
''');
28662874
}
28672875

2876+
@SkippedTest() // TODO(scheglov): implement augmentation
28682877
test_propertyAccess_ofClass_setterAugmentationAugments() async {
28692878
newFile('$testPackageLibPath/a.dart', r'''
28702879
part of 'test.dart'
@@ -2923,6 +2932,7 @@ AssignmentExpression
29232932
''');
29242933
}
29252934

2935+
@SkippedTest() // TODO(scheglov): implement augmentation
29262936
test_propertyAccess_ofClass_setterAugmentationDeclares() async {
29272937
newFile('$testPackageLibPath/a.dart', r'''
29282938
part of 'test.dart'

‎pkg/analyzer/test/src/dart/resolution/augmented_expression_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import 'context_collection_resolution.dart';
99

1010
main() {
1111
defineReflectiveSuite(() {
12-
defineReflectiveTests(AugmentedExpressionResolutionTest);
12+
// TODO(scheglov): implement augmentation
13+
// defineReflectiveTests(AugmentedExpressionResolutionTest);
1314
});
1415
}
1516

‎pkg/analyzer/test/src/dart/resolution/augmented_invocation_test.dart‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import 'context_collection_resolution.dart';
99

1010
main() {
1111
defineReflectiveSuite(() {
12-
defineReflectiveTests(AugmentedInvocationResolutionTest);
12+
// TODO(scheglov): implement augmentation
13+
// defineReflectiveTests(AugmentedInvocationResolutionTest);
1314
});
1415
}
1516

‎pkg/analyzer/test/src/dart/resolution/binary_expression_test.dart‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,7 @@ BinaryExpression
430430
''');
431431
}
432432

433+
@SkippedTest() // TODO(scheglov): implement augmentation
433434
test_plus_augmentedExpression_augments_plus() async {
434435
newFile('$testPackageLibPath/a.dart', r'''
435436
part 'test.dart';
@@ -470,6 +471,7 @@ BinaryExpression
470471
''');
471472
}
472473

474+
@SkippedTest() // TODO(scheglov): implement augmentation
473475
test_plus_augmentedExpression_augments_unaryMinus() async {
474476
newFile('$testPackageLibPath/a.dart', r'''
475477
part 'test.dart';
@@ -511,6 +513,7 @@ BinaryExpression
511513
''');
512514
}
513515

516+
@SkippedTest() // TODO(scheglov): implement augmentation
514517
test_plus_augmentedExpression_class_field() async {
515518
newFile('$testPackageLibPath/a.dart', r'''
516519
part 'test.dart';
@@ -548,6 +551,7 @@ BinaryExpression
548551
''');
549552
}
550553

554+
@SkippedTest() // TODO(scheglov): implement augmentation
551555
test_plus_augmentedExpression_getter() async {
552556
newFile('$testPackageLibPath/a.dart', r'''
553557
part 'test.dart';
@@ -587,6 +591,7 @@ BinaryExpression
587591
''');
588592
}
589593

594+
@SkippedTest() // TODO(scheglov): implement augmentation
590595
test_plus_augmentedExpression_setter() async {
591596
newFile('$testPackageLibPath/a.dart', r'''
592597
part 'test.dart';

‎pkg/analyzer/test/src/dart/resolution/constructor_field_initializer_test.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ main() {
1616
@reflectiveTest
1717
class ConstructorFieldInitializerResolutionTest
1818
extends PubPackageResolutionTest {
19+
@SkippedTest() // TODO(scheglov): implement augmentation
1920
test_fieldOfAugmentation() async {
2021
newFile('$testPackageLibPath/a.dart', r'''
2122
part 'test.dart';

‎pkg/analyzer/test/src/dart/resolution/index_expression_test.dart‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,7 @@ IndexExpression
434434
''');
435435
}
436436

437+
@SkippedTest() // TODO(scheglov): implement augmentation
437438
test_read_ofExtension_augmentation() async {
438439
newFile('$testPackageLibPath/a.dart', r'''
439440
part of 'test.dart';
@@ -1049,6 +1050,7 @@ AssignmentExpression
10491050
''');
10501051
}
10511052

1053+
@SkippedTest() // TODO(scheglov): implement augmentation
10521054
test_write_ofExtension_augmentation() async {
10531055
newFile('$testPackageLibPath/a.dart', r'''
10541056
part of 'test.dart';

‎pkg/analyzer/test/src/dart/resolution/instance_creation_test.dart‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ InstanceCreationExpression
126126
''');
127127
}
128128

129+
@SkippedTest() // TODO(scheglov): implement augmentation
129130
test_class_generic_constructor_named_augmentationDeclares() async {
130131
newFile('$testPackageLibPath/a.dart', r'''
131132
part of 'test.dart'
@@ -183,6 +184,7 @@ InstanceCreationExpression
183184
''');
184185
}
185186

187+
@SkippedTest() // TODO(scheglov): implement augmentation
186188
test_class_generic_constructor_unnamed_augmentationDeclares() async {
187189
newFile('$testPackageLibPath/a.dart', r'''
188190
part of 'test.dart'
@@ -404,6 +406,7 @@ InstanceCreationExpression
404406
''');
405407
}
406408

409+
@SkippedTest() // TODO(scheglov): implement augmentation
407410
test_class_notGeneric_constructor_named_augmentationAugments() async {
408411
newFile('$testPackageLibPath/a.dart', r'''
409412
part of 'test.dart'
@@ -448,6 +451,7 @@ InstanceCreationExpression
448451
''');
449452
}
450453

454+
@SkippedTest() // TODO(scheglov): implement augmentation
451455
test_class_notGeneric_constructor_named_augmentationDeclares() async {
452456
newFile('$testPackageLibPath/a.dart', r'''
453457
part of 'test.dart'
@@ -490,6 +494,7 @@ InstanceCreationExpression
490494
''');
491495
}
492496

497+
@SkippedTest() // TODO(scheglov): implement augmentation
493498
test_class_notGeneric_constructor_unnamed_augmentationAugments() async {
494499
newFile('$testPackageLibPath/a.dart', r'''
495500
part of 'test.dart'
@@ -528,6 +533,7 @@ InstanceCreationExpression
528533
''');
529534
}
530535

536+
@SkippedTest() // TODO(scheglov): implement augmentation
531537
test_class_notGeneric_constructor_unnamed_augmentationDeclares() async {
532538
newFile('$testPackageLibPath/a.dart', r'''
533539
part of 'test.dart'
@@ -1336,6 +1342,7 @@ InstanceCreationExpression
13361342
''');
13371343
}
13381344

1345+
@SkippedTest() // TODO(scheglov): implement augmentation
13391346
test_importPrefix_class_generic_constructor_named_augmentationDeclares() async {
13401347
newFile('$testPackageLibPath/a.dart', r'''
13411348
part 'b.dart';
@@ -1403,6 +1410,7 @@ InstanceCreationExpression
14031410
''');
14041411
}
14051412

1413+
@SkippedTest() // TODO(scheglov): implement augmentation
14061414
test_importPrefix_class_generic_constructor_unnamed_augmentationDeclares() async {
14071415
newFile('$testPackageLibPath/a.dart', r'''
14081416
part 'b.dart';
@@ -1512,6 +1520,7 @@ InstanceCreationExpression
15121520
''');
15131521
}
15141522

1523+
@SkippedTest() // TODO(scheglov): implement augmentation
15151524
test_importPrefix_class_notGeneric_constructor_named_augmentationDeclares() async {
15161525
newFile('$testPackageLibPath/a.dart', r'''
15171526
part 'b.dart';
@@ -1564,6 +1573,7 @@ InstanceCreationExpression
15641573
''');
15651574
}
15661575

1576+
@SkippedTest() // TODO(scheglov): implement augmentation
15671577
test_importPrefix_class_notGeneric_constructor_unnamed_augmentationDeclares() async {
15681578
newFile('$testPackageLibPath/a.dart', r'''
15691579
part 'b.dart';
@@ -1988,6 +1998,7 @@ InstanceCreationExpression
19881998
''');
19891999
}
19902000

2001+
@SkippedTest() // TODO(scheglov): implement augmentation
19912002
test_typeAlias_generic_class_generic_constructor_named_augmentationDeclares() async {
19922003
newFile('$testPackageLibPath/a.dart', r'''
19932004
part of 'test.dart'
@@ -2046,6 +2057,7 @@ InstanceCreationExpression
20462057
''');
20472058
}
20482059

2060+
@SkippedTest() // TODO(scheglov): implement augmentation
20492061
test_typeAlias_generic_class_generic_constructor_unnamed_augmentationDeclares() async {
20502062
newFile('$testPackageLibPath/a.dart', r'''
20512063
part of 'test.dart'
@@ -2371,6 +2383,7 @@ InstanceCreationExpression
23712383
''');
23722384
}
23732385

2386+
@SkippedTest() // TODO(scheglov): implement augmentation
23742387
test_typeAlias_notGeneric_class_notGeneric_constructor_named_augmentationDeclares() async {
23752388
newFile('$testPackageLibPath/a.dart', r'''
23762389
part of 'test.dart'
@@ -2415,6 +2428,7 @@ InstanceCreationExpression
24152428
''');
24162429
}
24172430

2431+
@SkippedTest() // TODO(scheglov): implement augmentation
24182432
test_typeAlias_notGeneric_class_notGeneric_constructor_unnamed_augmentationDeclares() async {
24192433
newFile('$testPackageLibPath/a.dart', r'''
24202434
part of 'test.dart'

0 commit comments

Comments
 (0)