[CFE] Remove more allocation from iterators

These are from `_Array.iterator` whereas the previous ones was from,
iirc, `List.iterator`.

* 7.41mb Import.finalizeImports
* 1.13mb FindTypeVisitor.visitInterfaceType
* 856.39kb new NamedTypeBuilderImpl
* 815.92kb BodyBuilder.createSuperParametersAsArguments

(values from uprobe)

When compiling the CFE with the CFE I get this:

```
msec task-clock:u: -5.6347% +/- 0.5257% (-321.96 +/- 30.04) (5713.89 -> 5391.92)
page-faults:u: 5.9842% +/- 0.0970% (6310.26 +/- 102.33) (105449.48 -> 111759.74)
cycles:u: -6.0829% +/- 0.5338% (-1447602857.06 +/- 127036484.81) (23797839542.02 -> 22350236684.96)
instructions:u: -4.9550% +/- 0.0008% (-1364113249.40 +/- 214444.14) (27529935457.16 -> 26165822207.76)
branch-misses:u: -5.7909% +/- 2.2880% (-5395643.76 +/- 2131857.44) (93173948.12 -> 87778304.36)
seconds time elapsed: -5.6275% +/- 0.5257% (-0.32 +/- 0.03) (5.72 -> 5.40)
seconds user: -6.0582% +/- 0.5861% (-0.33 +/- 0.03) (5.47 -> 5.13)
Scavenge(   new space) goes from 63 to 61
Evacuate(store buffer) goes from 2 to 3
MarkSweep(   old space) goes from 1 to 0
```

As before the changes here are mostly "bogus" and likely caused by the
GC being weird, see also
https://dart-review.googlesource.com/c/sdk/+/438722 and
https://dart-review.googlesource.com/c/sdk/+/438681.

It does seem to consistently change the number of new space GCs though
(65 -> 63 -> (here) 61).

Change-Id: I18ef712394c1d98b8ed15c7fe6c4ac32fa9bc2e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438682
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: jensjoha

pkg/front_end/lib/src/base/import.dart

@@ -98,7 +98,9 @@ class Import {
       String name = member.name;
       bool include = true;
       if (combinators != null) {
-        for (CombinatorBuilder combinator in combinators!) {
+        List<CombinatorBuilder> combinators = this.combinators!;
+        for (int i = 0; i < combinators.length; i++) {
+          CombinatorBuilder combinator = combinators[i];
           if (combinator.isShow && !combinator.names.contains(name)) {
             include = false;
             break;

pkg/front_end/lib/src/builder/named_type_builder.dart

@@ -130,7 +130,8 @@ abstract class NamedTypeBuilderImpl extends NamedTypeBuilder {
       required InstanceTypeParameterAccessState instanceTypeParameterAccess}) {
     bool isExplicit = true;
     if (arguments != null) {
-      for (TypeBuilder argument in arguments) {
+      for (int i = 0; i < arguments.length; i++) {
+        TypeBuilder argument = arguments[i];
         if (!argument.isExplicit) {
           isExplicit = false;
         }

pkg/front_end/lib/src/kernel/body_builder.dart

@@ -1153,7 +1153,8 @@ class BodyBuilder extends StackListenerImpl
   List<Object>? createSuperParametersAsArguments(
       List<FormalParameterBuilder> formals) {
     List<Object>? superParametersAsArguments;
-    for (FormalParameterBuilder formal in formals) {
+    for (int i = 0; i < formals.length; i++) {
+      FormalParameterBuilder formal = formals[i];
       if (formal.isSuperInitializingFormal) {
         if (formal.isNamed) {
           (superParametersAsArguments ??= <Object>[]).add(new NamedExpression(

pkg/kernel/lib/src/find_type_visitor.dart

@@ -31,7 +31,8 @@ class FindTypeVisitor implements DartTypeVisitor<bool> {
 
   @override
   bool visitInterfaceType(InterfaceType node) {
-    for (DartType typeArgument in node.typeArguments) {
+    for (int i = 0; i < node.typeArguments.length; i++) {
+      DartType typeArgument = node.typeArguments[i];
       if (typeArgument.accept(this)) return true;
     }
     return false;