Remove the methods now in Metadata from Annotatable

It turned out to be a relatively small change to delete the methods, so
I did them all in one CL.

Change-Id: I56bfd39c41fe2991b54d392977e4439ecca698f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390586
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: bwilkerson

pkg/analysis_server/lib/src/computer/computer_outline.dart

@@ -461,7 +461,7 @@ class _FunctionBodyOutlinesVisitor extends RecursiveAstVisitor<void> {
   /// Return `true` if the given [element] is the method 'group' defined in the
   /// test package.
   bool isGroup(engine.ExecutableElement2? element) {
-    if (element != null && element.hasIsTestGroup) {
+    if (element != null && element.metadata2.hasIsTestGroup) {
       return true;
     }
     return element is engine.TopLevelFunctionElement &&
@@ -472,7 +472,7 @@ class _FunctionBodyOutlinesVisitor extends RecursiveAstVisitor<void> {
   /// Return `true` if the given [element] is the method 'test' defined in the
   /// test package.
   bool isTest(engine.ExecutableElement2? element) {
-    if (element != null && element.hasIsTest) {
+    if (element != null && element.metadata2.hasIsTest) {
       return true;
     }
     return element is engine.TopLevelFunctionElement &&

pkg/analyzer/lib/dart/element/element2.dart

@@ -90,90 +90,6 @@ abstract class Annotatable {
   /// Returns `null` if the receiver doesn't have documentation.
   String? get documentationComment;
 
-  /// Whether the receiver has an annotation of the form `@alwaysThrows`.
-  bool get hasAlwaysThrows;
-
-  /// Whether the receiver has an annotation of the form `@deprecated`
-  /// or `@Deprecated('..')`.
-  bool get hasDeprecated;
-
-  /// Whether the receiver has an annotation of the form `@doNotStore`.
-  bool get hasDoNotStore;
-
-  /// Whether the receiver has an annotation of the form `@doNotSubmit`.
-  bool get hasDoNotSubmit;
-
-  /// Whether the receiver has an annotation of the form `@factory`.
-  bool get hasFactory;
-
-  /// Whether the receiver has an annotation of the form `@immutable`.
-  bool get hasImmutable;
-
-  /// Whether the receiver has an annotation of the form `@internal`.
-  bool get hasInternal;
-
-  /// Whether the receiver has an annotation of the form `@isTest`.
-  bool get hasIsTest;
-
-  /// Whether the receiver has an annotation of the form `@isTestGroup`.
-  bool get hasIsTestGroup;
-
-  /// Whether the receiver has an annotation of the form `@JS(..)`.
-  bool get hasJS;
-
-  /// Whether the receiver has an annotation of the form `@literal`.
-  bool get hasLiteral;
-
-  /// Whether the receiver has an annotation of the form `@mustBeConst`.
-  bool get hasMustBeConst;
-
-  /// Whether the receiver has an annotation of the form `@mustBeOverridden`.
-  bool get hasMustBeOverridden;
-
-  /// Whether the receiver has an annotation of the form `@mustCallSuper`.
-  bool get hasMustCallSuper;
-
-  /// Whether the receiver has an annotation of the form `@nonVirtual`.
-  bool get hasNonVirtual;
-
-  /// Whether the receiver has an annotation of the form `@optionalTypeArgs`.
-  bool get hasOptionalTypeArgs;
-
-  /// Whether the receiver has an annotation of the form `@override`.
-  bool get hasOverride;
-
-  /// Whether the receiver has an annotation of the form `@protected`.
-  bool get hasProtected;
-
-  /// Whether the receiver has an annotation of the form `@redeclare`.
-  bool get hasRedeclare;
-
-  /// Whether the receiver has an annotation of the form `@reopen`.
-  bool get hasReopen;
-
-  /// Whether the receiver has an annotation of the form `@required`.
-  bool get hasRequired;
-
-  /// Whether the receiver has an annotation of the form `@sealed`.
-  bool get hasSealed;
-
-  /// Whether the receiver has an annotation of the form `@useResult`
-  /// or `@UseResult('..')`.
-  bool get hasUseResult;
-
-  /// Whether the receiver has an annotation of the form `@visibleForOverriding`.
-  bool get hasVisibleForOverriding;
-
-  /// Whether the receiver has an annotation of the form `@visibleForTemplate`.
-  bool get hasVisibleForTemplate;
-
-  /// Whether the receiver has an annotation of the form `@visibleForTesting`.
-  bool get hasVisibleForTesting;
-
-  /// Whether the receiver has an annotation of the form
-  /// `@visibleOutsideTemplate`.
-  bool get hasVisibleOutsideTemplate;
-
   /// The metadata associated with the element or fragment.
   ///
   /// If the receiver is an element that has fragments, the list will include
@@ -182,23 +98,6 @@ abstract class Annotatable {
   /// The list will be empty if the receiver does not have any metadata or if
   /// the library containing this element has not yet been fully resolved.
   Metadata get metadata2;
-
-  /// The version where this SDK API was added.
-  ///
-  /// A `@Since()` annotation can be applied to a library declaration,
-  /// any public declaration in a library, or in a class, or to an optional
-  /// parameter, etc.
-  ///
-  /// The returned version is "effective", so that if a library is annotated
-  /// then all elements of the library inherit it; or if a class is annotated
-  /// then all members and constructors of the class inherit it.
-  ///
-  /// If multiple `@Since()` annotations apply to the same element, the latest
-  /// version takes precedence.
-  ///
-  /// Returns `null` if the element is not declared in the SDK, or doesn't have
-  /// a `@Since()` annotation applied to it.
-  Version? get sinceSdkVersion;
 }
 
 abstract class BindPatternVariableElement2 implements PatternVariableElement2 {}

pkg/analyzer/lib/src/dart/element/element.dart

@@ -6640,91 +6640,9 @@ class LocalFunctionElementImpl extends ExecutableElementImpl2
           .map((fragment) => fragment.element)
           .toList();
 
-  @override
-  bool get hasAlwaysThrows => _wrappedElement.hasAlwaysThrows;
-
-  @override
-  bool get hasDeprecated => _wrappedElement.hasDeprecated;
-
-  @override
-  bool get hasDoNotStore => _wrappedElement.hasDoNotStore;
-
-  @override
-  bool get hasDoNotSubmit => _wrappedElement.hasDoNotSubmit;
-
-  @override
-  bool get hasFactory => _wrappedElement.hasFactory;
-
-  @override
-  bool get hasImmutable => _wrappedElement.hasImmutable;
-
   @override
   bool get hasImplicitReturnType => _wrappedElement.hasImplicitReturnType;
 
-  @override
-  bool get hasInternal => _wrappedElement.hasInternal;
-
-  @override
-  bool get hasIsTest => _wrappedElement.hasIsTest;
-
-  @override
-  bool get hasIsTestGroup => _wrappedElement.hasIsTestGroup;
-
-  @override
-  bool get hasJS => _wrappedElement.hasJS;
-
-  @override
-  bool get hasLiteral => _wrappedElement.hasLiteral;
-
-  @override
-  bool get hasMustBeConst => _wrappedElement.hasMustBeConst;
-
-  @override
-  bool get hasMustBeOverridden => _wrappedElement.hasMustBeOverridden;
-
-  @override
-  bool get hasMustCallSuper => _wrappedElement.hasMustCallSuper;
-
-  @override
-  bool get hasNonVirtual => _wrappedElement.hasNonVirtual;
-
-  @override
-  bool get hasOptionalTypeArgs => _wrappedElement.hasOptionalTypeArgs;
-
-  @override
-  bool get hasOverride => _wrappedElement.hasOverride;
-
-  @override
-  bool get hasProtected => _wrappedElement.hasProtected;
-
-  @override
-  bool get hasRedeclare => _wrappedElement.hasRedeclare;
-
-  @override
-  bool get hasReopen => _wrappedElement.hasReopen;
-
-  @override
-  bool get hasRequired => _wrappedElement.hasRequired;
-
-  @override
-  bool get hasSealed => _wrappedElement.hasSealed;
-
-  @override
-  bool get hasUseResult => _wrappedElement.hasUseResult;
-
-  @override
-  bool get hasVisibleForOverriding => _wrappedElement.hasVisibleForOverriding;
-
-  @override
-  bool get hasVisibleForTemplate => _wrappedElement.hasVisibleForTemplate;
-
-  @override
-  bool get hasVisibleForTesting => _wrappedElement.hasVisibleForTesting;
-
-  @override
-  bool get hasVisibleOutsideTemplate =>
-      _wrappedElement.hasVisibleOutsideTemplate;
-
   @override
   bool get isAbstract => _wrappedElement.isAbstract;
 
@@ -6749,9 +6667,6 @@ class LocalFunctionElementImpl extends ExecutableElementImpl2
   @override
   DartType get returnType => _wrappedElement.returnType;
 
-  @override
-  Version? get sinceSdkVersion => _wrappedElement.sinceSdkVersion;
-
   @override
   FunctionType get type => _wrappedElement.type;
 
@@ -7080,87 +6995,6 @@ mixin MaybeAugmentedInstanceElementMixin
       .nonNulls
       .toList();
 
-  @override
-  bool get hasAlwaysThrows => declaration.hasAlwaysThrows;
-
-  @override
-  bool get hasDeprecated => declaration.hasDeprecated;
-
-  @override
-  bool get hasDoNotStore => declaration.hasDoNotStore;
-
-  @override
-  bool get hasDoNotSubmit => declaration.hasDoNotSubmit;
-
-  @override
-  bool get hasFactory => declaration.hasFactory;
-
-  @override
-  bool get hasImmutable => declaration.hasImmutable;
-
-  @override
-  bool get hasInternal => declaration.hasInternal;
-
-  @override
-  bool get hasIsTest => declaration.hasIsTest;
-
-  @override
-  bool get hasIsTestGroup => declaration.hasIsTestGroup;
-
-  @override
-  bool get hasJS => declaration.hasJS;
-
-  @override
-  bool get hasLiteral => declaration.hasLiteral;
-
-  @override
-  bool get hasMustBeConst => declaration.hasMustBeConst;
-
-  @override
-  bool get hasMustBeOverridden => declaration.hasMustBeOverridden;
-
-  @override
-  bool get hasMustCallSuper => declaration.hasMustCallSuper;
-
-  @override
-  bool get hasNonVirtual => declaration.hasNonVirtual;
-
-  @override
-  bool get hasOptionalTypeArgs => declaration.hasOptionalTypeArgs;
-
-  @override
-  bool get hasOverride => declaration.hasOverride;
-
-  @override
-  bool get hasProtected => declaration.hasProtected;
-
-  @override
-  bool get hasRedeclare => declaration.hasRedeclare;
-
-  @override
-  bool get hasReopen => declaration.hasReopen;
-
-  @override
-  bool get hasRequired => declaration.hasRequired;
-
-  @override
-  bool get hasSealed => declaration.hasSealed;
-
-  @override
-  bool get hasUseResult => declaration.hasUseResult;
-
-  @override
-  bool get hasVisibleForOverriding => declaration.hasVisibleForOverriding;
-
-  @override
-  bool get hasVisibleForTemplate => declaration.hasVisibleForTemplate;
-
-  @override
-  bool get hasVisibleForTesting => declaration.hasVisibleForTesting;
-
-  @override
-  bool get hasVisibleOutsideTemplate => declaration.hasVisibleOutsideTemplate;
-
   @override
   int get id => declaration.id;
 
@@ -7215,9 +7049,6 @@ mixin MaybeAugmentedInstanceElementMixin
       .nonNulls
       .toList();
 
-  @override
-  Version? get sinceSdkVersion => declaration.sinceSdkVersion;
-
   @override
   List<TypeParameterElement2> get typeParameters2 => declaration.typeParameters
       .map((fragment) => (fragment as TypeParameterFragment).element)