DAS: enforce non_constant_identifier_names

Change-Id: I83463db8edd76886edc635018f03e14880bb0607
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417965
Auto-Submit: Samuel Rawlins <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: srawlins

pkg/analysis_server/analysis_options.yaml

@@ -19,9 +19,6 @@ analyzer:
     # 'analyzer' (and sometimes the '_fe_analyzer_shared' package), because it
     # is tightly integrated. This will not likely change any time soon.
     implementation_imports: ignore
-    # There are just over 100 violations of this, which can likely be ignored
-    # on a case-by-case or file-by-file basis.
-    non_constant_identifier_names: ignore
     overridden_fields: ignore
     todo: ignore
     # Existing violations (361)

pkg/analysis_server/lib/src/protocol/protocol_internal.dart

@@ -15,6 +15,8 @@ import 'package:analyzer_plugin/src/utilities/client_uri_converter.dart';
 export 'package:analyzer_plugin/src/protocol/protocol_internal.dart'
     show JsonDecoder;
 
+// Ignored for legacy code reasons; this variable is used across a few packages.
+// ignore: non_constant_identifier_names
 final Map<String, RefactoringKind> REQUEST_ID_REFACTORING_KINDS =
     HashMap<String, RefactoringKind>();