[flow analysis] Actually remove skipDuplicateCheck.

In https://dart-review.googlesource.com/c/sdk/+/434261, I removed the
last call site that was passing a `true` value to the optional
parameter `skipDuplicateCheck` of `FlowAnalysis.declare`.

I that same CL, I intended to remove parameter itself, but I
forgot. This CL finishes the (now unused) parameter.

Change-Id: I97dc3c7959d58b58e4b3bbaf7116123899b8ea8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435980
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: stereotype441

pkg/_fe_analyzer_shared/lib/src/flow_analysis/flow_analysis.dart

@@ -396,16 +396,8 @@ abstract class FlowAnalysis<
   /// A function parameter is always initialized, so [initialized] is `true`.
   ///
   /// In debug builds, an assertion will normally verify that no variable gets
-  /// declared more than once. This assertion may be disabled by passing `true`
-  /// to [skipDuplicateCheck].
-  ///
-  /// TODO(paulberry): try to remove all uses of skipDuplicateCheck
-  void declare(
-    Variable variable,
-    Type staticType, {
-    required bool initialized,
-    bool skipDuplicateCheck = false,
-  });
+  /// declared more than once.
+  void declare(Variable variable, Type staticType, {required bool initialized});
 
   /// Call this method after visiting a variable pattern in a non-assignment
   /// context (or a wildcard pattern).
@@ -1598,17 +1590,10 @@ class FlowAnalysisDebug<
     Variable variable,
     Type staticType, {
     required bool initialized,
-    bool skipDuplicateCheck = false,
   }) {
     _wrap(
-      'declare($variable, $staticType, '
-      'initialized: $initialized, skipDuplicateCheck: $skipDuplicateCheck)',
-      () => _wrapped.declare(
-        variable,
-        staticType,
-        initialized: initialized,
-        skipDuplicateCheck: skipDuplicateCheck,
-      ),
+      'declare($variable, $staticType, initialized: $initialized)',
+      () => _wrapped.declare(variable, staticType, initialized: initialized),
     );
   }
 
@@ -5493,11 +5478,10 @@ class _FlowAnalysisImpl<
     Variable variable,
     Type staticType, {
     required bool initialized,
-    bool skipDuplicateCheck = false,
   }) {
     assert(staticType == operations.variableType(variable));
     assert(
-      _debugDeclaredVariables.add(variable) || skipDuplicateCheck,
+      _debugDeclaredVariables.add(variable),
       'Variable $variable already declared',
     );
     _current = _current.declare(