[DAS] Fixes Create extension method in tearoffs

Fixes: #61192
Change-Id: I92bdbb4132dd86f473faf3a4159ff6de3a6e2ad9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455760
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/correction/fix.dart

@@ -773,22 +773,22 @@ abstract final class DartFixKind {
   );
   static const createExtensionGetter = FixKind(
     'dart.fix.create.extension.getter',
-    DartFixKindPriority.ignore,
+    DartFixKindPriority.standard - 3, // Lower than createExtensionMethod
     "Create extension getter '{0}'",
   );
   static const createExtensionMethod = FixKind(
     'dart.fix.create.extension.method',
-    DartFixKindPriority.ignore,
+    DartFixKindPriority.standard - 2,
     "Create extension method '{0}'",
   );
   static const createExtensionOperator = FixKind(
     'dart.fix.create.extension.operator',
-    DartFixKindPriority.ignore,
+    DartFixKindPriority.standard - 2,
     "Create extension operator '{0}'",
   );
   static const createExtensionSetter = FixKind(
     'dart.fix.create.extension.setter',
-    DartFixKindPriority.ignore,
+    DartFixKindPriority.standard - 3, // Matching createExtensionGetter
     "Create extension setter '{0}'",
   );
   static const createField = FixKind(

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -956,6 +956,7 @@ final _builtInNonLintGenerators = <DiagnosticCode, List<ProducerGenerator>>{
   ],
   CompileTimeErrorCode.undefinedGetter: [
     ChangeTo.getterOrSetter,
+    CreateExtensionMethod.new,
     CreateExtensionGetter.new,
     CreateField.new,
     CreateGetter.new,

pkg/analysis_server/test/src/services/correction/fix/create_extension_member_test.dart

@@ -14,6 +14,7 @@ void main() {
     defineReflectiveTests(CreateExtensionGetterTest);
     defineReflectiveTests(CreateExtensionMethodTest);
     defineReflectiveTests(CreateExtensionOperatorTest);
+    defineReflectiveTests(CreateExtensionPriorityTest);
     defineReflectiveTests(CreateExtensionSetterTest);
   });
 }
@@ -1581,6 +1582,23 @@ extension <T extends num> on T {
 ''');
   }
 
+  Future<void> test_tearoff() async {
+    await resolveTestCode('''
+class A<T> {}
+
+T? Function() i<T>(A<T> a) => a.test;
+''');
+    await assertHasFix('''
+class A<T> {}
+
+T? Function() i<T>(A<T> a) => a.test;
+
+extension <T> on A<T> {
+  T? test() {}
+}
+''');
+  }
+
   Future<void> test_typeArgument_parameter() async {
     await resolveTestCode('''
 void f<T>(T p) {
@@ -1933,6 +1951,23 @@ extension on String {
   }
 }
 
+@reflectiveTest
+class CreateExtensionPriorityTest extends FixPriorityTest {
+  Future<void> test_method_getter() async {
+    await resolveTestCode('''
+class A {}
+void f(void Function() fn) {
+  f(A().test);
+}
+''');
+    await assertFixPriorityOrder([
+      DartFixKind.createField,
+      DartFixKind.createExtensionMethod,
+      DartFixKind.createExtensionGetter,
+    ]);
+  }
+}
+
 @reflectiveTest
 class CreateExtensionSetterTest extends FixProcessorTest {
   @override