Skip to content

Commit e227ed2

Browse files
srawlinsCommit Queue
authored andcommitted
DAS plugins: onError must accept one parameter
It's awkward that PluginCommunicationChannel.listen accepts a `Function?` for the `onError` parameter, but it _must_ be a `void Function(Object)` or a `void Function(Object, StackTrace)`. I wish we had static analysis for this... Change-Id: Id91a8172c7ef20e35bb8ff21736649d1501aff42 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395082 Commit-Queue: Samuel Rawlins <[email protected]> Auto-Submit: Samuel Rawlins <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent ea8b520 commit e227ed2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/analysis_server_plugin/lib/src/plugin_server.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ class PluginServer {
166166
_channel = channel;
167167
_channel.listen(_handleRequestZoned,
168168
// TODO(srawlins): Implement.
169-
onError: () {},
169+
onError: (_) {},
170170
// TODO(srawlins): Implement.
171171
onDone: () {});
172172
}

0 commit comments

Comments
 (0)