[gardening] Fix analyzer findings on observatory.

Follow-up to 6a6b9ac
TEST=ci

Change-Id: I8bda3591671ee1d0941d3313469c1df7095c03f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427321
Commit-Queue: Alexander Aprelev <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>

Author: aam

runtime/observatory/lib/app.dart

@@ -20,7 +20,6 @@ import 'package:observatory/service_html.dart';
 import 'package:observatory/src/elements/helpers/element_utils.dart';
 import 'package:observatory/src/elements/helpers/uris.dart';
 import 'package:observatory/tracer.dart';
-import 'package:observatory/utils.dart';
 
 export 'package:observatory/utils.dart';
 

runtime/observatory/lib/src/elements/class_tree.dart

@@ -8,7 +8,6 @@ import 'dart:async';
 
 import 'package:web/web.dart';
 
-import 'package:observatory/app.dart';
 import 'package:observatory/models.dart' as M;
 import 'package:observatory/src/elements/class_ref.dart';
 import 'package:observatory/src/elements/containers/virtual_tree.dart';

runtime/observatory/lib/src/elements/class_view.dart

@@ -33,7 +33,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart';
 import 'package:observatory/src/elements/object_common.dart';
 import 'package:observatory/src/elements/source_inset.dart';
 import 'package:observatory/src/elements/source_link.dart';
-import 'package:observatory/utils.dart';
 
 class ClassViewElement extends CustomElement implements Renderable {
   late RenderingScheduler<ClassViewElement> _r;

runtime/observatory/lib/src/elements/containers/search_bar.dart

@@ -7,7 +7,6 @@ import 'dart:math' as math;
 
 import 'package:web/web.dart';
 
-import 'package:observatory/app.dart';
 import 'package:observatory/src/elements/helpers/custom_element.dart';
 import 'package:observatory/src/elements/helpers/element_utils.dart';
 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';

runtime/observatory/lib/src/elements/containers/virtual_collection.dart

@@ -11,7 +11,6 @@ import 'package:observatory/src/elements/containers/search_bar.dart';
 import 'package:observatory/src/elements/helpers/custom_element.dart';
 import 'package:observatory/src/elements/helpers/element_utils.dart';
 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
-import 'package:observatory/utils.dart';
 
 typedef HTMLElement VirtualCollectionCreateCallback();
 typedef List<HTMLElement> VirtualCollectionHeaderCallback();

runtime/observatory/lib/src/elements/context_ref.dart

@@ -13,7 +13,6 @@ import 'package:observatory/src/elements/helpers/custom_element.dart';
 import 'package:observatory/src/elements/helpers/element_utils.dart';
 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
 import 'package:observatory/src/elements/helpers/uris.dart';
-import 'package:observatory/utils.dart';
 
 class ContextRefElement extends CustomElement implements Renderable {
   late RenderingScheduler<ContextRefElement> _r;

runtime/observatory/lib/src/elements/context_view.dart

@@ -22,7 +22,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
 import 'package:observatory/src/elements/nav/top_menu.dart';
 import 'package:observatory/src/elements/nav/vm_menu.dart';
 import 'package:observatory/src/elements/object_common.dart';
-import 'package:observatory/utils.dart';
 
 class ContextViewElement extends CustomElement implements Renderable {
   late RenderingScheduler<ContextViewElement> _r;

runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart

@@ -119,8 +119,6 @@ class CpuProfileVirtualTreeElement extends CustomElement implements Renderable {
           throw new Exception('Unknown ProfileTreeMode: $mode');
         }
         break;
-      default:
-        throw new Exception('Unknown SampleProfileType: $type');
     }
     if (filters != null) {
       tree = filters!.fold(tree, (dynamic tree, filter) {

runtime/observatory/lib/src/elements/error_view.dart

@@ -15,7 +15,6 @@ import 'package:observatory/src/elements/helpers/nav_bar.dart';
 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
 import 'package:observatory/src/elements/nav/notify.dart';
 import 'package:observatory/src/elements/nav/top_menu.dart';
-import 'package:observatory/utils.dart';
 
 class ErrorViewElement extends CustomElement implements Renderable {
   late RenderingScheduler<ErrorViewElement> _r;

runtime/observatory/lib/src/elements/eval_box.dart

@@ -13,7 +13,6 @@ import 'package:observatory/src/elements/helpers/any_ref.dart';
 import 'package:observatory/src/elements/helpers/custom_element.dart';
 import 'package:observatory/src/elements/helpers/element_utils.dart';
 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
-import 'package:observatory/utils.dart';
 
 class EvalBoxElement extends CustomElement implements Renderable {
   late RenderingScheduler<EvalBoxElement> _r;