[pkg:meta] deprecate Required

And a bit of other lint-ish cleanup

Change-Id: I515d37706c48acff69151e075667c7e4426a742d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424161
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Auto-Submit: Kevin Moore <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: kevmoo

pkg/analyzer/lib/src/dart/analysis/index.dart

@@ -13,7 +13,6 @@ import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/summary/format.dart';
 import 'package:analyzer/src/summary/idl.dart';
 import 'package:collection/collection.dart';
-import 'package:meta/meta.dart';
 
 Element2? declaredParameterElement(SimpleIdentifier node, Element2? element) {
   if (element == null || element.enclosingElement2 != null) {
@@ -157,9 +156,9 @@ class ElementNameComponents {
   }
 
   ElementNameComponents._({
-    @required this.parameterName,
-    @required this.classMemberName,
-    @required this.unitMemberName,
+    required this.parameterName,
+    required this.classMemberName,
+    required this.unitMemberName,
   });
 }
 

pkg/meta/CHANGELOG.md

@@ -1,5 +1,6 @@
 ## 1.16.1-wip
 
+- Mark `Required` and `required` as `@Deprecated`.
 - Update SDK constraints to `^3.5.0`.
 
 ## 1.16.0

pkg/meta/analysis_options.yaml

@@ -3,4 +3,6 @@ include: package:lints/recommended.yaml
 linter:
   rules:
     - flutter_style_todos
-    - unnecessary_ignore
+    - lines_longer_than_80_chars
+    - prefer_single_quotes
+    - unnecessary_ignore

pkg/meta/lib/meta.dart

@@ -85,7 +85,8 @@ const _Checked checked = _Checked();
 ///
 /// * the annotation is associated with anything other than a library, class,
 ///   method or getter, top-level getter or function, or
-/// * an invocation of a member that has this annotation is returned by a method,
+/// * an invocation of a member that has this annotation is returned by a
+///   function or getter that is not similarly annotated as method,
 ///   getter or function that is not similarly annotated as `doNotStore`, or
 /// * an invocation of a member that has this annotation is assigned to a field
 ///   or top-level variable.
@@ -450,12 +451,16 @@ const _Reopen reopen = _Reopen();
 /// * an invocation of a method or function does not include an argument
 ///   corresponding to a named parameter that has this annotation.
 ///
-/// **Deprecated:** This annotation is set to be deprecated and later
-/// removed in a future release of `package:meta`.
+/// **Deprecated:** This annotation is set to be removed in a future release of
+/// `package:meta`.
+///
 /// In Dart 2.12 and later, use the built-in `required` keyword
 /// to mark a named parameter as required.
 /// To learn more about `required`, check out the documentation on
 /// [named parameters](https://dart.dev/language/functions#named-parameters).
+@Deprecated(
+    'In Dart 2.12 and later, use the built-in `required` keyword to mark a '
+    'named parameter as required.')
 const Required required = Required();
 
 /// Annotation marking a class as not allowed as a super-type
@@ -553,21 +558,24 @@ class RecordUse {
   /// Creates a [RecordUse] instance.
   ///
   /// This annotation can be placed as an annotation on functions whose
-  /// statically resolved calls should be registered together with the optional
-  /// [metadata] information.
+  /// statically resolved calls should be registered
   const RecordUse();
 }
 
 /// Used to annotate a named parameter `p` in a method or function `f`.
 ///
 /// See [required] for more details.
 ///
-/// **Deprecated:** This annotation is set to be deprecated and later
-/// removed in a future release of `package:meta`.
+/// **Deprecated:** This annotation is set to be removed in a future release of
+/// `package:meta`.
+///
 /// In Dart 2.12 and later, use the built-in `required` keyword
 /// to mark a named parameter as required.
 /// To learn more about `required`, check out the documentation on
 /// [named parameters](https://dart.dev/language/functions#named-parameters).
+@Deprecated(
+    'In Dart 2.12 and later, use the built-in `required` keyword to mark a '
+    'named parameter as required.')
 class Required {
   /// A human-readable explanation of the reason why the annotated parameter is
   /// required. For example, the annotation might look like: