[DAS] Fixes completion for pattern destructing

Fixes: #61920
Change-Id: I7a2baa3a075b6416ab34031c8bb13e99db726671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/460142
Reviewed-by: Samuel Rawlins <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -2325,7 +2325,9 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
         collector.completionLocation = 'PatternField_pattern';
       }
       _forPatternFieldName(node, isKeywordNeeded: false, isTypeNeeded: false);
+      return;
     }
+    node.parent?.accept(this);
   }
 
   @override

pkg/analysis_server/test/services/completion/dart/location/object_pattern_test.dart

@@ -666,6 +666,33 @@ suggestions
 ''');
   }
 
+  Future<void> test_patternFieldName_afterColon() async {
+    await computeSuggestions('''
+void f(MyClassWithReallyBigName parameter) {
+  if (parameter case MyClassWithReallyBigName(
+    fieldWithBigName: var fieldWithReallyVeryBigName,
+    :^
+  )) {}
+}
+
+abstract class MyClassWithReallyBigName {
+  int get fieldWithBigName;
+  int get g01;
+}
+''');
+    assertResponse(r'''
+location: PatternField_pattern
+locationOpType: PatternField_pattern
+suggestions
+  final
+    kind: keyword
+  var
+    kind: keyword
+  var g01
+    kind: getter
+''');
+  }
+
   Future<void> test_property_first() async {
     await computeSuggestions('''
 void f1(Object x0) {