Tweak for StackTraceValue.

scheglov · Commit Queue · commit e964a4e38e98 · 2025-02-26T09:47:44.000-08:00
Change-Id: I308bd327a2fb0a3469631a5ef9d6f0db9a84ba13 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412341 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
diff --git a/pkg/_fe_analyzer_shared/lib/src/debug_helpers/stack_trace.dart b/pkg/_fe_analyzer_shared/lib/src/debug_helpers/stack_trace.dart
@@ -36,7 +36,7 @@ class StackTraceValue<T> {
   T get value => _value;
 
   void set value(T v) {
-    _stackTraces.add((_value, StackTrace.current));
+    _stackTraces.add((v, StackTrace.current));
     _value = v;
   }
 }
@@ -85,7 +85,7 @@ class StackTraceList<T> with ListMixin<T> implements List<T> {
 
   @override
   void addAll(Iterable<T> iterable) {
-    _stackTraces.add(('add', iterable.toList(), StackTrace.current));
+    _stackTraces.add(('addAll', iterable.toList(), StackTrace.current));
     _list.addAll(iterable);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ class StackTraceValue<T> {`
`36`	`36`	`T get value => _value;`
`37`	`37`
`38`	`38`	`void set value(T v) {`
`39`		`- _stackTraces.add((_value, StackTrace.current));`
	`39`	`+ _stackTraces.add((v, StackTrace.current));`
`40`	`40`	`_value = v;`
`41`	`41`	`}`
`42`	`42`	`}`
`@@ -85,7 +85,7 @@ class StackTraceList<T> with ListMixin<T> implements List<T> {`
`85`	`85`
`86`	`86`	`@override`
`87`	`87`	`void addAll(Iterable<T> iterable) {`
`88`		`- _stackTraces.add(('add', iterable.toList(), StackTrace.current));`
	`88`	`+ _stackTraces.add(('addAll', iterable.toList(), StackTrace.current));`
`89`	`89`	`_list.addAll(iterable);`
`90`	`90`	`}`
`91`	`91`