Skip to content

Commit e96b02a

Browse files
natebiggsCommit Queue
authored andcommitted
[dart2wasm] Skip interop test that uses module 'import' in all non-browser runtimes.
The JS interpreters do not support module loading so this test which uses the 'import' statement cannot run on them. https://dart-current-results.web.app/#/filter=co19/LibTest/js_interop/JSAnyUtilityExtension/instanceOfString_A04_t01&showAll Change-Id: I48be0c751821e70e5f97d597682f9ed75e69fdeb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/443380 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
1 parent 33ad46e commit e96b02a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/co19/co19-dart2wasm.status

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ LibTest/js_interop/NullableUndefineableJSAnyExtension/isNull_t01: SkipByDesign #
1818
LibTest/js_interop/NullableUndefineableJSAnyExtension/isUndefined_t01: SkipByDesign #isUndefined is not supported.
1919
LibTest/mirrors/*: SkipByDesign # dart:mirrors is not supported.
2020

21-
[ $compiler == dart2wasm && $runtime == d8 ]
22-
LibTest/js_interop/JSAnyUtilityExtension/instanceOfString_A04_t01: Skip # https://github.com/dart-lang/sdk/issues/61204
23-
2421
[ $compiler == dart2wasm && $browser ]
2522
Language/Expressions/Function_Invocation/async_generator_invokation_t10: SkipSlow # Issue(http://dartbug.com/55182): Will timeout on browsers (due to no asyncEnd() firing) but eagerly fail on commandline JS engines.
23+
24+
[ $compiler == dart2wasm && !$browser ]
25+
LibTest/js_interop/JSAnyUtilityExtension/instanceOfString_A04_t01: Skip # https://github.com/dart-lang/sdk/issues/61204

0 commit comments

Comments
 (0)