Elements. Rename 'LibraryElement2.functions' to 'topLevelFunctions'.

For consistency with the name of the item `TopLevelFunctionElement`,
as `List<TopLevelVariableElement2> get topLevelVariables` does.

Change-Id: I52f119493ecdfeb4005926c46f1ac14838a6d46d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396980
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/services/correction/dart/change_to.dart

@@ -238,7 +238,7 @@ class ChangeTo extends ResolvedCorrectionProducer {
       );
       // Check to this library units.
       if (prefixName == null) {
-        for (var function in unitResult.libraryElement2.functions) {
+        for (var function in unitResult.libraryElement2.topLevelFunctions) {
           finder._update(function);
         }
       }

pkg/analyzer/lib/dart/element/element2.dart

@@ -1445,12 +1445,6 @@ abstract class LibraryElement2 implements Element2, Annotatable {
   /// `part` directive.
   List<LibraryFragment> get fragments;
 
-  /// The functions defined in this library.
-  ///
-  /// There is no guarantee of the order in which the functions will be
-  /// returned. In particular, they are not guaranteed to be in lexical order.
-  List<TopLevelFunctionElement> get functions;
-
   /// The getters defined in this library.
   ///
   /// There is no guarantee of the order in which the getters will be returned.
@@ -1502,6 +1496,12 @@ abstract class LibraryElement2 implements Element2, Annotatable {
   /// In particular, they are not guaranteed to be in lexical order.
   List<SetterElement> get setters;
 
+  /// The functions defined in this library.
+  ///
+  /// There is no guarantee of the order in which the functions will be
+  /// returned. In particular, they are not guaranteed to be in lexical order.
+  List<TopLevelFunctionElement> get topLevelFunctions;
+
   /// The top level variables defined in this library.
   ///
   /// There is no guarantee of the order in which the top level variables will

pkg/analyzer/lib/src/dart/element/element.dart

@@ -6495,10 +6495,10 @@ class LibraryElementImpl extends ElementImpl
   List<ExtensionTypeElementImpl2> extensionTypes = [];
 
   @override
-  List<TopLevelFunctionElementImpl> functions = [];
+  List<MixinElementImpl2> mixins = [];
 
   @override
-  List<MixinElementImpl2> mixins = [];
+  List<TopLevelFunctionElementImpl> topLevelFunctions = [];
 
   @override
   List<TopLevelVariableElementImpl2> topLevelVariables = [];
@@ -6545,7 +6545,7 @@ class LibraryElementImpl extends ElementImpl
       ...classes,
       ...extensions,
       ...extensionTypes,
-      ...functions,
+      ...topLevelFunctions,
       ...mixins,
       ...typeAliases,
       ...getters,
@@ -6893,7 +6893,7 @@ class LibraryElementImpl extends ElementImpl
 
   @override
   TopLevelFunctionElement? getTopLevelFunction(String name) {
-    return _getElementByName(functions, name);
+    return _getElementByName(topLevelFunctions, name);
   }
 
   @override

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -1197,7 +1197,7 @@ class LibraryReader {
         fragment.element = element;
       } else {
         var element = TopLevelFunctionElementImpl(reference2, fragment);
-        _libraryElement.functions.add(element);
+        _libraryElement.topLevelFunctions.add(element);
       }
 
       var linkedData = FunctionElementLinkedData(

pkg/analyzer/lib/src/summary2/element_builder.dart

@@ -903,7 +903,7 @@ class ElementBuilder extends ThrowingAstVisitor<void> {
           elementReference,
           fragment,
         );
-        _libraryBuilder.element.functions.add(element);
+        _libraryBuilder.element.topLevelFunctions.add(element);
 
         elementBuilder = TopLevelFunctionElementBuilder(
           element: element,

pkg/analyzer/lib/src/test_utilities/find_element.dart

@@ -4,7 +4,6 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
-import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/src/test_utilities/function_ast_visitor.dart';
 import 'package:analyzer/src/utilities/extensions/element.dart';
 
@@ -468,15 +467,6 @@ abstract class _FindElementBase {
     throw StateError('Not found: $name');
   }
 
-  TopLevelFunctionElement topFunction2(String name) {
-    for (var function in (unitElement.asElement2 as LibraryElement2).functions) {
-      if (function.displayName == name) {
-        return function;
-      }
-    }
-    throw StateError('Not found: $name');
-  }
-
   PropertyAccessorElement topGet(String name) {
     return topVar(name).getter!;
   }

pkg/analyzer/lib/src/test_utilities/find_element2.dart

@@ -41,7 +41,7 @@ class FindElement2 extends _FindElementBase {
   }
 
   TopLevelFunctionElement function(String name) {
-    for (var function in libraryElement.functions) {
+    for (var function in libraryElement.topLevelFunctions) {
       if (function.name3 == name) {
         return function;
       }
@@ -186,7 +186,7 @@ class FindElement2 extends _FindElementBase {
 
     findInExecutables(libraryElement.getters);
     findInExecutables(libraryElement.setters);
-    findInExecutables(libraryElement.functions);
+    findInExecutables(libraryElement.topLevelFunctions);
 
     findInClasses(libraryElement.classes);
     findInClasses(libraryElement.enums);
@@ -463,7 +463,7 @@ abstract class _FindElementBase {
   }
 
   TopLevelFunctionElement topFunction(String name) {
-    for (var function in libraryElement.functions) {
+    for (var function in libraryElement.topLevelFunctions) {
       if (function.name3 == name) {
         return function;
       }

pkg/analyzer/test/src/summary/element_text.dart

@@ -239,7 +239,7 @@ class _Element2Writer extends _AbstractElementWriter {
       _writeElementList('getters', e, e.getters, _writeGetterElement);
       _writeElementList('setters', e, e.setters, _writeSetterElement);
       _writeElementList(
-          'functions', e, e.functions, _writeTopLevelFunctionElement);
+          'functions', e, e.topLevelFunctions, _writeTopLevelFunctionElement);
 
       if (configuration.withExportScope) {
         _sink.writelnWithIndent('exportedReferences');