Elements. Remove _resolveConstructorFieldFormals() from ElementBuilder.

With augmentations we should not do this, and we do it in LibraryBuilder already.

Change-Id: Ib642081de60d7c216824e500778f8444a87b63d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391484
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/summary2/element_builder.dart

@@ -601,10 +601,6 @@ class ElementBuilder extends ThrowingAstVisitor<void> {
 
     node.implementsClause?.accept(this);
 
-    // TODO(scheglov): We cannot do this anymore.
-    // Not for class augmentations, not for classes.
-    _resolveConstructorFieldFormals(element);
-
     if (element.augmentationTarget != null) {
       var builder = _libraryBuilder.getAugmentedBuilder(name);
       if (builder is AugmentedExtensionTypeDeclarationBuilder) {
@@ -1574,16 +1570,6 @@ class ElementBuilder extends ThrowingAstVisitor<void> {
     representation.fieldType.accept(this);
   }
 
-  void _resolveConstructorFieldFormals(InterfaceElementImpl element) {
-    for (var constructor in element.constructors) {
-      for (var parameter in constructor.parameters) {
-        if (parameter is FieldFormalParameterElementImpl) {
-          parameter.field = element.getField(parameter.name);
-        }
-      }
-    }
-  }
-
   void _visitPropertyFirst<T extends AstNode>(List<AstNode> nodes) {
     // When loading from bytes, we read fields first.
     // There is no particular reason for this - we just have to store